[FOLLOWUP][TASK] Remove migrated TYPO3_CONF_VARS/SYS/setDBinit 55/54255/4
authorBenni Mack <benni@typo3.org>
Mon, 2 Oct 2017 08:00:16 +0000 (10:00 +0200)
committerBenni Mack <benni@typo3.org>
Mon, 2 Oct 2017 22:11:05 +0000 (00:11 +0200)
This patch removes the obsolete "setDBinit" option which was migrated
in TYPO3 v8.

Resolves: #82421
Releases: master
Change-Id: I96477e4dd7e151bf74caeafa7bdc38a1cde2f484
Reviewed-on: https://review.typo3.org/54255
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
typo3/sysext/core/Configuration/DefaultConfiguration.php
typo3/sysext/core/Configuration/DefaultConfigurationDescription.yaml
typo3/sysext/core/Documentation/Changelog/master/Breaking-82421-DroppedOldDBRelatedConfigurationOptions.rst
typo3/sysext/install/Classes/Service/SilentConfigurationUpgradeService.php
typo3/sysext/install/Classes/SystemEnvironment/DatabasePlatform/MySqlCheck.php
typo3/sysext/install/Configuration/ExtensionScanner/Php/ArrayDimensionMatcher.php

index 818ff56..2eb7f92 100644 (file)
@@ -87,7 +87,6 @@ return [
         'mediafile_ext' => 'gif,jpg,jpeg,bmp,png,pdf,svg,ai,mp3,wav,mp4,ogg,flac,opus,webm,youtube,vimeo',
         'binPath' => '',
         'binSetup' => '',
-        'setDBinit' => '',
         'setMemoryLimit' => 0,
         'phpTimeZone' => '',
         'systemLog' => false,
index 0bfe8bd..66f1ded 100644 (file)
@@ -135,9 +135,6 @@ SYS:
         binSetup:
             type: multiline
             description: 'List of programs (separated by newline or comma). By default programs will be searched in default paths and the special paths defined by <code>binPath</code>. When PHP has openbasedir enabled the programs can not be found and have to be configured here. Example: <code>perl=/usr/bin/perl,unzip=/usr/local/bin/unzip</code>'
-        setDBinit:
-            type: multiline
-            description: 'These commands are executed after the database connection was established. Hint: The previous default "SET NAMES utf8;" is not required any more and will be removed automatically if set!'
         setMemoryLimit:
             type: int
             description: 'Integer: memory_limit in MB: If more than 16, TYPO3 will try to use ini_set() to set the memory limit of PHP to the value. This works only if the function ini_set() is not disabled by your sysadmin.'
index 02c1a26..d955f74 100644 (file)
@@ -13,6 +13,7 @@ Some configuration options related to pre-doctrine era have been removed
 from :php:`$GLOBALS['TYPO3_CONF_VARS']`:
 
 * `SYS/sqlDebug` - Obsolete since version 8, no substitution
+* `SYS/setDBinit` - Obsolete since core version 8 and migrated automatically
 * `SYS/no_pconnect` - Obsolete since core version 8 and migrated automatically
 * `SYS/dbClientCompress` - Obsolete since core version 8 and migrated automatically
 
index 70648c6..a5f9882 100644 (file)
@@ -105,6 +105,7 @@ class SilentConfigurationUpgradeService
         // #82421
         'SYS/sqlDebug',
         'SYS/no_pconnect',
+        'SYS/setDBinit',
         'SYS/dbClientCompress',
         // #82430
         'SYS/syslogErrorReporting',
index 7cccd7d..40c0d37 100644 (file)
@@ -89,7 +89,7 @@ class MySqlCheck implements CheckInterface
                     . ' ' . implode(', ', $detectedIncompatibleSqlModes) . '.'
                     . ' The listed modes are not compatible with TYPO3 CMS.'
                     . ' You have to change that setting in your MySQL environment'
-                    . ' or in $GLOBALS[\'TYPO3_CONF_VARS\'][\'SYS\'][\'setDBinit\']',
+                    . ' or in $GLOBALS[\'TYPO3_CONF_VARS\'][\'DB\'][\'Connections\'][\'Default\'][\'initCommands\']',
                 'Incompatible SQL modes found!',
                 FlashMessage::ERROR
             ));
index 507e3de..ea6be08 100644 (file)
@@ -39,6 +39,11 @@ return [
             'Breaking-82421-DroppedOldDBRelatedConfigurationOptions.rst',
         ],
     ],
+    '$GLOBALS[\'TYPO3_CONF_VARS\'][\'SYS\'][\'setDBinit\']' => [
+        'restFiles' => [
+            'Breaking-82421-DroppedOldDBRelatedConfigurationOptions.rst',
+        ],
+    ],
     '$GLOBALS[\'TYPO3_CONF_VARS\'][\'SYS\'][\'no_pconnect\']' => [
         'restFiles' => [
             'Breaking-82421-DroppedOldDBRelatedConfigurationOptions.rst',