[TASK] Goodbye phantomJS, hello firefox 81/50281/3
authorChristian Kuhn <lolli@schwarzbu.ch>
Wed, 19 Oct 2016 18:11:05 +0000 (20:11 +0200)
committerChristian Kuhn <lolli@schwarzbu.ch>
Wed, 19 Oct 2016 19:04:48 +0000 (21:04 +0200)
phantomJS is too unstable. Base the acceptance tests on
firefox only for now, free composer from phantom installers.

Change-Id: Id3ec1cb42488d14df442502681938c23efa2cbe4
Resolves: #78322
Releases: master
Reviewed-on: https://review.typo3.org/50281
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
composer.json
composer.lock
typo3/sysext/core/Build/AcceptanceTests.yml
typo3/sysext/core/Build/Configuration/Acceptance/Support/AcceptanceTester.php
typo3/sysext/core/Tests/Acceptance.suite.yml

index a570729..3a5517a 100644 (file)
@@ -56,8 +56,6 @@
                "codeception/codeception": "^2.2",
                "se/selenium-server-standalone": "~2.53",
                "7elix/styleguide": "~8.0.0",
-               "site5/phantoman": "^1.0",
-               "jakoch/phantomjs-installer": "2.1.1-p06",
                "friendsofphp/php-cs-fixer": "^1.12"
        },
        "suggest": {
                        "TYPO3\\CMS\\Recycler\\Tests\\": "typo3/sysext/recycler/Tests/"
                },
                "classmap": ["typo3/sysext/extbase/Tests/Unit/Object/Container/Fixtures/"]
-       },
-       "scripts": {
-               "post-install-cmd": [
-                       "PhantomInstaller\\Installer::installPhantomJS"
-               ],
-               "post-update-cmd": [
-                       "PhantomInstaller\\Installer::installPhantomJS"
-               ]
        }
-}
+}
\ No newline at end of file
index 0805642..653a4e9 100644 (file)
@@ -4,8 +4,8 @@
         "Read more about it at https://getcomposer.org/doc/01-basic-usage.md#composer-lock-the-lock-file",
         "This file is @generated automatically"
     ],
-    "hash": "46f644d4073e537db72d40863fb31541",
-    "content-hash": "b96f1764a6d015f19d8a115367e58d26",
+    "hash": "bd45a31718f3f2b434d0701affeacd7f",
+    "content-hash": "dccbff898b61e7232d2909a7d4754802",
     "packages": [
         {
             "name": "cogpowered/finediff",
             "time": "2016-09-27 07:57:59"
         },
         {
-            "name": "jakoch/phantomjs-installer",
-            "version": "2.1.1-p06",
-            "source": {
-                "type": "git",
-                "url": "https://github.com/jakoch/phantomjs-installer.git",
-                "reference": "26f870052263c00d09103928ad39c935108f51d4"
-            },
-            "dist": {
-                "type": "zip",
-                "url": "https://api.github.com/repos/jakoch/phantomjs-installer/zipball/26f870052263c00d09103928ad39c935108f51d4",
-                "reference": "26f870052263c00d09103928ad39c935108f51d4",
-                "shasum": ""
-            },
-            "require": {
-                "ext-bz2": "*",
-                "ext-openssl": "*"
-            },
-            "type": "custom-installer",
-            "autoload": {
-                "psr-0": {
-                    "PhantomInstaller\\": "src/"
-                }
-            },
-            "notification-url": "https://packagist.org/downloads/",
-            "license": [
-                "MIT"
-            ],
-            "authors": [
-                {
-                    "name": "Jens-AndrĂ© Koch",
-                    "email": "jakoch@web.de"
-                }
-            ],
-            "description": "A Composer package which installs the PhantomJS binary (Linux, Windows, Mac) into `/bin` of your project.",
-            "keywords": [
-                "binaries",
-                "headless",
-                "phantomjs"
-            ],
-            "time": "2016-08-09 10:14:29"
-        },
-        {
             "name": "mikey179/vfsStream",
             "version": "v1.6.4",
             "source": {
             "time": "2016-02-04 12:56:52"
         },
         {
-            "name": "site5/phantoman",
-            "version": "v1.1.7",
-            "source": {
-                "type": "git",
-                "url": "https://github.com/grantlucas/phantoman.git",
-                "reference": "f65d26d3311e44380692cb0255b95181743f69f2"
-            },
-            "dist": {
-                "type": "zip",
-                "url": "https://api.github.com/repos/grantlucas/phantoman/zipball/f65d26d3311e44380692cb0255b95181743f69f2",
-                "reference": "f65d26d3311e44380692cb0255b95181743f69f2",
-                "shasum": ""
-            },
-            "require": {
-                "codeception/codeception": "^2.1",
-                "php": ">=5.4.0"
-            },
-            "suggest": {
-                "jakoch/phantomjs-installer": "Automatically installs PhantomJS locally to your project."
-            },
-            "type": "library",
-            "autoload": {
-                "psr-4": {
-                    "Codeception\\Extension\\": "src/"
-                }
-            },
-            "notification-url": "https://packagist.org/downloads/",
-            "license": [
-                "MIT"
-            ],
-            "authors": [
-                {
-                    "name": "Grant Lucas",
-                    "email": "contact@grantlucas.com"
-                }
-            ],
-            "description": "The Codeception extension for automatically starting and stopping PhantomJS when running tests.",
-            "homepage": "https://github.com/grantlucas/phantoman",
-            "keywords": [
-                "codeception",
-                "extension",
-                "headless",
-                "phantomjs"
-            ],
-            "time": "2016-09-15 14:35:04"
-        },
-        {
             "name": "symfony/browser-kit",
             "version": "v3.0.6",
             "source": {
index 3a7bd73..a52860d 100644 (file)
@@ -10,11 +10,6 @@ settings:
   memory_limit: 1024M
 extensions:
   enabled:
-    - Codeception\Extension\Phantoman
     - Codeception\Extension\RunFailed
     - Codeception\Extension\Recorder
-    - TYPO3\CMS\Core\Tests\AcceptanceCoreEnvironment
-  config:
-    Codeception\Extension\Phantoman:
-      path: 'bin/phantomjs'
-      port: 4445
+    - TYPO3\CMS\Core\Tests\AcceptanceCoreEnvironment
\ No newline at end of file
index 35ae557..54392ce 100644 (file)
@@ -36,7 +36,7 @@ class AcceptanceTester extends \Codeception\Actor
         $I = $this;
         $I->amOnPage('/typo3/index.php');
 
-        // @todo: There is a bug in PhantomJS where adding a cookie fails.
+        // @todo: There is a bug in PhantomJS / firefox (?) where adding a cookie fails.
         // This bug will be fixed in the next PhantomJS version but i also found
         // this workaround. First reset / delete the cookie and than set it and catch
         // the webdriver exception as the cookie has been set successful.
index 45cc3da..c212e7c 100644 (file)
@@ -7,8 +7,8 @@ modules:
   config:
     WebDriver:
       url: http://localhost:8000/typo3temp/var/tests/acceptance
-      browser: phantomjs
-      port: 4445
+      browser: firefox
+      port: 4444
       window_size: 1440x570
       wait: 1
       restart: true
@@ -19,11 +19,4 @@ modules:
         # is overlaying it.
         # You have to ensure that the element is in the viewport by your own before clicking it!
         # You can simply do that by scrolling to it.
-        elementScrollBehavior: 1
-env:
-  firefox:
-    modules:
-      config:
-        WebDriver:
-          browser: firefox
-          port: 4444
+        elementScrollBehavior: 1
\ No newline at end of file