[BUGFIX] EM: misplaced tooltips
authorFrancois Suter <francois@typo3.org>
Fri, 27 Apr 2012 07:18:26 +0000 (09:18 +0200)
committerFrancois Suter <francois@typo3.org>
Thu, 3 May 2012 15:07:22 +0000 (17:07 +0200)
In the local list of extensions, the tooltips on the first two action
columns are misplaced. Tooltips from the second one override those
from the first one.

Change-Id: I24f02ff8b28a49e4649b7139d7d9ce196a6fceb8
Fixes: #36610
Releases: 6.0, 4.7, 4.6
Reviewed-on: http://review.typo3.org/10810
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Francois Suter
Tested-by: Francois Suter
typo3/sysext/em/res/js/em_components.js

index 380a5a0..7529194 100644 (file)
@@ -166,7 +166,8 @@ TYPO3.EM.GridColumns.InstallExtension = {
                                        this.items[0].tooltip = String.format(TYPO3.l10n.localize('menu_update_extension'), record.data.version, record.data.maxversion);
                                        return 't3-icon t3-icon-actions t3-icon-actions-system t3-icon-system-extension-update';
                                }
-                meta.css += ' paddingNoActionIcon';
+                               this.items[0].tooltip = '';
+                               meta.css += ' paddingNoActionIcon';
                                return '';
                        },
                        handler: function(grid, rowIndex, colIndex) {
@@ -201,14 +202,14 @@ TYPO3.EM.GridColumns.InstallExtension = {
                        getClass: function(value, meta, record) {
                                meta.css += ' paddingActionIcon';
                                if (record.get('installed') == 0) {
-                                       this.items[0].tooltip = TYPO3.l10n.localize('menu_install_extensions');
+                                       this.items[1].tooltip = TYPO3.l10n.localize('menu_install_extensions');
                                        return 't3-icon t3-icon-actions t3-icon-actions-system t3-icon-system-extension-install';
                                } else {
                                        if (record.get('required')) {
-                                               this.items[0].tooltip = TYPO3.l10n.localize('ext_details_always_loaded');
+                                               this.items[1].tooltip = TYPO3.l10n.localize('ext_details_always_loaded');
                                                return 't3-icon t3-icon-extensions t3-icon-extensions-em t3-icon-em-extension-required';
                                        } else {
-                                               this.items[0].tooltip = TYPO3.l10n.localize('ext_details_remove_ext');
+                                               this.items[1].tooltip = TYPO3.l10n.localize('ext_details_remove_ext');
                                                return 't3-icon t3-icon-actions t3-icon-actions-system t3-icon-system-extension-uninstall';
                                        }
                                }