[TASK] Use decent defaults for resizable textareas
authorHelmut Hummel <helmut.hummel@typo3.org>
Sun, 25 Sep 2011 17:08:31 +0000 (19:08 +0200)
committerSteffen Gebert <steffen.gebert@typo3.org>
Fri, 21 Oct 2011 20:56:45 +0000 (22:56 +0200)
* Increase the maximum size in the default values
* Do not make the textareas flexible by default
* Do not apply the max height setting to manually resizable textareas

Change-Id: I49c836b101d116fcc2205c47d73e3f640415455f
Resolves: #30274
Releases: 4.6
Reviewed-on: http://review.typo3.org/5329
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
t3lib/class.t3lib_beuserauth.php
t3lib/js/extjs/tceforms.js
typo3/sysext/setup/ext_tables.php
typo3/sysext/setup/locallang_csh_mod.xlf
typo3/sysext/setup/mod/locallang.xlf

index 6c2ee58..a1381d2 100644 (file)
@@ -104,8 +104,8 @@ class t3lib_beUserAuth extends t3lib_userAuthGroup {
                'navFrameWidth' => '', // Default is 245 pixels
                'navFrameResizable' => 0,
                'resizeTextareas' => 1,
-               'resizeTextareas_MaxHeight' => 300,
-               'resizeTextareas_Flexible' => 1,
+               'resizeTextareas_MaxHeight' => 500,
+               'resizeTextareas_Flexible' => 0,
        );
 
        /**
index 70d5fea..5341134 100644 (file)
@@ -116,7 +116,6 @@ TYPO3.TCEFORMS = {
                                var dwrapped = new Ext.Resizable(element.dom.id, {
                                        minWidth:  300,
                                        minHeight: 50,
-                                       maxHeight: TYPO3.settings.textareaMaxHeight,
                                        dynamic:   true
                                });
                        }
index d54c695..2580150 100755 (executable)
@@ -111,16 +111,16 @@ $GLOBALS['TYPO3_USER_SETTINGS'] = array(
                        'label' => 'LLL:EXT:setup/mod/locallang.xml:resizeTextareas',
                        'csh' => 'resizeTextareas',
                ),
-               'resizeTextareas_MaxHeight' => array(
-                       'type' => 'text',
-                       'label' => 'LLL:EXT:setup/mod/locallang.xml:resizeTextareas_MaxHeight',
-                       'csh' => 'resizeTextareas_MaxHeight',
-               ),
                'resizeTextareas_Flexible' => array(
                        'type' => 'check',
                        'label' => 'LLL:EXT:setup/mod/locallang.xml:resizeTextareas_Flexible',
                        'csh' => 'resizeTextareas_Flexible',
                ),
+               'resizeTextareas_MaxHeight' => array(
+                       'type' => 'text',
+                       'label' => 'LLL:EXT:setup/mod/locallang.xml:flexibleTextareas_MaxHeight',
+                       'csh' => 'flexibleTextareas_MaxHeight',
+               ),
                'debugInWindow' => array(
                        'type' => 'check',
                        'label' => 'LLL:EXT:setup/mod/locallang.xml:debugInWindow',
@@ -129,7 +129,7 @@ $GLOBALS['TYPO3_USER_SETTINGS'] = array(
        ),
        'showitem' => '--div--;LLL:EXT:setup/mod/locallang.xml:personal_data,realName,email,emailMeAtLogin,password,password2,lang,
                        --div--;LLL:EXT:setup/mod/locallang.xml:opening,startModule,thumbnailsByDefault,titleLen,
-                       --div--;LLL:EXT:setup/mod/locallang.xml:editFunctionsTab,edit_RTE,edit_wideDocument,edit_docModuleUpload,enableFlashUploader,resizeTextareas,resizeTextareas_MaxHeight,resizeTextareas_Flexible,disableCMlayers,copyLevels,recursiveDelete,
+                       --div--;LLL:EXT:setup/mod/locallang.xml:editFunctionsTab,edit_RTE,edit_wideDocument,edit_docModuleUpload,enableFlashUploader,resizeTextareas,resizeTextareas_Flexible,resizeTextareas_MaxHeight,disableCMlayers,copyLevels,recursiveDelete,
                        --div--;LLL:EXT:setup/mod/locallang.xml:adminFunctions,simulate,debugInWindow'
 
 );
index 3361219..4e8de73 100644 (file)
@@ -192,9 +192,15 @@ The default module is "About Modules".</source>
                        <trans-unit id="option_resizeTextareas_MaxHeight.alttitle" xml:space="preserve">
                                <source>Maximal Height of Textarea</source>
                        </trans-unit>
+                       <trans-unit id="option_flexibleTextareas_MaxHeight.alttitle" xml:space="preserve">
+                               <source>Maximal Height of flexible textareas</source>
+                       </trans-unit>
                        <trans-unit id="option_resizeTextareas_MaxHeight.description" xml:space="preserve">
                                <source>Define the maximal height of textarea (in Pixel).</source>
                        </trans-unit>
+                       <trans-unit id="option_flexibleTextareas_MaxHeight.description" xml:space="preserve">
+                               <source>Define the maximal height of flexible textareas (in Pixel).</source>
+                       </trans-unit>
                        <trans-unit id="option_resizeTextareas_Flexible.alttitle" xml:space="preserve">
                                <source>Make Textareas Flexible</source>
                        </trans-unit>
index b11786e..40f9517 100644 (file)
                        <trans-unit id="resizeTextareas_MaxHeight" xml:space="preserve">
                                <source>Maximal Height of resizable Textarea in Pixel</source>
                        </trans-unit>
+                       <trans-unit id="flexibleTextareas_MaxHeight" xml:space="preserve">
+                               <source>Maximal Height of flexible Textareas in Pixel</source>
+                       </trans-unit>
                        <trans-unit id="resizeTextareas_Flexible" xml:space="preserve">
                                <source>Make Textareas flexible</source>
                        </trans-unit>