[TASK] Remove breakOnError option from wizard 23/44123/3
authorBjörn Jacob <bjoern.jacob@tritum.de>
Sat, 17 Oct 2015 09:08:52 +0000 (11:08 +0200)
committerChristian Kuhn <lolli@schwarzbu.ch>
Tue, 3 Nov 2015 22:38:47 +0000 (23:38 +0100)
The validation option "breakOnError" is not supported anymore. The
option has been removed completely during the rewrite.
The patch also provides the missing documentation for the
breaking change. The documentation itself will be touched by
a differnt patch.

Resolves: #70503
Releases: master
Change-Id: Ifef11ac3e7a3efd2636280f0ff961059cf96bf95
Reviewed-on: https://review.typo3.org/44123
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
26 files changed:
typo3/sysext/core/Documentation/Changelog/master/Breaking-70503-EXTform-RemoveBreakOnErrorOptionFromWizard.rst [new file with mode: 0644]
typo3/sysext/form/Configuration/PageTS/modWizards.ts
typo3/sysext/form/Resources/Private/Language/locallang_wizard.xlf
typo3/sysext/form/Resources/Public/JavaScript/Wizard/Elements/Predefined/Email.js
typo3/sysext/form/Resources/Public/JavaScript/Wizard/Elements/Predefined/Name.js
typo3/sysext/form/Resources/Public/JavaScript/Wizard/Viewport/Left/Options/Forms/Validation/Alphabetic.js
typo3/sysext/form/Resources/Public/JavaScript/Wizard/Viewport/Left/Options/Forms/Validation/Alphanumeric.js
typo3/sysext/form/Resources/Public/JavaScript/Wizard/Viewport/Left/Options/Forms/Validation/Between.js
typo3/sysext/form/Resources/Public/JavaScript/Wizard/Viewport/Left/Options/Forms/Validation/Date.js
typo3/sysext/form/Resources/Public/JavaScript/Wizard/Viewport/Left/Options/Forms/Validation/Digit.js
typo3/sysext/form/Resources/Public/JavaScript/Wizard/Viewport/Left/Options/Forms/Validation/Email.js
typo3/sysext/form/Resources/Public/JavaScript/Wizard/Viewport/Left/Options/Forms/Validation/Equals.js
typo3/sysext/form/Resources/Public/JavaScript/Wizard/Viewport/Left/Options/Forms/Validation/FileAllowedTypes.js
typo3/sysext/form/Resources/Public/JavaScript/Wizard/Viewport/Left/Options/Forms/Validation/FileMaximumSize.js
typo3/sysext/form/Resources/Public/JavaScript/Wizard/Viewport/Left/Options/Forms/Validation/FileMinimumSize.js
typo3/sysext/form/Resources/Public/JavaScript/Wizard/Viewport/Left/Options/Forms/Validation/Float.js
typo3/sysext/form/Resources/Public/JavaScript/Wizard/Viewport/Left/Options/Forms/Validation/GreaterThan.js
typo3/sysext/form/Resources/Public/JavaScript/Wizard/Viewport/Left/Options/Forms/Validation/InArray.js
typo3/sysext/form/Resources/Public/JavaScript/Wizard/Viewport/Left/Options/Forms/Validation/Integer.js
typo3/sysext/form/Resources/Public/JavaScript/Wizard/Viewport/Left/Options/Forms/Validation/Ip.js
typo3/sysext/form/Resources/Public/JavaScript/Wizard/Viewport/Left/Options/Forms/Validation/Length.js
typo3/sysext/form/Resources/Public/JavaScript/Wizard/Viewport/Left/Options/Forms/Validation/LessThan.js
typo3/sysext/form/Resources/Public/JavaScript/Wizard/Viewport/Left/Options/Forms/Validation/RegExp.js
typo3/sysext/form/Resources/Public/JavaScript/Wizard/Viewport/Left/Options/Forms/Validation/Required.js
typo3/sysext/form/Resources/Public/JavaScript/Wizard/Viewport/Left/Options/Forms/Validation/Rule.js
typo3/sysext/form/Resources/Public/JavaScript/Wizard/Viewport/Left/Options/Forms/Validation/Uri.js

diff --git a/typo3/sysext/core/Documentation/Changelog/master/Breaking-70503-EXTform-RemoveBreakOnErrorOptionFromWizard.rst b/typo3/sysext/core/Documentation/Changelog/master/Breaking-70503-EXTform-RemoveBreakOnErrorOptionFromWizard.rst
new file mode 100644 (file)
index 0000000..e0ee4aa
--- /dev/null
@@ -0,0 +1,32 @@
+====================================================================
+Breaking: #70503 - EXT:form - Remove breakOnError option from wizard
+====================================================================
+
+Description
+===========
+
+The validation option "breakOnError" is not supported anymore. The option
+has been removed completely.
+
+
+Impact
+======
+
+The validation process cannot be interrupted anymore, i.e. the whole form
+will be validated and all error messages will be shown.
+
+
+Affected Installations
+======================
+
+Any installation that implements the breakOnError functionality.
+
+
+Migration
+=========
+
+The function has been removed without any substitution. Therefore there is
+no migration possible. The attribute can be manually removed from the form
+configuration. The wizard ignores the existence of breakOnError.
+Since TYPO3 7.5 it is possible to utilize HTML5 attributes to validate
+form elements on the fly. This could be used to emulate the behaviour.
\ No newline at end of file
index a555fea..09b61dd 100644 (file)
@@ -53,83 +53,83 @@ prefix = tx_form
 
                                                        rules {
                                                                alphabetic {
-                                                                       showProperties = message, error, breakOnError, showMessage, allowWhiteSpace
+                                                                       showProperties = message, error, showMessage, allowWhiteSpace
                                                                }
 
                                                                alphanumeric {
-                                                                       showProperties = message, error, breakOnError, showMessage, allowWhiteSpace
+                                                                       showProperties = message, error, showMessage, allowWhiteSpace
                                                                }
 
                                                                between {
-                                                                       showProperties = message, error, breakOnError, showMessage, minimum, maximum, inclusive
+                                                                       showProperties = message, error, showMessage, minimum, maximum, inclusive
                                                                }
 
                                                                date {
-                                                                       showProperties = message, error, breakOnError, showMessage, format
+                                                                       showProperties = message, error, showMessage, format
                                                                }
 
                                                                digit {
-                                                                       showProperties = message, error, breakOnError, showMessage
+                                                                       showProperties = message, error, showMessage
                                                                }
 
                                                                email {
-                                                                       showProperties = message, error, breakOnError, showMessage
+                                                                       showProperties = message, error, showMessage
                                                                }
 
                                                                equals {
-                                                                       showProperties = message, error, breakOnError, showMessage, field
+                                                                       showProperties = message, error, showMessage, field
                                                                }
 
                                                                fileallowedtypes {
-                                                                       showProperties = message, error, breakOnError, showMessage, types
+                                                                       showProperties = message, error, showMessage, types
                                                                }
 
                                                                filemaximumsize {
-                                                                       showProperties = message, error, breakOnError, showMessage, maximum
+                                                                       showProperties = message, error, showMessage, maximum
                                                                }
 
                                                                fileminimumsize {
-                                                                       showProperties = message, error, breakOnError, showMessage, minimum
+                                                                       showProperties = message, error, showMessage, minimum
                                                                }
 
                                                                float {
-                                                                       showProperties = message, error, breakOnError, showMessage
+                                                                       showProperties = message, error, showMessage
                                                                }
 
                                                                greaterthan {
-                                                                       showProperties = message, error, breakOnError, showMessage, minimum
+                                                                       showProperties = message, error, showMessage, minimum
                                                                }
 
                                                                inarray {
-                                                                       showProperties = message, error, breakOnError, showMessage, array, strict
+                                                                       showProperties = message, error, showMessage, array, strict
                                                                }
 
                                                                integer {
-                                                                       showProperties = message, error, breakOnError, showMessage
+                                                                       showProperties = message, error, showMessage
                                                                }
 
                                                                ip {
-                                                                       showProperties = message, error, breakOnError, showMessage
+                                                                       showProperties = message, error, showMessage
                                                                }
 
                                                                length {
-                                                                       showProperties = message, error, breakOnError, showMessage, minimum, maximum
+                                                                       showProperties = message, error, showMessage, minimum, maximum
                                                                }
 
                                                                lessthan {
-                                                                       showProperties = message, error, breakOnError, showMessage, maximum
+                                                                       showProperties = message, error, showMessage, maximum
                                                                }
 
                                                                regexp {
-                                                                       showProperties = message, error, breakOnError, showMessage, expression
+                                                                       showProperties = message, error, showMessage, expression
                                                                }
 
                                                                required {
-                                                                       showProperties = message, error, breakOnError, showMessage
+                                                                       showProperties = message, error, showMessage
                                                                }
 
                                                                uri {
-                                                                       showProperties = message, error, breakOnError, showMessage
+                                                                       showProperties = message, error, showMessage
                                                                }
                                                        }
                                                }
index d0dc0dc..3551230 100644 (file)
                        <trans-unit id="validation_properties_error">
                                <source>Error</source>
                        </trans-unit>
-                       <trans-unit id="validation_properties_breakonerror">
-                               <source>Break on error</source>
-                       </trans-unit>
                        <trans-unit id="validation_properties_showmessage">
                                <source>Show message in label</source>
                        </trans-unit>
index 8fe7519..84eb97a 100644 (file)
@@ -22,13 +22,11 @@ TYPO3.Form.Wizard.Elements.Predefined.Email = Ext.extend(TYPO3.Form.Wizard.Eleme
                                },
                                validation: {
                                        required: {
-                                               breakOnError: 0,
                                                showMessage: 1,
                                                message: TYPO3.l10n.localize('tx_form_system_validate_required.message'),
                                                error: TYPO3.l10n.localize('tx_form_system_validate_required.error')
                                        },
                                        email: {
-                                               breakOnError: 0,
                                                showMessage: 1,
                                                message: TYPO3.l10n.localize('tx_form_system_validate_email.message'),
                                                error: TYPO3.l10n.localize('tx_form_system_validate_email.error')
index 20e4e6b..8cc1437 100644 (file)
@@ -86,7 +86,6 @@ TYPO3.Form.Wizard.Elements.Predefined.Name = Ext.extend(TYPO3.Form.Wizard.Elemen
                                layout: 'back',
                                validation: {
                                        required: {
-                                               breakOnError: 0,
                                                showMessage: true,
                                                message: '*',
                                                error: 'Required'
@@ -126,7 +125,6 @@ TYPO3.Form.Wizard.Elements.Predefined.Name = Ext.extend(TYPO3.Form.Wizard.Elemen
                                layout: 'back',
                                validation: {
                                        required: {
-                                               breakOnError: 0,
                                                showMessage: true,
                                                message: '*',
                                                error: 'Required'
index c59fe33..eb9fd1a 100644 (file)
@@ -23,7 +23,6 @@ TYPO3.Form.Wizard.Viewport.Left.Options.Forms.Validation.Alphabetic = Ext.extend
        constructor: function(config) {
                Ext.apply(this, {
                        configuration: {
-                               breakOnError: 0,
                                showMessage: 1,
                                message: TYPO3.l10n.localize('tx_form_system_validate_alphabetic.message'),
                                error: TYPO3.l10n.localize('tx_form_system_validate_alphabetic.error'),
index 6c02255..bbd4cdf 100644 (file)
@@ -23,7 +23,6 @@ TYPO3.Form.Wizard.Viewport.Left.Options.Forms.Validation.Alphanumeric = Ext.exte
        constructor: function(config) {
                Ext.apply(this, {
                        configuration: {
-                               breakOnError: 0,
                                showMessage: 1,
                                message: TYPO3.l10n.localize('tx_form_system_validate_alphanumeric.message'),
                                error: TYPO3.l10n.localize('tx_form_system_validate_alphanumeric.error'),
index b55e4ad..bb45fc9 100644 (file)
@@ -23,7 +23,6 @@ TYPO3.Form.Wizard.Viewport.Left.Options.Forms.Validation.Between = Ext.extend(TY
        constructor: function(config) {
                Ext.apply(this, {
                        configuration: {
-                               breakOnError: 0,
                                showMessage: 1,
                                message: TYPO3.l10n.localize('tx_form_system_validate_between.message'),
                                error: TYPO3.l10n.localize('tx_form_system_validate_between.error'),
index b559ecd..ac222c0 100644 (file)
@@ -23,7 +23,6 @@ TYPO3.Form.Wizard.Viewport.Left.Options.Forms.Validation.Date = Ext.extend(TYPO3
        constructor: function(config) {
                Ext.apply(this, {
                        configuration: {
-                               breakOnError: 0,
                                showMessage: 1,
                                message: TYPO3.l10n.localize('tx_form_system_validate_date.message'),
                                error: TYPO3.l10n.localize('tx_form_system_validate_date.error'),
index 751f228..501dafd 100644 (file)
@@ -23,7 +23,6 @@ TYPO3.Form.Wizard.Viewport.Left.Options.Forms.Validation.Digit = Ext.extend(TYPO
        constructor: function(config) {
                Ext.apply(this, {
                        configuration: {
-                               breakOnError: 0,
                                showMessage: 1,
                                message: TYPO3.l10n.localize('tx_form_system_validate_digit.message'),
                                error: TYPO3.l10n.localize('tx_form_system_validate_digit.error')
index 4cad511..391e772 100644 (file)
@@ -23,7 +23,6 @@ TYPO3.Form.Wizard.Viewport.Left.Options.Forms.Validation.Email = Ext.extend(TYPO
        constructor: function(config) {
                Ext.apply(this, {
                        configuration: {
-                               breakOnError: 0,
                                showMessage: 1,
                                message: TYPO3.l10n.localize('tx_form_system_validate_email.message'),
                                error: TYPO3.l10n.localize('tx_form_system_validate_email.error')
index 1fe7dca..f80f8c1 100644 (file)
@@ -23,7 +23,6 @@ TYPO3.Form.Wizard.Viewport.Left.Options.Forms.Validation.Equals = Ext.extend(TYP
        constructor: function(config) {
                Ext.apply(this, {
                        configuration: {
-                               breakOnError: 0,
                                showMessage: 1,
                                message: TYPO3.l10n.localize('tx_form_system_validate_equals.message'),
                                error: TYPO3.l10n.localize('tx_form_system_validate_equals.error'),
index 52f8a31..ba7baa1 100644 (file)
@@ -23,7 +23,6 @@ TYPO3.Form.Wizard.Viewport.Left.Options.Forms.Validation.FileAllowedTypes = Ext.
        constructor: function(config) {
                Ext.apply(this, {
                        configuration: {
-                               breakOnError: 0,
                                showMessage: 1,
                                message: TYPO3.l10n.localize('tx_form_system_validate_fileallowedtypes.message'),
                                error: TYPO3.l10n.localize('tx_form_system_validate_fileallowedtypes.error'),
index 8da64e5..967e722 100644 (file)
@@ -23,7 +23,6 @@ TYPO3.Form.Wizard.Viewport.Left.Options.Forms.Validation.FileMaximumSize = Ext.e
        constructor: function(config) {
                Ext.apply(this, {
                        configuration: {
-                               breakOnError: 0,
                                showMessage: 1,
                                message: TYPO3.l10n.localize('tx_form_system_validate_filemaximumsize.message'),
                                error: TYPO3.l10n.localize('tx_form_system_validate_filemaximumsize.error'),
index f55c32c..5304191 100644 (file)
@@ -23,7 +23,6 @@ TYPO3.Form.Wizard.Viewport.Left.Options.Forms.Validation.FileMinimumSize = Ext.e
        constructor: function(config) {
                Ext.apply(this, {
                        configuration: {
-                               breakOnError: 0,
                                showMessage: 1,
                                message: TYPO3.l10n.localize('tx_form_system_validate_fileminimumsize.message'),
                                error: TYPO3.l10n.localize('tx_form_system_validate_fileminimumsize.error'),
index 830c305..e189f46 100644 (file)
@@ -23,7 +23,6 @@ TYPO3.Form.Wizard.Viewport.Left.Options.Forms.Validation.Float = Ext.extend(TYPO
        constructor: function(config) {
                Ext.apply(this, {
                        configuration: {
-                               breakOnError: 0,
                                showMessage: 1,
                                message: TYPO3.l10n.localize('tx_form_system_validate_float.message'),
                                error: TYPO3.l10n.localize('tx_form_system_validate_float.error')
index f2aa049..795a460 100644 (file)
@@ -23,7 +23,6 @@ TYPO3.Form.Wizard.Viewport.Left.Options.Forms.Validation.GreaterThan = Ext.exten
        constructor: function(config) {
                Ext.apply(this, {
                        configuration: {
-                               breakOnError: 0,
                                showMessage: 1,
                                message: TYPO3.l10n.localize('tx_form_system_validate_greaterthan.message'),
                                error: TYPO3.l10n.localize('tx_form_system_validate_greaterthan.error'),
index cbd8815..0f92208 100644 (file)
@@ -23,7 +23,6 @@ TYPO3.Form.Wizard.Viewport.Left.Options.Forms.Validation.InArray = Ext.extend(TY
        constructor: function(config) {
                Ext.apply(this, {
                        configuration: {
-                               breakOnError: 0,
                                showMessage: 1,
                                message: TYPO3.l10n.localize('tx_form_system_validate_inarray.message'),
                                error: TYPO3.l10n.localize('tx_form_system_validate_inarray.error'),
index 38e982e..5219315 100644 (file)
@@ -23,7 +23,6 @@ TYPO3.Form.Wizard.Viewport.Left.Options.Forms.Validation.Integer = Ext.extend(TY
        constructor: function(config) {
                Ext.apply(this, {
                        configuration: {
-                               breakOnError: 0,
                                showMessage: 1,
                                message: TYPO3.l10n.localize('tx_form_system_validate_integer.message'),
                                error: TYPO3.l10n.localize('tx_form_system_validate_integer.error')
index be7abed..7e65761 100644 (file)
@@ -23,7 +23,6 @@ TYPO3.Form.Wizard.Viewport.Left.Options.Forms.Validation.Ip = Ext.extend(TYPO3.F
        constructor: function(config) {
                Ext.apply(this, {
                        configuration: {
-                               breakOnError: 0,
                                showMessage: 1,
                                message: TYPO3.l10n.localize('tx_form_system_validate_ip.message'),
                                error: TYPO3.l10n.localize('tx_form_system_validate_ip.error')
index c720ae7..7ba06c3 100644 (file)
@@ -23,7 +23,6 @@ TYPO3.Form.Wizard.Viewport.Left.Options.Forms.Validation.Length = Ext.extend(TYP
        constructor: function(config) {
                Ext.apply(this, {
                        configuration: {
-                               breakOnError: 0,
                                showMessage: 1,
                                message: TYPO3.l10n.localize('tx_form_system_validate_length.message'),
                                error: TYPO3.l10n.localize('tx_form_system_validate_length.error'),
index c62a9e0..a3db3b6 100644 (file)
@@ -23,7 +23,6 @@ TYPO3.Form.Wizard.Viewport.Left.Options.Forms.Validation.LessThan = Ext.extend(T
        constructor: function(config) {
                Ext.apply(this, {
                        configuration: {
-                               breakOnError: 0,
                                showMessage: 1,
                                message: TYPO3.l10n.localize('tx_form_system_validate_lessthan.message'),
                                error: TYPO3.l10n.localize('tx_form_system_validate_lessthan.error'),
index 8ef6088..059eda3 100644 (file)
@@ -23,7 +23,6 @@ TYPO3.Form.Wizard.Viewport.Left.Options.Forms.Validation.RegExp = Ext.extend(TYP
        constructor: function(config) {
                Ext.apply(this, {
                        configuration: {
-                               breakOnError: 0,
                                showMessage: 1,
                                message: TYPO3.l10n.localize('tx_form_system_validate_regexp.message'),
                                error: TYPO3.l10n.localize('tx_form_system_validate_regexp.error'),
index ffddc2c..f15fe85 100644 (file)
@@ -23,7 +23,6 @@ TYPO3.Form.Wizard.Viewport.Left.Options.Forms.Validation.Required = Ext.extend(T
        constructor: function(config) {
                Ext.apply(this, {
                        configuration: {
-                               breakOnError: 0,
                                showMessage: 1,
                                message: TYPO3.l10n.localize('tx_form_system_validate_required.message'),
                                error: TYPO3.l10n.localize('tx_form_system_validate_required.error')
index b470ae6..50716f6 100644 (file)
@@ -91,20 +91,6 @@ TYPO3.Form.Wizard.Viewport.Left.Options.Forms.Validation.Rule = Ext.extend(Ext.F
                                                }
                                        });
                                        break;
-                               case 'breakOnError':
-                                       formItems.push({
-                                               xtype: 'checkbox',
-                                               fieldLabel: TYPO3.l10n.localize('validation_properties_breakonerror'),
-                                               name: 'breakOnError',
-                                               inputValue: '1',
-                                               listeners: {
-                                                       'check': {
-                                                               scope: this,
-                                                               fn: this.storeValue
-                                                       }
-                                               }
-                                       });
-                                       break;
                                case 'showMessage':
                                        formItems.push({
                                                xtype: 'checkbox',
@@ -396,7 +382,6 @@ TYPO3.Form.Wizard.Viewport.Left.Options.Forms.Validation.Rule = Ext.extend(Ext.F
                        allowedGeneralFields = [
                                'message',
                                'error',
-                               'breakOnError',
                                'showMessage',
                                'allowWhiteSpace',
                                'minimum',
index 47a38c3..5503a70 100644 (file)
@@ -23,7 +23,6 @@ TYPO3.Form.Wizard.Viewport.Left.Options.Forms.Validation.Uri = Ext.extend(TYPO3.
        constructor: function(config) {
                Ext.apply(this, {
                        configuration: {
-                               breakOnError: 0,
                                showMessage: 1,
                                message: TYPO3.l10n.localize('tx_form_system_validate_uri.message'),
                                error: TYPO3.l10n.localize('tx_form_system_validate_uri.error')