[TASK] Remove unneeded SingletonInstance resets in recent extbase tests 34/61234/2
authorBenjamin Franzke <bfr@qbus.de>
Fri, 5 Jul 2019 11:54:51 +0000 (13:54 +0200)
committerAndreas Fernandez <a.fernandez@scripting-base.de>
Fri, 5 Jul 2019 12:15:43 +0000 (14:15 +0200)
These were introduced with the recent extbase configuration manager
hardening but are not needed, because there are no singletons
triggered via makeInstance in these tests.

Change-Id: Iae4d55acd8a02997dd8fc256231c39503a8cfc88
Resolves: #88693
Related: #87628
Releases: master
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61234
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
typo3/sysext/extbase/Tests/Unit/Configuration/AbstractConfigurationManagerTest.php
typo3/sysext/extbase/Tests/Unit/Configuration/BackendConfigurationManagerTest.php
typo3/sysext/extbase/Tests/Unit/Configuration/FrontendConfigurationManagerTest.php
typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Mapper/DataMapperTest.php
typo3/sysext/extbase/Tests/Unit/Persistence/Generic/QueryTest.php
typo3/sysext/extbase/Tests/Unit/Persistence/Generic/SessionTest.php

index 5aacdeb..70ba5c8 100644 (file)
@@ -27,8 +27,6 @@ use TYPO3\TestingFramework\Core\Unit\UnitTestCase;
  */
 class AbstractConfigurationManagerTest extends UnitTestCase
 {
-    protected $resetSingletonInstances = true;
-
     /**
      * @var AbstractConfigurationManager|\PHPUnit_Framework_MockObject_MockObject|AccessibleObjectInterface
      */
index 8e29d21..1550863 100644 (file)
@@ -23,8 +23,6 @@ use TYPO3\TestingFramework\Core\Unit\UnitTestCase;
  */
 class BackendConfigurationManagerTest extends UnitTestCase
 {
-    protected $resetSingletonInstances = true;
-
     /**
      * @var \TYPO3\CMS\Extbase\Configuration\BackendConfigurationManager|\PHPUnit_Framework_MockObject_MockObject|\TYPO3\TestingFramework\Core\AccessibleObjectInterface
      */
index cb8b199..f71cf26 100644 (file)
@@ -29,8 +29,6 @@ use TYPO3\TestingFramework\Core\Unit\UnitTestCase;
  */
 class FrontendConfigurationManagerTest extends UnitTestCase
 {
-    protected $resetSingletonInstances = true;
-
     /**
      * @var ContentObjectRenderer|\PHPUnit_Framework_MockObject_MockObject
      */
index ed2ceaa..aafd577 100644 (file)
@@ -29,8 +29,6 @@ use TYPO3\TestingFramework\Core\Unit\UnitTestCase;
  */
 class DataMapperTest extends UnitTestCase
 {
-    protected $resetSingletonInstances = true;
-
     /**
      * This test does not actually test anything rather than map calls both mocked methods getTargetType and mapSingleRow
      * while completely ignoring the result of the method.
index c7dd4ef..3d4fa82 100644 (file)
@@ -21,8 +21,6 @@ use TYPO3\TestingFramework\Core\Unit\UnitTestCase;
  */
 class QueryTest extends UnitTestCase
 {
-    protected $resetSingletonInstances = true;
-
     /**
      * @var \TYPO3\CMS\Extbase\Persistence\Generic\Query|\PHPUnit_Framework_MockObject_MockObject|\TYPO3\TestingFramework\Core\AccessibleObjectInterface
      */
index f26ea5e..1fa5881 100644 (file)
@@ -22,8 +22,6 @@ use TYPO3\TestingFramework\Core\Unit\UnitTestCase;
 
 class SessionTest extends UnitTestCase
 {
-    protected $resetSingletonInstances = true;
-
     /**
      * @test
      */