[TASK] Deprecate itemListStyle and selectedListStyle 02/52302/2
authorChristian Kuhn <lolli@schwarzbu.ch>
Fri, 31 Mar 2017 18:39:53 +0000 (20:39 +0200)
committerFrank Naegler <frank.naegler@typo3.org>
Fri, 31 Mar 2017 19:34:25 +0000 (21:34 +0200)
The two TCA properties itemListStyle and selectedListStyle which have
already been dropped in other elements are fully deprecated.
The concept of adding CSS at single places in the elements
is very limited and does not cope with bigger HTML changes planned
for v9.

Change-Id: I1d99b724b0caafe5e1feecc0f1f924498da6a354
Resolves: #80614
Releases: master
Reviewed-on: https://review.typo3.org/52302
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
typo3/sysext/backend/Classes/Form/Element/SelectMultipleSideBySideElement.php
typo3/sysext/backend/Classes/Form/Element/SelectSingleBoxElement.php
typo3/sysext/core/Documentation/Changelog/master/Deprecation-80614-TCAItemListStyleAndSelectedListStyle.rst [new file with mode: 0644]

index 9c34a24..c4ba061 100644 (file)
@@ -16,6 +16,7 @@ namespace TYPO3\CMS\Backend\Form\Element;
 
 use TYPO3\CMS\Core\Authentication\BackendUserAuthentication;
 use TYPO3\CMS\Core\Imaging\Icon;
+use TYPO3\CMS\Core\Utility\GeneralUtility;
 use TYPO3\CMS\Core\Utility\MathUtility;
 use TYPO3\CMS\Core\Utility\StringUtility;
 use TYPO3\CMS\Lang\LanguageService;
@@ -194,10 +195,12 @@ class SelectMultipleSideBySideElement extends AbstractFormElement
         }
         $selectedListStyle = '';
         if (isset($config['selectedListStyle'])) {
+            GeneralUtility::deprecationLog('TCA property selectedListStyle is deprecated since TYPO3 v8 and will be removed in v9');
             $selectedListStyle = ' style="' . htmlspecialchars($config['selectedListStyle']) . '"';
         }
         $selectableListStyle = '';
         if (isset($config['itemListStyle'])) {
+            GeneralUtility::deprecationLog('TCA property itemListStyle is deprecated since TYPO3 v8 and will be removed in v9');
             $selectableListStyle = ' style="' . htmlspecialchars($config['itemListStyle']) . '"';
         }
 
index c3cc635..fdad3f4 100644 (file)
@@ -185,6 +185,7 @@ class SelectSingleBoxElement extends AbstractFormElement
             $attributes['disabled'] = 'disabled';
         }
         if (isset($config['itemListStyle'])) {
+            GeneralUtility::deprecationLog('TCA property itemListStyle is deprecated since TYPO3 v8 and will be removed in v9');
             $attributes['style'] = $config['itemListStyle'];
         }
 
diff --git a/typo3/sysext/core/Documentation/Changelog/master/Deprecation-80614-TCAItemListStyleAndSelectedListStyle.rst b/typo3/sysext/core/Documentation/Changelog/master/Deprecation-80614-TCAItemListStyleAndSelectedListStyle.rst
new file mode 100644 (file)
index 0000000..db1f11e
--- /dev/null
@@ -0,0 +1,35 @@
+.. include:: ../../Includes.txt
+
+=============================================================
+Deprecation: #80614 - TCA itemListStyle and selectedListStyle
+=============================================================
+
+See :issue:`80614`
+
+Description
+===========
+
+The TCA property :code:`itemListStyle` available in renderType :code:`selectSingleBox` and
+:code:`selectMultipleSideBySide`, as well as the property :code:`selectedListStyle` available in
+renderType :code:`selectMultipleSideBySide` have been deprecated.
+
+
+Impact
+======
+
+Using these properties throws a deprecation warning and will not be considered with TYPO3 v9.
+
+
+Affected Installations
+======================
+
+Instances using one of the above properties in TCA
+
+
+Migration
+=========
+
+The properties can be dropped. Changing styles of above elements should be done in own renderTypes
+or by overloading CSS in the backend.
+
+.. index:: Backend, TCA
\ No newline at end of file