[TASK] Extensionmanager: Change download icon 21/34821/3
authorFrank Nägler <typo3@naegler.net>
Sun, 30 Nov 2014 17:12:46 +0000 (18:12 +0100)
committerAnja Leichsenring <aleichsenring@ab-softlab.de>
Sun, 30 Nov 2014 18:04:32 +0000 (19:04 +0100)
* Show details: import icon as download
* Distributions: change icon in button

Resolves: #63240
Releases: master
Change-Id: I92be1b2c091c01ae63dcc6d84614288dfde0329f
Reviewed-on: http://review.typo3.org/34821
Reviewed-by: Frederic Gaus <gaus@flagbit.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
typo3/sysext/extensionmanager/Classes/ViewHelpers/DownloadExtensionViewHelper.php
typo3/sysext/extensionmanager/Resources/Private/Partials/List/Distribution.html
typo3/sysext/extensionmanager/Resources/Private/Templates/List/Distributions.html
typo3/sysext/extensionmanager/Resources/Public/JavaScript/ter.js

index d2314c3..0db9e47 100644 (file)
@@ -13,6 +13,8 @@ namespace TYPO3\CMS\Extensionmanager\ViewHelpers;
  *
  * The TYPO3 project - inspiring people to share!
  */
+use TYPO3\CMS\Extbase\Utility\LocalizationUtility;
+
 /**
  * view helper
  *
@@ -52,8 +54,10 @@ class DownloadExtensionViewHelper extends \TYPO3\CMS\Fluid\ViewHelpers\FormViewH
                $this->tag->addAttribute('data-href', $uri);
 
                // @TODO Clean-up
-               $iconClasses = "t3-icon t3-icon-actions t3-icon-system-extension-import";
-               $label = '<input title="' . \TYPO3\CMS\Extbase\Utility\LocalizationUtility::translate('extensionList.downloadViewHelper.submit', 'extensionmanager') . '" type="submit" class="' . $iconClasses . '" value="' . \TYPO3\CMS\Extbase\Utility\LocalizationUtility::translate('extensionList.downloadViewHelper.submit', 'extensionmanager') . '">';
+               $iconClasses = 'btn fa fa-cloud-download';
+               $label = '<div class="btn-group"><button title="' . LocalizationUtility::translate('extensionList.downloadViewHelper.submit', 'extensionmanager') .
+                       '" type="submit" class="' . $iconClasses . '" value="' .
+                       LocalizationUtility::translate('extensionList.downloadViewHelper.submit', 'extensionmanager') . '" /></div>';
 
                $this->tag->setContent($label . $pathSelector);
                $this->tag->addAttribute('class', 'download');
index 69871ae..1182094 100644 (file)
@@ -31,7 +31,7 @@
                </h2>
                <div class="distribution-install">
                        <f:link.action action="installDistribution" controller="Download" arguments="{extension:distribution}" class="t3-button t3-button-action-installdistribution">
-                               <span class="t3-icon t3-icon-actions t3-icon-system-extension-import">&nbsp;</span><f:translate key="extensionList.installDistribution">Install</f:translate>
+                               <span class="fa fa-cloud-download">&nbsp;</span><f:translate key="extensionList.installDistribution">Install</f:translate>
                        </f:link.action>
                        <f:if condition="{official}">
                                <span class="distribution-official">
@@ -40,4 +40,4 @@
                        </f:if>
                </div>
        </div>
-</div>
\ No newline at end of file
+</div>
index 70bbddd..32e8a8a 100644 (file)
@@ -25,8 +25,8 @@
                <f:else>
                        <p>{f:translate(key: 'extensionList.installImpexp')}</p>
                        <f:link.action action="toggleExtensionInstallationState" controller="Action" arguments="{extensionKey: 'impexp'}" class="t3-button t3-button-action-installdistribution">
-                               <span class="t3-icon t3-icon-actions t3-icon-system-extension-import">&nbsp;</span><f:translate key="distribution.installImpexp">Install impexp</f:translate>
+                               <span class="fa fa-cloud-download">&nbsp;</span><f:translate key="distribution.installImpexp">Install impexp</f:translate>
                        </f:link.action>
                </f:else>
        </f:if>
-</f:section>
\ No newline at end of file
+</f:section>
index 2a369c3..bd81fef 100644 (file)
@@ -67,7 +67,7 @@
        });
 
        function bindDownload() {
-               var installButtons = $('.downloadFromTer form.download input[type=submit]');
+               var installButtons = $('.downloadFromTer form.download button[type=submit]');
                installButtons.off('click');
                installButtons.on('click', function(event) {
                        event.preventDefault();