[TASK] Fix superfluous strlen() on constant strings

Releases: 6.2, 6.1, 6.0
Resolves: #53477
Change-Id: I27817df25c126beb216c2b933c82ad9c35b74d80
Reviewed-on: https://review.typo3.org/25242
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

diff --git a/typo3/sysext/core/Classes/Core/SystemEnvironmentBuilder.php b/typo3/sysext/core/Classes/Core/SystemEnvironmentBuilder.php
index 56d2150..faa3e70 100644 (file)
--- a/typo3/sysext/core/Classes/Core/SystemEnvironmentBuilder.php
+++ b/typo3/sysext/core/Classes/Core/SystemEnvironmentBuilder.php
@@ -445,7 +445,7 @@ class SystemEnvironmentBuilder {
         * @return string Absolute path to document root of installation
         */
        static protected function getPathSiteByTypo3ModulePath() {
-               if (substr(TYPO3_MOD_PATH, 0, strlen('sysext/')) === 'sysext/' || substr(TYPO3_MOD_PATH, 0, strlen('ext/')) === 'ext/' || substr(TYPO3_MOD_PATH, 0, strlen('install/')) === 'install/') {
+               if (substr(TYPO3_MOD_PATH, 0, 7) === 'sysext/' || substr(TYPO3_MOD_PATH, 0, 4) === 'ext/' || substr(TYPO3_MOD_PATH, 0, 8) === 'install/') {
                        $pathPartRelativeToDocumentRoot = TYPO3_mainDir . TYPO3_MOD_PATH;
                } elseif (substr(TYPO3_MOD_PATH, 0, strlen('../typo3conf/')) === '../typo3conf/') {
                        $pathPartRelativeToDocumentRoot = substr(TYPO3_MOD_PATH, 3);