[TASK] Disable a series of functional tests with mssql 46/53046/2
authorChristian Kuhn <lolli@schwarzbu.ch>
Fri, 2 Jun 2017 13:44:37 +0000 (15:44 +0200)
committerChristian Kuhn <lolli@schwarzbu.ch>
Fri, 2 Jun 2017 14:47:28 +0000 (16:47 +0200)
Disable mysql specific tests for mssql. This list is
nearly identical to the postgres skipped tests.
Only a couple of additional skips are added in extbase where
extbase relies on non standard query constructs that postgres
and mysql support, but mssql doesn't. This will need a more
intrusive change later, but can't be solved easily now.

Change-Id: I0db8f8f094498ff47255c6cd08c03644b58ff4ca
Resolves: #81424
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53042
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-on: https://review.typo3.org/53046

typo3/sysext/core/Tests/Functional/Cache/Backend/Typo3DatabaseBackendTest.php
typo3/sysext/core/Tests/Functional/Database/DatabaseConnectionTest.php
typo3/sysext/core/Tests/Functional/Database/PreparedStatementTest.php
typo3/sysext/core/Tests/Functional/Database/Schema/SchemaMigratorTest.php
typo3/sysext/extbase/Tests/Functional/Persistence/CountTest.php
typo3/sysext/extbase/Tests/Functional/Persistence/QueryParserTest.php
typo3/sysext/impexp/Tests/Functional/Import/PagesAndTtContentWithImagesInEmptyDatabaseTest.php
typo3/sysext/install/Tests/Functional/SqlSchemaMigrationServiceTest.php
typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Modify/ActionTest.php

index 32f7cbe..0ece081 100644 (file)
@@ -402,6 +402,7 @@ class Typo3DatabaseBackendTest extends \TYPO3\TestingFramework\Core\Functional\F
      * @test
      *
      * @group not-postgres
+     * @group not-mssql
      */
     public function flushByTagWorksWithEmptyCacheTablesWithMysql()
     {
@@ -413,6 +414,7 @@ class Typo3DatabaseBackendTest extends \TYPO3\TestingFramework\Core\Functional\F
      * @test
      *
      * @group not-postgres
+     * @group not-mssql
      */
     public function flushByTagsWorksWithEmptyCacheTablesWithMysql()
     {
@@ -424,6 +426,7 @@ class Typo3DatabaseBackendTest extends \TYPO3\TestingFramework\Core\Functional\F
      * @test
      *
      * @group not-postgres
+     * @group not-mssql
      */
     public function flushByTagRemovesCorrectRowsFromDatabaseWithMysql()
     {
@@ -444,6 +447,7 @@ class Typo3DatabaseBackendTest extends \TYPO3\TestingFramework\Core\Functional\F
      * @test
      *
      * @group not-postgres
+     * @group not-mssql
      */
     public function flushByTagsRemovesCorrectRowsFromDatabaseWithMysql()
     {
@@ -518,6 +522,7 @@ class Typo3DatabaseBackendTest extends \TYPO3\TestingFramework\Core\Functional\F
      * @test
      *
      * @group not-postgres
+     * @group not-mssql
      */
     public function collectGarbageWorksWithEmptyTableWithMysql()
     {
@@ -529,6 +534,7 @@ class Typo3DatabaseBackendTest extends \TYPO3\TestingFramework\Core\Functional\F
      * @test
      *
      * @group not-postgres
+     * @group not-mssql
      */
     public function collectGarbageRemovesCacheEntryWithExpiredLifetimeWithMysql()
     {
@@ -560,6 +566,7 @@ class Typo3DatabaseBackendTest extends \TYPO3\TestingFramework\Core\Functional\F
      * @test
      *
      * @group not-postgres
+     * @group not-mssql
      */
     public function collectGarbageRemovesTagEntriesForCacheEntriesWithExpiredLifetimeWithMysql()
     {
@@ -591,6 +598,7 @@ class Typo3DatabaseBackendTest extends \TYPO3\TestingFramework\Core\Functional\F
      * @test
      *
      * @group not-postgres
+     * @group not-mssql
      */
     public function collectGarbageRemovesOrphanedTagEntriesFromTagsTableWithMysql()
     {
index 9e3d03c..eb386c8 100644 (file)
@@ -73,6 +73,7 @@ class DatabaseConnectionTest extends \TYPO3\TestingFramework\Core\Functional\Fun
      * @test
      *
      * @group not-postgres
+     * @group not-mssql
      */
     public function selectDbReturnsTrue()
     {
@@ -83,6 +84,7 @@ class DatabaseConnectionTest extends \TYPO3\TestingFramework\Core\Functional\Fun
      * @test
      *
      * @group not-postgres
+     * @group not-mssql
      */
     public function selectDbReturnsFalse()
     {
@@ -98,6 +100,7 @@ class DatabaseConnectionTest extends \TYPO3\TestingFramework\Core\Functional\Fun
      * @test
      *
      * @group not-postgres
+     * @group not-mssql
      */
     public function sqlAffectedRowsReturnsCorrectAmountOfRows()
     {
@@ -109,6 +112,7 @@ class DatabaseConnectionTest extends \TYPO3\TestingFramework\Core\Functional\Fun
      * @test
      *
      * @group not-postgres
+     * @group not-mssql
      */
     public function sqlInsertIdReturnsCorrectId()
     {
@@ -120,6 +124,7 @@ class DatabaseConnectionTest extends \TYPO3\TestingFramework\Core\Functional\Fun
      * @test
      *
      * @group not-postgres
+     * @group not-mssql
      */
     public function noSqlError()
     {
@@ -131,6 +136,7 @@ class DatabaseConnectionTest extends \TYPO3\TestingFramework\Core\Functional\Fun
      * @test
      *
      * @group not-postgres
+     * @group not-mssql
      */
     public function sqlErrorWhenInsertIntoInexistentField()
     {
@@ -142,6 +148,7 @@ class DatabaseConnectionTest extends \TYPO3\TestingFramework\Core\Functional\Fun
      * @test
      *
      * @group not-postgres
+     * @group not-mssql
      */
     public function noSqlErrorCode()
     {
@@ -153,6 +160,7 @@ class DatabaseConnectionTest extends \TYPO3\TestingFramework\Core\Functional\Fun
      * @test
      *
      * @group not-postgres
+     * @group not-mssql
      */
     public function sqlErrorNoWhenInsertIntoInexistentField()
     {
@@ -164,6 +172,7 @@ class DatabaseConnectionTest extends \TYPO3\TestingFramework\Core\Functional\Fun
      * @test
      *
      * @group not-postgres
+     * @group not-mssql
      */
     public function sqlPconnectReturnsInstanceOfMySqli()
     {
@@ -174,6 +183,7 @@ class DatabaseConnectionTest extends \TYPO3\TestingFramework\Core\Functional\Fun
      * @test
      *
      * @group not-postgres
+     * @group not-mssql
      */
     public function connectDbThrowsExeptionsWhenNoDatabaseIsGiven()
     {
@@ -189,6 +199,7 @@ class DatabaseConnectionTest extends \TYPO3\TestingFramework\Core\Functional\Fun
      * @test
      *
      * @group not-postgres
+     * @group not-mssql
      */
     public function connectDbConnectsToDatabaseWithoutErrors()
     {
@@ -200,6 +211,7 @@ class DatabaseConnectionTest extends \TYPO3\TestingFramework\Core\Functional\Fun
      * @test
      *
      * @group not-postgres
+     * @group not-mssql
      */
     public function disconnectIfConnectedDisconnects()
     {
@@ -261,6 +273,7 @@ class DatabaseConnectionTest extends \TYPO3\TestingFramework\Core\Functional\Fun
      * @param string $expectedResult
      *
      * @group not-postgres
+     * @group not-mssql
      */
     public function fullQuoteStrReturnsQuotedString($values, $expectedResult)
     {
@@ -387,6 +400,7 @@ class DatabaseConnectionTest extends \TYPO3\TestingFramework\Core\Functional\Fun
      * @param string $expectedResult
      *
      * @group not-postgres
+     * @group not-mssql
      */
     public function fullQuoteArrayQuotesArray($values, $expectedResult)
     {
@@ -435,6 +449,7 @@ class DatabaseConnectionTest extends \TYPO3\TestingFramework\Core\Functional\Fun
      * @param string $expectedResult Quoted string we expect
      *
      * @group not-postgres
+     * @group not-mssql
      */
     public function quoteStrQuotesDoubleQuotesCorrectly($string, $expectedResult)
     {
@@ -446,6 +461,7 @@ class DatabaseConnectionTest extends \TYPO3\TestingFramework\Core\Functional\Fun
      * @test
      *
      * @group not-postgres
+     * @group not-mssql
      */
     public function adminQueryReturnsTrueForInsertQuery()
     {
@@ -458,6 +474,7 @@ class DatabaseConnectionTest extends \TYPO3\TestingFramework\Core\Functional\Fun
      * @test
      *
      * @group not-postgres
+     * @group not-mssql
      */
     public function adminQueryReturnsTrueForUpdateQuery()
     {
@@ -474,6 +491,7 @@ class DatabaseConnectionTest extends \TYPO3\TestingFramework\Core\Functional\Fun
      * @test
      *
      * @group not-postgres
+     * @group not-mssql
      */
     public function adminQueryReturnsTrueForDeleteQuery()
     {
@@ -488,6 +506,7 @@ class DatabaseConnectionTest extends \TYPO3\TestingFramework\Core\Functional\Fun
      * @test
      *
      * @group not-postgres
+     * @group not-mssql
      */
     public function adminQueryReturnsResultForSelectQuery()
     {
@@ -504,6 +523,7 @@ class DatabaseConnectionTest extends \TYPO3\TestingFramework\Core\Functional\Fun
      * @test
      *
      * @group not-postgres
+     * @group not-mssql
      */
     public function adminGetCharsetsReturnsArrayWithCharsets()
     {
@@ -521,6 +541,7 @@ class DatabaseConnectionTest extends \TYPO3\TestingFramework\Core\Functional\Fun
      * @test
      *
      * @group not-postgres
+     * @group not-mssql
      */
     public function adminGetKeysReturnIndexKeysOfTable()
     {
@@ -532,6 +553,7 @@ class DatabaseConnectionTest extends \TYPO3\TestingFramework\Core\Functional\Fun
      * @test
      *
      * @group not-postgres
+     * @group not-mssql
      */
     public function adminGetFieldsReturnFieldInformationsForTable()
     {
@@ -544,6 +566,7 @@ class DatabaseConnectionTest extends \TYPO3\TestingFramework\Core\Functional\Fun
      * @test
      *
      * @group not-postgres
+     * @group not-mssql
      */
     public function adminGetTablesReturnAllTablesFromDatabase()
     {
@@ -556,6 +579,7 @@ class DatabaseConnectionTest extends \TYPO3\TestingFramework\Core\Functional\Fun
      * @test
      *
      * @group not-postgres
+     * @group not-mssql
      */
     public function adminGetDbsReturnsAllDatabases()
     {
@@ -599,6 +623,7 @@ class DatabaseConnectionTest extends \TYPO3\TestingFramework\Core\Functional\Fun
      * @param string $expectedResult
      *
      * @group not-postgres
+     * @group not-mssql
      */
     public function sqlNumRowsReturnsCorrectAmountOfRows($sql, $expectedResult)
     {
@@ -617,6 +642,7 @@ class DatabaseConnectionTest extends \TYPO3\TestingFramework\Core\Functional\Fun
      * @test
      *
      * @group not-postgres
+     * @group not-mssql
      */
     public function sqlNumRowsReturnsFalse()
     {
@@ -656,6 +682,7 @@ class DatabaseConnectionTest extends \TYPO3\TestingFramework\Core\Functional\Fun
      * @test
      *
      * @group not-postgres
+     * @group not-mssql
      */
     public function sqlFetchAssocReturnsAssocArray()
     {
@@ -715,6 +742,7 @@ class DatabaseConnectionTest extends \TYPO3\TestingFramework\Core\Functional\Fun
      * @test
      *
      * @group not-postgres
+     * @group not-mssql
      */
     public function sqlFetchRowReturnsNumericArray()
     {
@@ -737,6 +765,7 @@ class DatabaseConnectionTest extends \TYPO3\TestingFramework\Core\Functional\Fun
      * @test
      *
      * @group not-postgres
+     * @group not-mssql
      */
     public function sqlFreeResultReturnsFalseOnFailure()
     {
@@ -751,6 +780,7 @@ class DatabaseConnectionTest extends \TYPO3\TestingFramework\Core\Functional\Fun
      * @test
      *
      * @group not-postgres
+     * @group not-mssql
      */
     public function sqlFreeResultReturnsTrueOnSuccess()
     {
index b7e016f..8076914 100644 (file)
@@ -73,6 +73,7 @@ class PreparedStatementTest extends \TYPO3\TestingFramework\Core\Functional\Func
      * @test
      *
      * @group not-postgres
+     * @group not-mssql
      */
     public function prepareSelectQueryCreateValidQuery()
     {
index 32ff6eb..ba724e2 100644 (file)
@@ -200,6 +200,7 @@ class SchemaMigratorTest extends \TYPO3\TestingFramework\Core\Functional\Functio
     /**
      * @test
      * @group not-postgres
+     * @group not-mssql
      */
     public function renameUnusedField()
     {
@@ -309,6 +310,7 @@ class SchemaMigratorTest extends \TYPO3\TestingFramework\Core\Functional\Functio
     /**
      * @test
      * @group not-postgres
+     * @group not-mssql
      */
     public function installCanPerformChangeOperations()
     {
@@ -325,6 +327,7 @@ class SchemaMigratorTest extends \TYPO3\TestingFramework\Core\Functional\Functio
     /**
      * @test
      * @group not-postgres
+     * @group not-mssql
      */
     public function importStaticDataInsertsRecords()
     {
@@ -351,6 +354,7 @@ class SchemaMigratorTest extends \TYPO3\TestingFramework\Core\Functional\Functio
     /**
      * @test
      * @group not-postgres
+     * @group not-mssql
      */
     public function changeTableEngine()
     {
index 2e7c7b1..5354161 100644 (file)
@@ -185,6 +185,7 @@ class CountTest extends \TYPO3\TestingFramework\Core\Functional\FunctionalTestCa
      * Test if count works with subproperties in multiple left join.
      *
      * @test
+     * @group not-mssql
      */
     public function subpropertyInMultipleLeftJoinCountTest()
     {
index 77dc942..50b8f62 100644 (file)
@@ -63,6 +63,7 @@ class QueryParserTest extends \TYPO3\TestingFramework\Core\Functional\Functional
 
     /**
      * @test
+     * @group not-mssql
      */
     public function queryWithMultipleRelationsToIdenticalTablesReturnsExpectedResultForOrQuery()
     {
@@ -87,6 +88,7 @@ class QueryParserTest extends \TYPO3\TestingFramework\Core\Functional\Functional
      * Test ColumnMap::RELATION_HAS_AND_BELONGS_TO_MANY
      *
      * @test
+     * @group not-mssql
      */
     public function queryWithRelationHasAndBelongsToManyReturnsExpectedResult()
     {
@@ -104,6 +106,7 @@ class QueryParserTest extends \TYPO3\TestingFramework\Core\Functional\Functional
      * Test ColumnMap::RELATION_HAS_MANY
      *
      * @test
+     * @group not-mssql
      */
     public function queryWithRelationHasManyWithoutParentKeyFieldNameReturnsExpectedResult()
     {
@@ -122,6 +125,7 @@ class QueryParserTest extends \TYPO3\TestingFramework\Core\Functional\Functional
      * Test ColumnMap::RELATION_HAS_ONE, ColumnMap::ColumnMap::RELATION_HAS_AND_BELONGS_TO_MANY
      *
      * @test
+     * @group not-mssql
      */
     public function queryWithRelationHasOneAndHasAndBelongsToManyWithoutParentKeyFieldNameReturnsExpectedResult()
     {
@@ -137,6 +141,7 @@ class QueryParserTest extends \TYPO3\TestingFramework\Core\Functional\Functional
 
     /**
      * @test
+     * @group not-mssql
      */
     public function orReturnsExpectedResult()
     {
@@ -155,6 +160,7 @@ class QueryParserTest extends \TYPO3\TestingFramework\Core\Functional\Functional
 
     /**
      * @test
+     * @group not-mssql
      */
     public function queryWithMultipleRelationsToIdenticalTablesReturnsExpectedResultForAndQuery()
     {
@@ -174,6 +180,7 @@ class QueryParserTest extends \TYPO3\TestingFramework\Core\Functional\Functional
 
     /**
      * @test
+     * @group not-mssql
      */
     public function queryWithFindInSetReturnsExpectedResult()
     {
index b05e683..c188994 100644 (file)
@@ -171,6 +171,7 @@ class PagesAndTtContentWithImagesInEmptyDatabaseTest extends AbstractImportExpor
     /**
      * @test
      * @group not-postgres
+     * @group not-mssql
      */
     public function importPagesAndRelatedTtContentWithImageWithForcedUids()
     {
index 2d1545e..af543ae 100644 (file)
@@ -37,6 +37,7 @@ class SqlSchemaMigrationServiceTest extends \TYPO3\TestingFramework\Core\Functio
      * @test
      *
      * @group not-postgres
+     * @group not-mssql
      */
     public function columnAndKeyDeletionDoesNotReturnAnError()
     {
index b5f4cc1..80e6bfd 100644 (file)
@@ -585,6 +585,7 @@ class ActionTest extends \TYPO3\CMS\Workspaces\Tests\Functional\DataHandling\Reg
      * @test
      * @see DataSet/changeContentSortingAndCopyDraftPage.csv
      * @group not-postgres
+     * @group not-mssql
      * @todo Analyse PostgreSQL issues further, which is a generic issue
      */
     public function changeContentSortingAndCopyDraftPage()