[BUGFIX] Always hide the loading spinner of System Information 05/53605/2
authorAndreas Fernandez <a.fernandez@scripting-base.de>
Thu, 27 Jul 2017 05:40:05 +0000 (07:40 +0200)
committerChristian Kuhn <lolli@schwarzbu.ch>
Thu, 27 Jul 2017 08:07:10 +0000 (10:07 +0200)
If the AJAX request that fetches information for the System Information
toolbar item fails for whatever reason, the spinner is now removed.

This may happen when the session times out and the re-login modal is shown
for a longer period.

Resolves: #81984
Releases: master, 8.7
Change-Id: Ibe9566d29d403e64d55fd0f462d452413d863f0a
Reviewed-on: https://review.typo3.org/53605
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
typo3/sysext/backend/Resources/Public/JavaScript/Toolbar/SystemInformationMenu.js

index 5421ca4..145f85b 100644 (file)
@@ -77,9 +77,11 @@ define([
                        success: function(data) {
                                $menuContainer.html(data);
                                SystemInformationMenu.updateCounter();
-                               $(SystemInformationMenu.identifier.toolbarIconSelector, SystemInformationMenu.identifier.containerSelector).replaceWith($existingIcon);
 
                                SystemInformationMenu.initialize();
+                       },
+                       complete: function() {
+                               $(SystemInformationMenu.identifier.toolbarIconSelector, SystemInformationMenu.identifier.containerSelector).replaceWith($existingIcon);
                        }
                }).done(function(){
                        // reload error data every five minutes