[BUGFIX] Select/deselect all in database analyzer doesn't work 97/20897/3
authorWouter Wolters <typo3@wouterwolters.nl>
Sat, 18 May 2013 12:25:08 +0000 (14:25 +0200)
committerFrancois Suter <francois@typo3.org>
Sat, 18 May 2013 15:41:09 +0000 (17:41 +0200)
Due to the introduction of jQuery in the Install Tool the
select/deselect is broken. Remove the inline onclick event and
put the new logic in install.js

Change-Id: I74602929c2097c111dbad0ef02743bd69ad2c189
Resolves: #48168
Releases: 6.2
Reviewed-on: https://review.typo3.org/20897
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Francois Suter
Tested-by: Francois Suter
typo3/sysext/install/Resources/Private/Templates/GenerateUpdateDatabaseFormCheckboxes.html
typo3/sysext/install/Resources/Public/Javascript/install.js

index 38d57c9..f411f13 100644 (file)
@@ -15,7 +15,7 @@
                        <ol>
                                <!-- ###MULTIPLETABLES### begin -->
                                <li class="t3-install-form-label-after">
-                                       <input type="checkbox" id="###SELECTALLID###" ###CHECKED### onclick="$('###TABLEID###').select('input[type=checkbox]').invoke('setValue', $(this).checked);" />
+                                       <input class="checkall" type="checkbox" id="###SELECTALLID###" ###CHECKED### />
                                        <label for="###SELECTALLID###">###SELECTDESELECTALL###</label>
                                </li>
                                <!-- ###MULTIPLETABLES### end -->
index f01eeaa..46d413d 100644 (file)
@@ -41,4 +41,9 @@ $(document).ready(function() {
                });
        });
 
+       // Used in database compare section to select/deselect checkboxes
+       $('.checkall').on('click', function() {
+               $(this).closest('fieldset').find(':checkbox').prop('checked', this.checked);
+       });
+
 });
\ No newline at end of file