[TASK] Remove internal log method from ConditionMatcher 02/54402/2
authorBenni Mack <benni@typo3.org>
Mon, 16 Oct 2017 10:21:20 +0000 (12:21 +0200)
committerSusanne Moog <susanne.moog@typo3.org>
Mon, 16 Oct 2017 14:43:00 +0000 (16:43 +0200)
ConditionMatcher has a log method which is never used.

Resolves: #82770
Releases: master
Change-Id: I8554f253260601a8511dacdbca3ddfc894be80bd
Reviewed-on: https://review.typo3.org/54402
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
typo3/sysext/backend/Classes/Configuration/TypoScript/ConditionMatching/ConditionMatcher.php
typo3/sysext/core/Classes/Configuration/TypoScript/ConditionMatching/AbstractConditionMatcher.php
typo3/sysext/frontend/Classes/Configuration/TypoScript/ConditionMatching/ConditionMatcher.php

index 17a3661..6d5d92f 100644 (file)
@@ -274,18 +274,6 @@ class ConditionMatcher extends AbstractConditionMatcher
     }
 
     /**
-     * Set/write a log message.
-     *
-     * @param string $message The log message to set/write
-     */
-    protected function log($message)
-    {
-        if (is_object($this->getBackendUserAuthentication())) {
-            $this->getBackendUserAuthentication()->writelog(3, 0, 1, 0, $message, []);
-        }
-    }
-
-    /**
      * @return \TYPO3\CMS\Core\Authentication\BackendUserAuthentication
      */
     protected function getBackendUserAuthentication()
index 1c67ec5..704a6be 100644 (file)
@@ -652,11 +652,4 @@ abstract class AbstractConditionMatcher
      * @return bool Determines if a user is logged in
      */
     abstract protected function isUserLoggedIn();
-
-    /**
-     * Sets a log message.
-     *
-     * @param string $message The log message to set/write
-     */
-    abstract protected function log($message);
 }
index 1f597c3..b536d0f 100644 (file)
@@ -15,7 +15,6 @@ namespace TYPO3\CMS\Frontend\Configuration\TypoScript\ConditionMatching;
  */
 
 use TYPO3\CMS\Core\Configuration\TypoScript\ConditionMatching\AbstractConditionMatcher;
-use TYPO3\CMS\Core\TimeTracker\TimeTracker;
 use TYPO3\CMS\Core\Utility\GeneralUtility;
 
 /**
@@ -174,30 +173,10 @@ class ConditionMatcher extends AbstractConditionMatcher
     }
 
     /**
-     * Set/write a log message.
-     *
-     * @param string $message The log message to set/write
-     */
-    protected function log($message)
-    {
-        if ($this->getTimeTracker() !== null) {
-            $this->getTimeTracker()->setTSlogMessage($message, 3);
-        }
-    }
-
-    /**
      * @return \TYPO3\CMS\Frontend\Controller\TypoScriptFrontendController
      */
     protected function getTypoScriptFrontendController()
     {
         return $GLOBALS['TSFE'];
     }
-
-    /**
-     * @return TimeTracker
-     */
-    protected function getTimeTracker()
-    {
-        return GeneralUtility::makeInstance(TimeTracker::class);
-    }
 }