[TASK] Use 'wizard_element_browser' instead of 'browser' in FormEngine 92/42692/2
authorMarkus Klein <markus.klein@typo3.org>
Mon, 17 Aug 2015 20:12:06 +0000 (22:12 +0200)
committerBenni Mack <benni@typo3.org>
Tue, 18 Aug 2015 11:41:24 +0000 (13:41 +0200)
FormEngine is the last place using the module 'browser'.
This module is the ElementBrowserFramesetController,
which uses a frameset. The frameset has no further functionality
and the additional JS provided by the class, is not used anymore.

We can therefore use the 'wizard_element_browser' module directly,
which does not render a frameset.

Resolves: #69140
Releases: master
Change-Id: Ibfc8147a6e822655ebd2e8f347f6f55c0e8382e5
Reviewed-on: http://review.typo3.org/42692
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Benni Mack <benni@typo3.org>
typo3/sysext/backend/Classes/Form/FormEngine.php

index f88875f..ce34d96 100644 (file)
@@ -1234,7 +1234,7 @@ class FormEngine {
                        }
                        // load the main module for FormEngine with all important JS functions
                        $this->requireJsModules['TYPO3/CMS/Backend/FormEngine'] = 'function(FormEngine) {
-                               FormEngine.setBrowserUrl(' . GeneralUtility::quoteJSvalue(BackendUtility::getModuleUrl('browser')) . ');
+                               FormEngine.setBrowserUrl(' . GeneralUtility::quoteJSvalue(BackendUtility::getModuleUrl('wizard_element_browser')) . ');
                        }';
                        $this->requireJsModules['TYPO3/CMS/Backend/FormEngineValidation'] = 'function(FormEngineValidation) {
                                FormEngineValidation.setUsMode(' . ($GLOBALS['TYPO3_CONF_VARS']['SYS']['USdateFormat'] ? '1' : '0') . ');