[TASK] Cleanup parameter mismatches 23/58123/2
authorWouter Wolters <typo3@wouterwolters.nl>
Sun, 2 Sep 2018 10:40:10 +0000 (12:40 +0200)
committerAnja Leichsenring <aleichsenring@ab-softlab.de>
Sun, 2 Sep 2018 11:52:27 +0000 (13:52 +0200)
Cleanup function calls that use more parameters than their declaration.

Resolves: #86083
Releases: master
Change-Id: Ic662cf71db4262141fe8754346ff45654d26091d
Reviewed-on: https://review.typo3.org/58123
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
typo3/sysext/core/Classes/DataHandling/DataHandler.php
typo3/sysext/extbase/Classes/Persistence/Generic/Backend.php
typo3/sysext/extbase/Classes/Validation/Validator/CollectionValidator.php
typo3/sysext/form/Classes/Domain/Runtime/FormRuntime.php
typo3/sysext/reports/Classes/Report/Status/ConfigurationStatus.php

index d890234..1900599 100644 (file)
@@ -3968,7 +3968,7 @@ class DataHandler implements LoggerAwareInterface
         if ($this->isReferenceField($conf) || $inlineSubType === 'mm') {
             $value = $this->copyRecord_processManyToMany($table, $uid, $field, $value, $conf, $language);
         } elseif ($inlineSubType !== false) {
-            $value = $this->copyRecord_processInline($table, $uid, $field, $value, $row, $conf, $realDestPid, $language, $workspaceOptions, $inlineSubType);
+            $value = $this->copyRecord_processInline($table, $uid, $field, $value, $row, $conf, $realDestPid, $language, $workspaceOptions);
         }
         // For "flex" fieldtypes we need to traverse the structure for two reasons: If there are file references they have to be prepended with absolute paths and if there are database reference they MIGHT need to be remapped (still done in remapListedDBRecords())
         if ($conf['type'] === 'flex') {
index f3f6035..746db32 100644 (file)
@@ -394,7 +394,7 @@ class Backend implements \TYPO3\CMS\Extbase\Persistence\Generic\BackendInterface
                 }
             } elseif ($propertyValue instanceof \TYPO3\CMS\Extbase\DomainObject\DomainObjectInterface
                 && $object instanceof ObjectMonitoringInterface) {
-                if ($object->_isDirty($propertyName)) {
+                if ($object->_isDirty()) {
                     if ($propertyValue->_isNew()) {
                         $this->insertObject($propertyValue, $object, $propertyName);
                     }
index 45705b9..b8ec1d8 100644 (file)
@@ -87,11 +87,7 @@ class CollectionValidator extends GenericObjectValidator
             if (isset($this->options['elementValidator'])) {
                 $collectionElementValidator = $this->validatorResolver->createValidator($this->options['elementValidator']);
             } elseif (isset($this->options['elementType'])) {
-                if (isset($this->options['validationGroups'])) {
-                    $collectionElementValidator = $this->validatorResolver->getBaseValidatorConjunction($this->options['elementType'], $this->options['validationGroups']);
-                } else {
-                    $collectionElementValidator = $this->validatorResolver->getBaseValidatorConjunction($this->options['elementType']);
-                }
+                $collectionElementValidator = $this->validatorResolver->getBaseValidatorConjunction($this->options['elementType']);
             } else {
                 return;
             }
index 363b0a8..082f878 100644 (file)
@@ -616,7 +616,7 @@ class FormRuntime implements RootRenderableInterface, \ArrayAccess
 
         $renderer->setControllerContext($controllerContext);
         $renderer->setFormRuntime($this);
-        return $renderer->render($this);
+        return $renderer->render();
     }
 
     /**
index d931a0f..c3f280e 100644 (file)
@@ -152,7 +152,7 @@ class ConfigurationStatus implements StatusProviderInterface
                 }
                 $memcachedConnection = @memcache_connect($host, $port);
                 if ($memcachedConnection != null) {
-                    memcache_close($memcachedConnection);
+                    memcache_close();
                 } else {
                     $failedConnections[] = $configuredServer;
                 }