[!!!][TASK] Remove magic setter for $fromTC 46/32946/3
authorWouter Wolters <typo3@wouterwolters.nl>
Tue, 23 Sep 2014 18:25:16 +0000 (20:25 +0200)
committerChristian Kuhn <lolli@schwarzbu.ch>
Wed, 24 Sep 2014 13:40:21 +0000 (15:40 +0200)
Resolves: #61823
Releases: master
Change-Id: I5997954508ecdddb10fc286f5be40fe27cc75d6f
Reviewed-on: http://review.typo3.org/32946
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
typo3/sysext/core/Classes/Database/RelationHandler.php
typo3/sysext/core/Documentation/Changelog/master/Breaking-61823-RemoveMagicSettterForFromTC.rst [new file with mode: 0644]

index 5aa9603..f4d6ed6 100644 (file)
@@ -358,23 +358,6 @@ class RelationHandler {
        }
 
        /**
-        * Magic setter method.
-        * Used for compatibility with changed attribute visibility
-        *
-        * @param string $name name of the attribute
-        * @param mixed $value value to set the attribute to
-        * @deprecated since 6.1, only required as compatibility layer for renamed attribute $fromTC
-        */
-       public function __set($name, $value) {
-               if($name === 'fromTC') {
-                       GeneralUtility::deprecationLog(
-                               '$fromTC is protected since TYPO3 6.1. Use setFetchAllFields() instead!'
-                       );
-                       $this->setFetchAllFields(!$value);
-               }
-       }
-
-       /**
         * Sets $fetchAllFields
         *
         * @param boolean $allFields enables fetching of all fields in getFromDB()
diff --git a/typo3/sysext/core/Documentation/Changelog/master/Breaking-61823-RemoveMagicSettterForFromTC.rst b/typo3/sysext/core/Documentation/Changelog/master/Breaking-61823-RemoveMagicSettterForFromTC.rst
new file mode 100644 (file)
index 0000000..e8e5bd8
--- /dev/null
@@ -0,0 +1,27 @@
+==================================================
+Breaking: #61823 - Remove magic setter for $fromTC
+==================================================
+
+Description
+===========
+
+The magic setter for $fromTC in \TYPO3\CMS\Core\Database\RelationHandler is removed.
+
+
+Impact
+======
+
+Directly setting the now protected property $fromTC will trigger a PHP warning.
+
+
+Affected installations
+======================
+
+Any installation using an extension that sets $fromTC property directly.
+
+
+Migration
+=========
+
+Use \TYPO3\CMS\Core\Database\RelationHandler::setFetchAllFields() instead.
+