[BUGFIX] Do not show wizards marked as done in install tool 70/58270/3
authorSusanne Moog <susanne.moog@typo3.org>
Thu, 13 Sep 2018 16:56:29 +0000 (18:56 +0200)
committerAnja Leichsenring <aleichsenring@ab-softlab.de>
Thu, 13 Sep 2018 20:32:13 +0000 (22:32 +0200)
Wizards marked as done are no longer displayed as executable
in the install tool, the missing state check has been included.

Resolves: #86246
Releases: master
Change-Id: Ic86910379f3bc2994f87a8408e81e32d5f28729a
Reviewed-on: https://review.typo3.org/58270
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
typo3/sysext/install/Classes/Service/UpgradeWizardsService.php

index 53b1a19..250ad53 100644 (file)
@@ -277,6 +277,9 @@ class UpgradeWizardsService
     {
         $wizards = [];
         foreach ($GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['ext/install']['update'] as $identifier => $class) {
+            if ($this->isWizardDone($identifier)) {
+                continue;
+            }
             /** @var AbstractUpdate $wizardInstance */
             $wizardInstance = GeneralUtility::makeInstance($class);
 
@@ -301,11 +304,6 @@ class UpgradeWizardsService
                 'identifier' => $identifier,
                 'title' => $wizardInstance->getTitle(),
                 'shouldRenderWizard' => $shouldRenderWizard,
-                'markedDoneInRegistry' => GeneralUtility::makeInstance(Registry::class)->get(
-                    'installUpdate',
-                    $class,
-                    false
-                ),
                 'explanation' => $explanation,
             ];
         }