[TASK] Raise typo3/testing-framework to 4.4.0

composer require --dev typo3/testing-framework:~4.4.0

With the removal of all '$suppressNotices = true' settings from
existing unit tests, this flag has now been removed from the
testing-framework. Core unit tests from now on must never trigger
notices, or fix the subject code along with new tests.

Resolves: #84280
Releases: master
Change-Id: Iffe6f6fa056a0203d2cb5474c25c36d2ef651578
Reviewed-on: https://review.typo3.org/57927
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>

diff --git a/composer.json b/composer.json
index fea281a..ee56723 100644 (file)
--- a/composer.json
+++ b/composer.json
@@ -68,7 +68,7 @@
                "fiunchinho/phpunit-randomizer": "^4.0",
                "friendsofphp/php-cs-fixer": "^2.12.2",
                "typo3/cms-styleguide": "~9.2.0",
-               "typo3/testing-framework": "~4.3.3"
+               "typo3/testing-framework": "~4.4.0"
        },
        "suggest": {
                "ext-gd": "GDlib/Freetype is required for building images with text (GIFBUILDER) and can also be used to scale images",

diff --git a/composer.lock b/composer.lock
index 8dc5d4f..27d27a5 100644 (file)
--- a/composer.lock
+++ b/composer.lock
@@ -4,7 +4,7 @@
         "Read more about it at https://getcomposer.org/doc/01-basic-usage.md#installing-dependencies",
         "This file is @generated automatically"
     ],
-    "content-hash": "2d4286e7d7266515cb472a37beeeffe7",
+    "content-hash": "90a79f71bd2e0de6652bd2bcd7492614",
     "packages": [
         {
             "name": "cogpowered/finediff",
@@ -4752,16 +4752,16 @@
         },
         {
             "name": "typo3/testing-framework",
-            "version": "4.3.3",
+            "version": "4.4.0",
             "source": {
                 "type": "git",
                 "url": "https://github.com/TYPO3/testing-framework.git",
-                "reference": "745260ecd80446e3e1b88cb581eb62d45f39be6c"
+                "reference": "45b4b0bc28382e03f5c7738d5417ee1ee848034f"
             },
             "dist": {
                 "type": "zip",
-                "url": "https://api.github.com/repos/TYPO3/testing-framework/zipball/745260ecd80446e3e1b88cb581eb62d45f39be6c",
-                "reference": "745260ecd80446e3e1b88cb581eb62d45f39be6c",
+                "url": "https://api.github.com/repos/TYPO3/testing-framework/zipball/45b4b0bc28382e03f5c7738d5417ee1ee848034f",
+                "reference": "45b4b0bc28382e03f5c7738d5417ee1ee848034f",
                 "shasum": ""
             },
             "require": {
@@ -4776,7 +4776,6 @@
             },
             "suggest": {
                 "codeception/codeception": "^2.4",
-                "typo3/cms-saltedpasswords": "^9.3",
                 "typo3/cms-styleguide": "^9.0"
             },
             "type": "library",
@@ -4808,7 +4807,7 @@
                 "tests",
                 "typo3"
             ],
-            "time": "2018-08-12T16:38:27+00:00"
+            "time": "2018-08-16T11:07:05+00:00"
         },
         {
             "name": "webmozart/assert",

diff --git a/typo3/sysext/core/Documentation/Changelog/master/Important-84280-UnitTestSuppressNoticesRemoved.rst b/typo3/sysext/core/Documentation/Changelog/master/Important-84280-UnitTestSuppressNoticesRemoved.rst
new file mode 100644 (file)
index 0000000..1ac8935
--- /dev/null
+++ b/typo3/sysext/core/Documentation/Changelog/master/Important-84280-UnitTestSuppressNoticesRemoved.rst
@@ -0,0 +1,22 @@
+.. include:: ../../Includes.txt
+
+=====================================================
+Important: #84280 - Unit test suppressNotices removed
+=====================================================
+
+See :issue:`84280`
+
+Description
+===========
+
+The property :php:`$suppressNotices` available for unit tests extending class
+:php:`UnitTestCase` has been removed. Unit tests that trigger :php:`E_NOTICE`
+level errors will now fail.
+
+The property has been introduced with core v9.2 and has been removed with v9.4
+after no core unit tests used that flag anymore.
+
+If extensions use the typo3/testing-framework for testing, they now may have
+to fix their tests or system under test to not throw notices, either.
+
+.. index:: PHP-API, FullyScanned
\ No newline at end of file

diff --git a/typo3/sysext/core/composer.json b/typo3/sysext/core/composer.json
index c05e16d..a8f0b73 100644 (file)
--- a/typo3/sysext/core/composer.json
+++ b/typo3/sysext/core/composer.json
@@ -50,7 +50,7 @@
                "fiunchinho/phpunit-randomizer": "^4.0",
                "friendsofphp/php-cs-fixer": "^2.12.2",
                "typo3/cms-styleguide": "~9.2.0",
-               "typo3/testing-framework": "~4.3.3"
+               "typo3/testing-framework": "~4.4.0"
        },
        "suggest": {
                "ext-fileinfo": "Used for proper file type detection in the file abstraction layer",

diff --git a/typo3/sysext/install/Configuration/ExtensionScanner/Php/PropertyExistsStaticMatcher.php b/typo3/sysext/install/Configuration/ExtensionScanner/Php/PropertyExistsStaticMatcher.php
index 74a5cd5..c6ae6ca 100644 (file)
--- a/typo3/sysext/install/Configuration/ExtensionScanner/Php/PropertyExistsStaticMatcher.php
+++ b/typo3/sysext/install/Configuration/ExtensionScanner/Php/PropertyExistsStaticMatcher.php
@@ -4,6 +4,7 @@ return [
     'suppressNotices' => [
         'restFiles' => [
             'Breaking-83889-E_NOTICEFreeUnitTesting.rst',
+            'Important-84280-UnitTestSuppressNoticesRemoved.rst',
         ],
     ],
 ];