[TASK] Link the item column in linkvalidator report 53/43353/3
authorGeorg Ringer <georg.ringer@gmail.com>
Sat, 14 Nov 2015 21:12:08 +0000 (22:12 +0100)
committerMorton Jonuschat <m.jonuschat@mojocode.de>
Mon, 16 Nov 2015 07:03:04 +0000 (08:03 +0100)
To be in sync with the rest of the core, the element information of the
linkvalidator result is moved to the first col and linked as well as the icon
at the end.

Releases: master
Resolves: #12018
Change-Id: I9bdb0c5e77427b9a1eca2a6466275b5bd0c1da6b
Reviewed-on: https://review.typo3.org/43353
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Loek Hilgersom <loek@netcoop.nl>
Tested-by: Loek Hilgersom <loek@netcoop.nl>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
typo3/sysext/linkvalidator/Classes/Report/LinkValidatorReport.php
typo3/sysext/linkvalidator/Resources/Private/Templates/mod_template.html

index 2ee4e6e..8fad862 100644 (file)
@@ -499,10 +499,9 @@ class LinkValidatorReport extends \TYPO3\CMS\Backend\Module\AbstractFunctionModu
             ],
             'returnUrl' => $requestUri
         ]);
-        $actionLink = '<a href="' . htmlspecialchars($url);
-        $actionLink .= '" title="' . $this->getLanguageService()->getLL('list.edit') . '">';
-        $actionLink .= $this->iconFactory->getIcon('actions-document-open', Icon::SIZE_SMALL)->render();
-        $actionLink .= '</a>';
+        $actionLinkOpen = '<a href="' . htmlspecialchars($url);
+        $actionLinkOpen .= '" title="' . $this->getLanguageService()->getLL('list.edit') . '">';
+        $actionLinkClose = '</a>';
         $elementHeadline = $row['headline'];
         if (empty($elementHeadline)) {
             $elementHeadline = '<i>' . $this->getLanguageService()->getLL('list.no.headline') . '</i>';
@@ -521,7 +520,9 @@ class LinkValidatorReport extends \TYPO3\CMS\Backend\Module\AbstractFunctionModu
         $element = '<span title="' . htmlspecialchars($table . ':' . $row['record_uid']) . '">' . $this->iconFactory->getIconForRecord($table, $row, Icon::SIZE_SMALL)->render() . '</span>';
         $element .= $elementHeadline;
         $element .= ' ' . sprintf($this->getLanguageService()->getLL('list.field'), $fieldName);
-        $markerArray['actionlink'] = $actionLink;
+        $markerArray['actionlinkOpen'] = $actionLinkOpen;
+        $markerArray['actionlinkClose'] = $actionLinkClose;
+        $markerArray['actionlinkIcon'] = $this->iconFactory->getIcon('actions-document-open', Icon::SIZE_SMALL)->render();
         $markerArray['path'] = BackendUtility::getRecordPath($row['record_pid'], '', 0, 0);
         $markerArray['element'] = $element;
         $markerArray['headlink'] = $row['link_title'];
index b4a9d5c..460230b 100644 (file)
@@ -34,8 +34,8 @@
 <table class="table table-striped table-hover" id="linkvalidator-broken-links-table">
        <thead>
                <tr>
-                       <th>###TABLEHEAD_PATH###</th>
                        <th>###TABLEHEAD_ELEMENT###</th>
+                       <th>###TABLEHEAD_PATH###</th>
                        <th>###TABLEHEAD_HEADLINK###</th>
                        <th>###TABLEHEAD_LINKTARGET###</th>
                        <th>###TABLEHEAD_LINKMESSAGE###</th>
        <tbody>
                <!-- ###BROKENLINKS_ITEM### begin -->
                <tr>
+                       <td>###ACTIONLINKOPEN######ELEMENT######ACTIONLINKCLOSE###</td>
                        <td>###PATH###</td>
-                       <td>###ELEMENT###</td>
                        <td>###HEADLINK###</td>
                        <td><a href="###LINKTARGET###" target="_blank">###LINKTARGET###</a></td>
                        <td>###LINKMESSAGE###</td>
                        <td>###LASTCHECK###</td>
-                       <td>###ACTIONLINK###</td>
+                       <td>###ACTIONLINKOPEN######ACTIONLINKICON######ACTIONLINKCLOSE###</td>
                </tr>
                <!-- ###BROKENLINKS_ITEM### end -->
        </tbody>