[TASK] Make AreaTest notice free 08/56308/2
authorŁukasz Uznański <l.uznanski@macopedia.pl>
Sat, 17 Mar 2018 14:09:27 +0000 (15:09 +0100)
committerChristian Kuhn <lolli@schwarzbu.ch>
Sat, 17 Mar 2018 14:37:36 +0000 (15:37 +0100)
Resolves: 84436
Releases: master
Change-Id: Ie882198724aaa3d77f695e036599dee3a1211938
Reviewed-on: https://review.typo3.org/56308
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
typo3/sysext/core/Tests/Unit/Imaging/ImageManipulation/AreaTest.php

index d9fb5d2..ff0a56d 100644 (file)
@@ -24,14 +24,9 @@ use TYPO3\TestingFramework\Core\Unit\UnitTestCase;
 class AreaTest extends UnitTestCase
 {
     /**
-     * Subject is not notice free, disable E_NOTICES
-     */
-    protected static $suppressNotices = true;
-
-    /**
      * @test
      */
-    public function makeRelativeToFileReducesSizes()
+    public function makeRelativeToFileReducesSizes(): void
     {
         $imageArea = new Area(50.0, 50.0, 100.0, 100.0);
         $imageFixture = new File(
@@ -49,7 +44,7 @@ class AreaTest extends UnitTestCase
         $this->assertSame($expectedResult, $relativeArea->asArray());
     }
 
-    public function applyRatioRestrictsAreaToRespectRatioDataProvider()
+    public function applyRatioRestrictsAreaToRespectRatioDataProvider(): array
     {
         return [
             [
@@ -77,7 +72,7 @@ class AreaTest extends UnitTestCase
      * @test
      * @dataProvider applyRatioRestrictsAreaToRespectRatioDataProvider
      */
-    public function applyRatioRestrictsAreaToRespectRatio(array $areaSize, $ratio)
+    public function applyRatioRestrictsAreaToRespectRatio(array $areaSize, $ratio): void
     {
         $area = new Area(...$areaSize);
         $ratioFixture = new Ratio('dummy', 'dummy', $ratio);
@@ -88,7 +83,7 @@ class AreaTest extends UnitTestCase
     /**
      * @test
      */
-    public function applyRatioDoesNothingForFreeRatio()
+    public function applyRatioDoesNothingForFreeRatio(): void
     {
         $area = new Area(0.1, 0.1, 0.2, 0.4);
         $ratioFixture = new Ratio('dummy', 'dummy', 0.0);