[!!!][TASK] Drop evaluation of @ignorevalidation annotations 86/58886/6
authorAlexander Schnitzler <git@alexanderschnitzler.de>
Sat, 10 Nov 2018 15:25:15 +0000 (16:25 +0100)
committerAnja Leichsenring <aleichsenring@ab-softlab.de>
Thu, 20 Dec 2018 16:06:46 +0000 (17:06 +0100)
@ignorevalidation will no longer ignore the triggering of validations

Releases: master
Resolves: #86901
Change-Id: Ifd98389fe948c7420852e7442fe4f5a8a703f1c7
Reviewed-on: https://review.typo3.org/58886
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
typo3/sysext/core/Documentation/Changelog/master/Breaking-87193-DeprecatedFunctionalityRemoved.rst
typo3/sysext/extbase/Classes/Reflection/ClassSchema.php
typo3/sysext/extbase/Tests/UnitDeprecated/Reflection/ClassSchemaTest.php
typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodAnnotationMatcher.php

index 663fa29..3eda3a5 100644 (file)
@@ -385,16 +385,6 @@ class ClassSchema
                         E_USER_DEPRECATED
                     );
                 }
-                if ($tag === 'ignorevalidation') {
-                    trigger_error(
-                        sprintf(
-                            'Method %s::%s is tagged with @ignorevalidation which is deprecated and will be removed in TYPO3 v10.0.',
-                            $reflectionClass->getName(),
-                            $reflectionMethod->getName()
-                        ),
-                        E_USER_DEPRECATED
-                    );
-                }
                 if ($tag === 'flushesCaches') {
                     trigger_error(
                         sprintf(
index 49a5af8..71eaca7 100644 (file)
@@ -37,12 +37,6 @@ class ClassSchemaTest extends UnitTestCase
         static::assertTrue($classSchema->getProperty('propertyWithLazyAnnotation')['annotations']['lazy']);
     }
 
-    public function testClassSchemaDetectsIgnoreValidationAnnotation()
-    {
-        $classSchema = new ClassSchema(Fixture\DummyControllerWithIgnorevalidationAnnotation::class);
-        static::assertTrue(isset($classSchema->getMethod('someAction')['tags']['ignorevalidation']));
-    }
-
     /**
      * @test
      */
index 1b994c0..5c0801f 100644 (file)
@@ -4,6 +4,7 @@ return [
         'restFiles' => [
             'Feature-83094-ReplaceIgnorevalidationWithTYPO3CMSExtbaseAnnotationIgnoreValidation.rst',
             'Deprecation-83094-ReplaceIgnorevalidationWithTYPO3CMSExtbaseAnnotationIgnoreValidation.rst',
+            'Breaking-87193-DeprecatedFunctionalityRemoved.rst',
         ],
     ],
     '@cli' => [