[BUGFIX] ContentObjectRendereTest: Undefined constant NL 08/54908/2
authorChristian Kuhn <lolli@schwarzbu.ch>
Sat, 2 Dec 2017 23:40:52 +0000 (00:40 +0100)
committerChristian Kuhn <lolli@schwarzbu.ch>
Sun, 3 Dec 2017 11:22:14 +0000 (12:22 +0100)
A data provider uses the not defined constant "NL". PHP 7.2
throws warnings on this. Warnings from data providers do not
lead to failing tests, still this is ugly and pollutes test
runs with warnings in the head part.

Change-Id: I3b09ce51d675cf3097967c074511eaf0a53cf8f9
Resolves: #83194
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54908
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php

index 32288c8..eac11e9 100644 (file)
@@ -3450,29 +3450,28 @@ class ContentObjectRendererTest extends \TYPO3\TestingFramework\Core\Unit\UnitTe
                 ['', 'TEXT']
             ],
             'multiple nested tags with classes' => [
-                NL . '<div class="typo3">' .
-                NL . '<p>A <b>BOLD<\b> WORD.</p>' .
-                NL . '<p>AN <i>ITALIC<\i> WORD.</p>' .
-                NL . '</div>',
-                NL . '<div class="typo3">' .
-                NL . '<p>A <b>bold<\b> word.</p>' .
-                NL . '<p>An <i>italic<\i> word.</p>' .
-                NL . '</div>',
+                '<div class="typo3">'
+                . '<p>A <b>BOLD<\b> WORD.</p>'
+                . '<p>AN <i>ITALIC<\i> WORD.</p>'
+                . '</div>',
+                '<div class="typo3">'
+                . '<p>A <b>bold<\b> word.</p>'
+                . '<p>An <i>italic<\i> word.</p>'
+                . '</div>',
                 $case,
                 [
-                    [NL, $case],
-                    [NL, $case],
+                    ['', $case],
+                    ['', $case],
                     ['A ', $case],
                     ['bold', $case],
                     [' word.', $case],
-                    [NL, $case],
+                    ['', $case],
                     ['An ', $case],
                     ['italic', $case],
                     [' word.', $case],
-                    [NL, $case],
+                    ['', $case],
                 ],
-                [NL, NL, 'A ', 'BOLD', ' WORD.',
-                NL, 'AN ', 'ITALIC', ' WORD.', NL]
+                [ '', '', 'A ', 'BOLD', ' WORD.', '', 'AN ', 'ITALIC', ' WORD.', '']
             ],
         ];
     }