[BUGFIX] Sprite manager cache race condition
authorChristian Kuhn <lolli@schwarzbu.ch>
Sat, 11 Aug 2012 13:45:38 +0000 (15:45 +0200)
committerChristian Kuhn <lolli@schwarzbu.ch>
Sat, 11 Aug 2012 13:50:39 +0000 (15:50 +0200)
If the sprite manager is initialized in the frontend with empty caches,
the cache content will not be rendered correctly due to missing
information in frontend scope.
Solution is to not initialize the sprite manager in frontend and cli
context at all, they are not needed anyway. feedit works as before.

Change-Id: I5949f10d2383f4c259e0d86efe85960589ccf1a1
Resolves: #39706
Releases: 6.0
Reviewed-on: http://review.typo3.org/13592
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
typo3/cli_dispatch.phpsh
typo3/sysext/cms/tslib/index_ts.php

index 9c75c45..ffbc138 100755 (executable)
@@ -77,8 +77,6 @@ Typo3_Bootstrap::getInstance()
 Typo3_Bootstrap_Cli::initializeCliKeyOrDie();
 Typo3_Bootstrap::getInstance()
        ->loadExtensionTables(TRUE)
-               // TODO: Check if we really need the sprite manager on the command line
-       ->initializeSpriteManager()
        ->initializeBackendUser()
        ->initializeBackendUserMounts()
        ->initializeLanguageObject();
index 6623598..644e4e8 100644 (file)
@@ -182,8 +182,6 @@ $TT->pull();
 
        // Admin Panel & Frontend editing
 if ($TSFE->isBackendUserLoggedIn()) {
-       Typo3_Bootstrap::getInstance()->initializeSpriteManager();
-
        $BE_USER->initializeFrontendEdit();
        if ($BE_USER->adminPanel instanceof tslib_AdminPanel) {
                Typo3_Bootstrap::getInstance()->initializeLanguageObject();