[!!!][TASK] Remove backend user option debugInWindow 64/50464/4
authorWouter Wolters <typo3@wouterwolters.nl>
Mon, 31 Oct 2016 20:17:41 +0000 (21:17 +0100)
committerChristian Kuhn <lolli@schwarzbu.ch>
Tue, 1 Nov 2016 10:27:23 +0000 (11:27 +0100)
The option is unused in the core and no usages are found in TER.

Resolves: #78522
Releases: master
Change-Id: Id3cb7fe790b9cf84d2e85595d784edb482f9a32d
Reviewed-on: https://review.typo3.org/50464
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
typo3/sysext/backend/Classes/Controller/BackendController.php
typo3/sysext/core/Documentation/Changelog/master/Breaking-78522-RemoveBackendUserOptionDebugInWindow.rst [new file with mode: 0644]
typo3/sysext/setup/Resources/Private/Language/locallang.xlf
typo3/sysext/setup/ext_tables.php
typo3/sysext/workspaces/Classes/Controller/PreviewController.php

index 070cd4a..e1019d2 100644 (file)
@@ -582,7 +582,6 @@ class BackendController
             'pageModule' => $pageModule,
             'inWorkspace' => $beUser->workspace !== 0,
             'showRefreshLoginPopup' => isset($GLOBALS['TYPO3_CONF_VARS']['BE']['showRefreshLoginPopup']) ? (int)$GLOBALS['TYPO3_CONF_VARS']['BE']['showRefreshLoginPopup'] : false,
-            'debugInWindow' => $beUser->uc['debugInWindow'] ? 1 : 0,
             'ContextHelpWindows' => [
                 'width' => 600,
                 'height' => 400
diff --git a/typo3/sysext/core/Documentation/Changelog/master/Breaking-78522-RemoveBackendUserOptionDebugInWindow.rst b/typo3/sysext/core/Documentation/Changelog/master/Breaking-78522-RemoveBackendUserOptionDebugInWindow.rst
new file mode 100644 (file)
index 0000000..85e583c
--- /dev/null
@@ -0,0 +1,26 @@
+.. include:: ../../Includes.txt
+
+============================================================
+Breaking: #78522 - Removed backend user option debugInWindow
+============================================================
+
+See :issue:`78522`
+
+Description
+===========
+
+The backend user option `debugInWindow` is unused in the core and has been removed,
+as the option of opening the debug information in a window was migrated already.
+
+Impact
+======
+
+The setting is not available anymore in JavaScript under :js:`TYPO3.configuration`.
+
+
+Affected Installations
+======================
+
+Any installation that uses the removed backend user option `debugInWindow`.
+
+.. index:: Backend, JavaScript
index c81a616..248fbfe 100644 (file)
                        <trans-unit id="oldPassword_failed">
                                <source>Password was NOT updated because you didn't enter the correct current password.</source>
                        </trans-unit>
-                       <trans-unit id="adminFunctions">
-                               <source>Admin functions</source>
-                       </trans-unit>
                        <trans-unit id="enableInstallTool.label">
                                <source>Install Tool Access</source>
                        </trans-unit>
                        <trans-unit id="settingsAreReset">
                                <source>The user settings have been reset to default values and temporary data has been cleared.</source>
                        </trans-unit>
-                       <trans-unit id="debugInWindow">
-                               <source>Display debug messages in a new browser window</source>
-                       </trans-unit>
                        <trans-unit id="startModule.firstInMenu">
                                <source>- First module in menu -</source>
                        </trans-unit>
index 98664d7..00a17e3 100644 (file)
@@ -131,16 +131,10 @@ if (TYPO3_MODE === 'BE') {
                 'label' => 'LLL:EXT:setup/Resources/Private/Language/locallang.xlf:flexibleTextareas_MaxHeight',
                 'csh' => 'flexibleTextareas_MaxHeight'
             ],
-            'debugInWindow' => [
-                'type' => 'check',
-                'label' => 'LLL:EXT:setup/Resources/Private/Language/locallang.xlf:debugInWindow',
-                'access' => 'admin'
-            ]
         ],
         'showitem' => '--div--;LLL:EXT:setup/Resources/Private/Language/locallang.xlf:personal_data,realName,email,emailMeAtLogin,avatar,lang,
                                --div--;LLL:EXT:setup/Resources/Private/Language/locallang.xml:passwordHeader,passwordCurrent,password,password2,
                                --div--;LLL:EXT:setup/Resources/Private/Language/locallang.xlf:opening,startModule,
-                               --div--;LLL:EXT:setup/Resources/Private/Language/locallang.xlf:editFunctionsTab,edit_RTE,resizeTextareas_Flexible,resizeTextareas_MaxHeight,titleLen,thumbnailsByDefault,edit_docModuleUpload,showHiddenFilesAndFolders,copyLevels,recursiveDelete,resetConfiguration,
-                               --div--;LLL:EXT:setup/Resources/Private/Language/locallang.xlf:adminFunctions,debugInWindow'
+                               --div--;LLL:EXT:setup/Resources/Private/Language/locallang.xlf:editFunctionsTab,edit_RTE,resizeTextareas_Flexible,resizeTextareas_MaxHeight,titleLen,thumbnailsByDefault,edit_docModuleUpload,showHiddenFilesAndFolders,copyLevels,recursiveDelete,resetConfiguration'
     ];
 }
index 2b36111..41345ab 100644 (file)
@@ -226,7 +226,6 @@ class PreviewController extends AbstractController
             'pageModule' => $pageModule,
             'inWorkspace' => $backendUser->workspace !== 0,
             'showRefreshLoginPopup' => isset($GLOBALS['TYPO3_CONF_VARS']['BE']['showRefreshLoginPopup']) ? (int)$GLOBALS['TYPO3_CONF_VARS']['BE']['showRefreshLoginPopup'] : false,
-            'debugInWindow' => $backendUser->uc['debugInWindow'] ? 1 : 0,
             'ContextHelpWindows' => [
                 'width' => 600,
                 'height' => 400