[BUGFIX] Prevent installing incompatible extensions without confirmation 63/51863/2
authorNicole Cordes <typo3@cordes.co>
Fri, 24 Feb 2017 15:32:09 +0000 (16:32 +0100)
committerAndreas Fernandez <typo3@scripting-base.de>
Sun, 26 Feb 2017 18:20:52 +0000 (19:20 +0100)
Currently it is possible to install incompatible extensions without
confirming the overlay popup. This patch prevents submitting the
overlay if the button is still disabled.

Resolves: #80005
Releases: master, 7.6
Change-Id: Ia68539cb9ce2a82f1e90aef3823f60cfadee2ce1
Reviewed-on: https://review.typo3.org/51863
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
typo3/sysext/extensionmanager/Resources/Public/JavaScript/Main.js

index 7645dfb..87404d7 100644 (file)
@@ -510,8 +510,10 @@ define([
                                                        text: TYPO3.lang['button.resolveDependenciesIgnore'],
                                                        btnClass: 'btn-danger disabled t3js-dependencies',
                                                        trigger: function() {
-                                                               Repository.getResolveDependenciesAndInstallResult(data.skipDependencyUri);
-                                                               Modal.dismiss();
+                                                               if (!$(this).hasClass('disabled')) {
+                                                                       Repository.getResolveDependenciesAndInstallResult(data.skipDependencyUri);
+                                                                       Modal.dismiss();
+                                                               }
                                                        }
                                                }
                                        ]);