[TASK] Use $pathsToProvideInTestInstance in functional import tests 62/54862/3
authorOliver Hader <oliver@typo3.org>
Wed, 29 Nov 2017 12:58:11 +0000 (13:58 +0100)
committerSusanne Moog <susanne.moog@typo3.org>
Wed, 29 Nov 2017 15:58:45 +0000 (16:58 +0100)
$pathsToProvideInTestInstance offers the possibility to use real
duplicates instead of linked resources in the filesystem - especially
in scenarios when files shall be modified inside a testing instance this
is the better approach and avoid side-effects during test execution.

Resolves: #83163
Releases: master, 8.7
Change-Id: I5e5825d2f999401533afffdf9c6e8d83ac55c94e
Reviewed-on: https://review.typo3.org/54862
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
composer.json
composer.lock
typo3/sysext/impexp/Tests/Functional/Import/PagesAndTtContentWithImagesInFilledDatabaseTest.php

index ff0c382..99c2dcd 100644 (file)
@@ -52,7 +52,7 @@
                "nikic/php-parser": "^3.1"
        },
        "require-dev": {
-               "typo3/testing-framework": "~1.1.0",
+               "typo3/testing-framework": "~1.2.0",
                "codeception/codeception": "^2.3",
                "enm1989/chromedriver": "~2.30",
                "typo3/cms-styleguide": "~9.0.0",
index f19f51a..aef8a5c 100644 (file)
@@ -4,7 +4,7 @@
         "Read more about it at https://getcomposer.org/doc/01-basic-usage.md#composer-lock-the-lock-file",
         "This file is @generated automatically"
     ],
-    "content-hash": "96561ed50946b9022ef86e512c2906fd",
+    "content-hash": "129c439b6dbbbca7b873330cadb2e6d2",
     "packages": [
         {
             "name": "cogpowered/finediff",
         },
         {
             "name": "typo3/testing-framework",
-            "version": "1.1.5",
+            "version": "1.2.0",
             "source": {
                 "type": "git",
                 "url": "https://github.com/TYPO3/testing-framework.git",
-                "reference": "601a5f74fbea26f2d09ab66d105b9df701fd5d4a"
+                "reference": "42c16d829373a1d2cbaa9a46bb77a0290d3dec32"
             },
             "dist": {
                 "type": "zip",
-                "url": "https://api.github.com/repos/TYPO3/testing-framework/zipball/601a5f74fbea26f2d09ab66d105b9df701fd5d4a",
-                "reference": "601a5f74fbea26f2d09ab66d105b9df701fd5d4a",
+                "url": "https://api.github.com/repos/TYPO3/testing-framework/zipball/42c16d829373a1d2cbaa9a46bb77a0290d3dec32",
+                "reference": "42c16d829373a1d2cbaa9a46bb77a0290d3dec32",
                 "shasum": ""
             },
             "require": {
                 "tests",
                 "typo3"
             ],
-            "time": "2017-10-04T13:26:43+00:00"
+            "time": "2017-11-29T12:40:03+00:00"
         },
         {
             "name": "webmozart/assert",
index c3fb84e..64552d0 100644 (file)
@@ -32,10 +32,8 @@ class PagesAndTtContentWithImagesInFilledDatabaseTest extends AbstractImportExpo
 
     /**
      * @var array
-     * @todo Substitute with $pathsToProvideInTestInstance once it's available
-     * @todo https://github.com/TYPO3/testing-framework/pull/43
      */
-    protected $pathsToLinkInTestInstance = [
+    protected $pathsToProvideInTestInstance = [
         'typo3/sysext/impexp/Tests/Functional/Fixtures/Folders/fileadmin/user_upload/typo3_image2.jpg' => 'fileadmin/user_upload/typo3_image2.jpg',
     ];