Fixed Bug #11476: Redundant render of helpTextIcon in tceforms
authorSteffen Kamper <info@sk-typo3.de>
Tue, 18 Aug 2009 12:14:33 +0000 (12:14 +0000)
committerSteffen Kamper <info@sk-typo3.de>
Tue, 18 Aug 2009 12:14:33 +0000 (12:14 +0000)
git-svn-id: https://svn.typo3.org/TYPO3v4/Core/trunk@5797 709f56b5-9817-0410-a4d7-c38de5d9e867

ChangeLog
t3lib/class.t3lib_tceforms.php

index 1f1e18e..551f64e 100755 (executable)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,7 @@
+2009-08-18  Steffen Kamper  <info@sk-typo3.de>
+
+       * Fixed Bug #11476: Redundant render of helpTextIcon in tceforms
+
 2009-08-18  Francois Suter  <francois@typo3.org>
 
        * Follow-up to #11373, #11379, #11408: Removed unnecessary use of second parameter in calls to $GLOBALS['LANG']->getLL()
index 8095fae..d0835d3 100644 (file)
@@ -4951,16 +4951,7 @@ class t3lib_TCEforms     {
         */
        function helpTextIcon($table,$field,$force=0)   {
                if ($this->globalShowHelp && $GLOBALS['TCA_DESCR'][$table]['columns'][$field] && (($this->edit_showFieldHelp=='icon'&&!$this->doLoadTableDescr($table)) || $force))     {
-                       $aOnClick = 'vHWin=window.open(\''.$this->backPath.'view_help.php?tfID='.($table.'.'.$field).'\',\'viewFieldHelp\',\'height=400,width=600,status=0,menubar=0,scrollbars=1\');vHWin.focus();return false;';
-
-                       if ($this->edit_showFieldHelp=='icon') {
-                               $text = t3lib_befunc::helpText($table,$field,$BACK_PATH, '');
-                               $text = '<span class="typo3-csh-inline">'.$GLOBALS['LANG']->hscAndCharConv($text, false).'</span>';
-                       }
-
-                       return '<a class="typo3-csh-link" href="#" onclick="'.htmlspecialchars($aOnClick).'">'.
-                                       '<img'.t3lib_iconWorks::skinImg($this->backPath,'gfx/helpbubble.gif','width="14" height="14"').' hspace="2" border="0" class="absmiddle"'.($GLOBALS['CLIENT']['FORMSTYLE']?' style="cursor:help;"':'').' alt="" />'.$text.
-                                       '</a>';
+                       return t3lib_BEfunc::helpTextIcon($table, $field, $this->backPath, $force);
                } else {
                                // Detects fields with no CSH and outputs dummy line to insert into CSH locallang file:
                        return '<span class="nbsp">&nbsp;</span>';