[!!!][TASK] Remove deprecated code from EXT:indexed_search 07/59307/3
authorWouter Wolters <typo3@wouterwolters.nl>
Sun, 30 Dec 2018 14:11:42 +0000 (15:11 +0100)
committerAnja Leichsenring <aleichsenring@ab-softlab.de>
Sun, 30 Dec 2018 15:17:19 +0000 (16:17 +0100)
Resolves: #87308
Releases: master
Change-Id: I02a1d3ef914a9618a91f70a6c3a53d5e3bfe9f79
Reviewed-on: https://review.typo3.org/59307
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
typo3/sysext/core/Documentation/Changelog/master/Breaking-87193-DeprecatedFunctionalityRemoved.rst
typo3/sysext/indexed_search/Classes/Indexer.php
typo3/sysext/indexed_search/Classes/Lexer.php
typo3/sysext/indexed_search/Configuration/TypoScript/setup.typoscript
typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php
typo3/sysext/install/Configuration/ExtensionScanner/Php/PropertyPublicMatcher.php

index 291314b..7152700 100644 (file)
@@ -492,6 +492,8 @@ The following public class properties have been dropped:
 * :php:`TYPO3\CMS\Impexp\Export->maxFileSize`
 * :php:`TYPO3\CMS\Impexp\Export->maxRecordSize`
 * :php:`TYPO3\CMS\Impexp\Export->maxExportSize`
+* :php:`TYPO3\CMS\IndexedSearch\Lexer->csObj`
+* :php:`TYPO3\CMS\IndexedSearch\Indexer->csObj`
 * :php:`TYPO3\CMS\Extbase\Reflection\ClassSchema->addProperty`
 * :php:`TYPO3\CMS\Extbase\Reflection\ClassSchema->setModelType`
 * :php:`TYPO3\CMS\Extbase\Reflection\ClassSchema->getModelType`
index 466eabc..c4b17cd 100644 (file)
@@ -14,7 +14,6 @@ namespace TYPO3\CMS\IndexedSearch;
  * The TYPO3 project - inspiring people to share!
  */
 
-use TYPO3\CMS\Core\Compatibility\PublicPropertyDeprecationTrait;
 use TYPO3\CMS\Core\Configuration\ExtensionConfiguration;
 use TYPO3\CMS\Core\Context\Context;
 use TYPO3\CMS\Core\Context\LanguageAspect;
@@ -34,15 +33,6 @@ use TYPO3\CMS\IndexedSearch\Utility\IndexedSearchUtility;
  */
 class Indexer
 {
-    use PublicPropertyDeprecationTrait;
-
-    /**
-     * List of all deprecated public properties
-     * @var array
-     */
-    protected $deprecatedPublicProperties = [
-        'csObj' => 'Using $csObj within Indexing is discouraged, the property will be removed in TYPO3 v10.0 - if needed instantiate CharsetConverter yourself.',
-    ];
 
     /**
      * @var array
@@ -222,14 +212,6 @@ class Indexer
     public $metaphoneContent = '';
 
     /**
-     * Charset class object
-     *
-     * @var \TYPO3\CMS\Core\Charset\CharsetConverter
-     * @deprecated since TYPO3 v9.3, will be removed in TYPO3 v10.0 (also the instantiation in the init() method).
-     */
-    protected $csObj;
-
-    /**
      * Metaphone object, if any
      *
      * @var \TYPO3\CMS\IndexedSearch\Utility\DoubleMetaPhoneUtility
@@ -511,8 +493,6 @@ class Indexer
             $this->metaphoneObj = GeneralUtility::makeInstance($GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['indexed_search']['metaphone']);
             $this->metaphoneObj->pObj = $this;
         }
-        // Init charset class:
-        $this->csObj = GeneralUtility::makeInstance(\TYPO3\CMS\Core\Charset\CharsetConverter::class);
     }
 
     /**
index 0c802c0..66edadb 100644 (file)
@@ -15,7 +15,6 @@ namespace TYPO3\CMS\IndexedSearch;
  */
 
 use TYPO3\CMS\Core\Charset\CharsetConverter;
-use TYPO3\CMS\Core\Compatibility\PublicPropertyDeprecationTrait;
 use TYPO3\CMS\Core\Utility\GeneralUtility;
 
 /**
@@ -25,15 +24,6 @@ use TYPO3\CMS\Core\Utility\GeneralUtility;
  */
 class Lexer
 {
-    use PublicPropertyDeprecationTrait;
-
-    /**
-     * List of all deprecated public properties
-     * @var array
-     */
-    protected $deprecatedPublicProperties = [
-        'csObj' => 'Using $csObj within Indexing is discouraged, the property will be removed in TYPO3 v10.0 - if needed instantiate CharsetConverter yourself.',
-    ];
 
     /**
      * Debugging options:
@@ -50,14 +40,6 @@ class Lexer
     public $debugString = '';
 
     /**
-     * Charset class object
-     *
-     * @var CharsetConverter
-     * @deprecated since TYPO3 v9.3, will be removed in TYPO3 v10.0 (also the instantiation in the init() method).
-     */
-    public $csObj;
-
-    /**
      * Configuration of the lexer:
      *
      * @var array
@@ -71,15 +53,6 @@ class Lexer
     ];
 
     /**
-     * Constructor: Initializes the charset class
-     */
-    public function __construct()
-    {
-        // @deprecated, can be removed in TYPO3 v10.0.
-        $this->csObj = GeneralUtility::makeInstance(CharsetConverter::class);
-    }
-
-    /**
      * Splitting string into words.
      * Used for indexing, can also be used to find words in query.
      *
index cf9b38b..0da39e9 100644 (file)
@@ -29,9 +29,7 @@ plugin.tx_indexedsearch {
 
                rootPidList = {$plugin.tx_indexedsearch.settings.rootPidList}
                page_links = 10
-               # @deprecated left for BC reasons, will be removed in 10
-               detectDomainRcords = 0
-               detectDomainRecords < .detectDomainRcords
+               detectDomainRecords = 0
                defaultFreeIndexUidList =
                searchSkipExtendToSubpagesChecking = 0
                exactCount = 0
index 9e35faf..9542af5 100644 (file)
@@ -2647,7 +2647,8 @@ return [
         'numberOfMandatoryArguments' => 0,
         'maximumNumberOfArguments' => 0,
         'restFiles' => [
-            'Deprecation-85125-UsagesOfCharsetConverterInCore.rst'
+            'Deprecation-85125-UsagesOfCharsetConverterInCore.rst',
+            'Breaking-87193-DeprecatedFunctionalityRemoved.rst'
         ],
     ],
     'TYPO3\CMS\Backend\Routing\UriBuilder->buildUriFromModule' => [
index 27659b2..d6e8ede 100644 (file)
@@ -409,12 +409,14 @@ return [
     ],
     'TYPO3\CMS\IndexedSearch\Lexer->csObj' => [
         'restFiles' => [
-            'Deprecation-85125-UsagesOfCharsetConverterInCore.rst'
+            'Deprecation-85125-UsagesOfCharsetConverterInCore.rst',
+            'Breaking-87193-DeprecatedFunctionalityRemoved.rst'
         ],
     ],
     'TYPO3\CMS\IndexedSearch\Indexer->csObj' => [
         'restFiles' => [
-            'Deprecation-85125-UsagesOfCharsetConverterInCore.rst'
+            'Deprecation-85125-UsagesOfCharsetConverterInCore.rst',
+            'Breaking-87193-DeprecatedFunctionalityRemoved.rst'
         ],
     ],
     'TYPO3\CMS\Frontend\Controller\TypoScriptFrontendController->showHiddenPage' => [