Fixed bug #12675: Validation issues in sysext reports: Fix several errors
authorChristian Kuhn <lolli@schwarzbu.ch>
Wed, 25 Nov 2009 12:26:00 +0000 (12:26 +0000)
committerChristian Kuhn <lolli@schwarzbu.ch>
Wed, 25 Nov 2009 12:26:00 +0000 (12:26 +0000)
git-svn-id: https://svn.typo3.org/TYPO3v4/Core/trunk@6533 709f56b5-9817-0410-a4d7-c38de5d9e867

ChangeLog
typo3/sysext/reports/mod/index.php
typo3/sysext/reports/reports/class.tx_reports_reports_status.php
typo3/sysext/sv/reports/class.tx_sv_reports_serviceslist.php

index 37c5d05..c6c8147 100755 (executable)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,7 @@
+2009-11-25  Christian Kuhn  <lolli@schwarzbu.ch>
+
+       * Fixed bug #12675: Validation issues in sysext reports: Fix several errors
+
 2009-11-25  Steffen Kamper  <info@sk-typo3.de>
 
        * Fixed bug #12297: t3lib_cs::cropMbstring has problems with negative length (Thanks to Steffen Gebert)
index 65dfbb9..2d7b97b 100644 (file)
@@ -106,31 +106,29 @@ class tx_reports_Module extends t3lib_SCbase {
                                // Draw the form
                        $this->doc->form = '<form action="" method="post" enctype="multipart/form-data">';
                                // JavaScript
-                       $this->doc->JScode = '
-                               <script language="javascript" type="text/javascript">
-                                       script_ended = 0;
-                                       function jumpToUrl(URL) {
-                                               document.location = URL;
-                                       }
-                                       var state;
-                                       Event.observe(document, "dom:loaded", function(){
-                                               $$(".section-header").invoke("observe", "click", function(event){
-                                                       var item = Event.element(event);
-                                                       if (item.hasClassName("expanded")) {
-                                                               item.removeClassName("expanded").addClassName("collapsed");
-                                                               Effect.BlindUp(item.next("div"), {duration : 0.5});
-                                                               state = 1;
-                                                       } else {
-                                                               item.removeClassName("collapsed").addClassName("expanded");
-                                                               Effect.BlindDown(item.next("div"), {duration : 0.5});
-                                                               state = 0;
-                                                       }
-                                                       new Ajax.Request("ajax.php", {
-                                                               parameters : "ajaxID=Reports::saveCollapseState&item=" + item.id + "&state=" + state
-                                                       });
+                       $this->doc->JScodeArray[] = '
+                               script_ended = 0;
+                               function jumpToUrl(URL) {
+                                       document.location = URL;
+                               }
+                               var state;
+                               Event.observe(document, "dom:loaded", function(){
+                                       $$(".section-header").invoke("observe", "click", function(event){
+                                               var item = Event.element(event);
+                                               if (item.hasClassName("expanded")) {
+                                                       item.removeClassName("expanded").addClassName("collapsed");
+                                                       Effect.BlindUp(item.next("div"), {duration : 0.5});
+                                                       state = 1;
+                                               } else {
+                                                       item.removeClassName("collapsed").addClassName("expanded");
+                                                       Effect.BlindDown(item.next("div"), {duration : 0.5});
+                                                       state = 0;
+                                               }
+                                               new Ajax.Request("ajax.php", {
+                                                       parameters : "ajaxID=Reports::saveCollapseState&item=" + item.id + "&state=" + state
                                                });
                                        });
-                               </script>
+                               });
                        ';
                        $this->doc->postCode='
                                <script language="javascript" type="text/javascript">
@@ -219,7 +217,7 @@ class tx_reports_Module extends t3lib_SCbase {
                foreach ($GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['reports'] as $extKey => $extensionReports) {
                        foreach ($extensionReports as $reportName => $report) {
                                $action = $extKey . '.' . $reportName;
-                               $link = 'mod.php?M=tools_txreportsM1&SET[function]=' . $action;
+                               $link = 'mod.php?M=tools_txreportsM1' . htmlspecialchars('&SET[function]=') . $action;
 
                                $reportTitle = $GLOBALS['LANG']->sL($report['title']);
 
@@ -233,7 +231,7 @@ class tx_reports_Module extends t3lib_SCbase {
                                                $icon = $GLOBALS['BACK_PATH'] . '../' . str_replace(PATH_site, '', $absIconPath);
                                        }
                                }
-                               $icon = '<img' . t3lib_iconworks::skinImg($GLOBALS['BACK_PATH'], $icon, 'width="16" height="16"') . ' title="' . $reportTitle . '" />';
+                               $icon = '<img' . t3lib_iconworks::skinImg($GLOBALS['BACK_PATH'], $icon, 'width="16" height="16"') . ' title="' . $reportTitle . '" alt="' . $reportTitle . '" />';
                                $reportContent  = '<dt><a href="' . $link . '">' . $icon . $reportTitle . '</a></dt>';
                                $reportContent .= '<dd>' . $GLOBALS['LANG']->sL($report['description']) . '</dd>';
 
index e44a938..57bd426 100644 (file)
@@ -126,8 +126,8 @@ class tx_reports_reports_Status implements tx_reports_Report {
                                tx_reports_reports_status_Status::ERROR   => 'error',
                        );
 
-                       $icon[tx_reports_reports_status_Status::WARNING] = '<img' . t3lib_iconWorks::skinImg($this->doc->backPath, 'gfx/warning.png', 'width="16" height="16"') . ' />';
-                       $icon[tx_reports_reports_status_Status::ERROR] = '<img' . t3lib_iconWorks::skinImg($this->doc->backPath, 'gfx/error.png', 'width="16" height="16"') . ' />';
+                       $icon[tx_reports_reports_status_Status::WARNING] = '<img' . t3lib_iconWorks::skinImg($this->doc->backPath, 'gfx/warning.png', 'width="16" height="16"') . ' alt="" />';
+                       $icon[tx_reports_reports_status_Status::ERROR] = '<img' . t3lib_iconWorks::skinImg($this->doc->backPath, 'gfx/error.png', 'width="16" height="16"') . ' alt="" />';
                        $messages = '';
                        $headerIcon = '';
                        $sectionSeverity = 0;
index 4273f74..1a66e05 100644 (file)
@@ -88,7 +88,7 @@ class tx_sv_reports_ServicesList implements tx_reports_Report {
                $services = $this->getInstalledServices();
                $content .= '<table cellspacing="1" cellpadding="2" border="0" class="tx_sv_reportlist">';
                foreach ($services as $serviceType => $installedServices) {
-                       $content .= '<tr><td colspans="7">';
+                       $content .= '<tr><td colspan="7">';
                        $content .= '<h4>' . sprintf($GLOBALS['LANG']->getLL('service_type'), $serviceType) . '</h4>';
                        $content .= '</td></tr>';
                        $content .= '<tr class="bgColor2">';