[TASK] Drop child methods that are exactly the same 44/57244/3
authorWouter Wolters <typo3@wouterwolters.nl>
Sun, 17 Jun 2018 14:30:10 +0000 (16:30 +0200)
committerGeorg Ringer <georg.ringer@gmail.com>
Sun, 17 Jun 2018 15:30:56 +0000 (17:30 +0200)
Resolves: #85289
Releases: master
Change-Id: Ia35e8e36f4d9d97924ff105c549b26d851f5df40
Reviewed-on: https://review.typo3.org/57244
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
typo3/sysext/beuser/Classes/Domain/Model/BackendUser.php
typo3/sysext/core/Classes/Resource/Collection/AbstractFileCollection.php
typo3/sysext/core/Tests/Unit/Database/Mocks/MockPlatform.php
typo3/sysext/documentation/Classes/Controller/DocumentController.php
typo3/sysext/extbase/Classes/Command/HelpCommand.php
typo3/sysext/filelist/Classes/ContextMenu/ItemProviders/FileDragProvider.php
typo3/sysext/fluid/Classes/ViewHelpers/Be/Menus/ActionMenuItemGroupViewHelper.php
typo3/sysext/fluid/Classes/ViewHelpers/Be/Menus/ActionMenuViewHelper.php
typo3/sysext/form/Classes/Domain/Model/FormElements/Section.php
typo3/sysext/saltedpasswords/Classes/Salt/BlowfishSalt.php

index 0ba5e6d..3700715 100644 (file)
@@ -80,22 +80,6 @@ class BackendUser extends \TYPO3\CMS\Extbase\Domain\Model\BackendUser
     }
 
     /**
-     * @return string
-     */
-    public function getDescription()
-    {
-        return $this->description;
-    }
-
-    /**
-     * @param string $description
-     */
-    public function setDescription($description)
-    {
-        $this->description = $description;
-    }
-
-    /**
      * @param string $fileMountPoints
      */
     public function setFileMountPoints($fileMountPoints)
index 84206a7..2e2f447 100644 (file)
@@ -71,16 +71,6 @@ abstract class AbstractFileCollection extends \TYPO3\CMS\Core\Collection\Abstrac
     }
 
     /**
-     * Sets the title.
-     *
-     * @param string $title
-     */
-    public function setTitle($title)
-    {
-        $this->title = $title;
-    }
-
-    /**
      * Return the key of the current element
      *
      * @return string
index b4ec2de..df9b57c 100644 (file)
@@ -138,16 +138,6 @@ class MockPlatform extends AbstractPlatform
     }
 
     /**
-     * Gets the default length of a varchar field.
-     *
-     * @return int
-     */
-    public function getVarcharDefaultLength()
-    {
-        return 255;
-    }
-
-    /**
      * Gets the name of the platform.
      *
      * @return string
index aaefe90..2d3999c 100644 (file)
@@ -127,14 +127,6 @@ class DocumentController extends ActionController
     }
 
     /**
-     * @param Dispatcher $signalSlotDispatcher
-     */
-    public function injectSignalSlotDispatcher(Dispatcher $signalSlotDispatcher)
-    {
-        $this->signalSlotDispatcher = $signalSlotDispatcher;
-    }
-
-    /**
      * Lists the available documents.
      */
     public function listAction()
index 60d1513..17e98b5 100644 (file)
@@ -42,16 +42,6 @@ class HelpCommand extends \Symfony\Component\Console\Command\HelpCommand
     }
 
     /**
-     * Sets the command.
-     *
-     * @param Command $command The command to set
-     */
-    public function setCommand(Command $command)
-    {
-        $this->command = $command;
-    }
-
-    /**
      * {@inheritdoc}
      */
     protected function execute(InputInterface $input, OutputInterface $output)
index 2475f53..9819d0e 100644 (file)
@@ -48,16 +48,6 @@ class FileDragProvider extends \TYPO3\CMS\Backend\ContextMenu\ItemProviders\Abst
 
     /**
      * @param string $itemName
-     * @param string $type
-     * @return bool
-     */
-    protected function canRender(string $itemName, string $type): bool
-    {
-        return true;
-    }
-
-    /**
-     * @param string $itemName
      * @return array
      */
     protected function getAdditionalAttributes(string $itemName): array
index 0b50f8f..ef5d876 100644 (file)
@@ -14,7 +14,6 @@ namespace TYPO3\CMS\Fluid\ViewHelpers\Be\Menus;
  * The TYPO3 project - inspiring people to share!
  */
 
-use TYPO3Fluid\Fluid\Core\Compiler\TemplateCompiler;
 use TYPO3Fluid\Fluid\Core\Parser\SyntaxTree\ViewHelperNode;
 
 /**
@@ -71,18 +70,4 @@ class ActionMenuItemGroupViewHelper extends ActionMenuViewHelper
         $this->tag->setContent($options);
         return $this->tag->render();
     }
-
-    /**
-     * @param string $argumentsName
-     * @param string $closureName
-     * @param string $initializationPhpCode
-     * @param ViewHelperNode $node
-     * @param TemplateCompiler $compiler
-     */
-    public function compile($argumentsName, $closureName, &$initializationPhpCode, ViewHelperNode $node, TemplateCompiler $compiler)
-    {
-        // @TODO: replace with a true compiling method to make compilable!
-        $compiler->disable();
-        return null;
-    }
 }
index 8bc1f45..6752388 100644 (file)
@@ -61,17 +61,6 @@ class ActionMenuViewHelper extends AbstractTagBasedViewHelper
     protected $childNodes = [];
 
     /**
-     * Setter for ChildNodes - as defined in ChildNodeAccessInterface
-     *
-     * @param array $childNodes Child nodes of this syntax tree node
-     * @api
-     */
-    public function setChildNodes(array $childNodes)
-    {
-        $this->childNodes = $childNodes;
-    }
-
-    /**
      * Initialize arguments.
      *
      * @api
index fdb2a2a..81cc45a 100644 (file)
@@ -20,7 +20,6 @@ namespace TYPO3\CMS\Form\Domain\Model\FormElements;
 use TYPO3\CMS\Core\Utility\ArrayUtility;
 use TYPO3\CMS\Core\Utility\GeneralUtility;
 use TYPO3\CMS\Extbase\Validation\Validator\NotEmptyValidator;
-use TYPO3\CMS\Extbase\Validation\Validator\ValidatorInterface;
 
 /**
  * A Section, being part of a bigger Page
@@ -128,50 +127,6 @@ class Section extends AbstractSection implements FormElementInterface
     }
 
     /**
-     * Set the rendering option $key to $value.
-     *
-     * @param string $key
-     * @param mixed $value
-     * @return mixed
-     * @api
-     */
-    public function setRenderingOption(string $key, $value)
-    {
-        if (is_array($value) && isset($this->renderingOptions[$key]) && is_array($this->renderingOptions[$key])) {
-            ArrayUtility::mergeRecursiveWithOverrule($this->renderingOptions[$key], $value);
-            $this->renderingOptions[$key] = ArrayUtility::removeNullValuesRecursive($this->renderingOptions[$key]);
-        } elseif ($value === null) {
-            unset($this->renderingOptions[$key]);
-        } else {
-            $this->renderingOptions[$key] = $value;
-        }
-    }
-
-    /**
-     * Get all validators on the element
-     *
-     * @return \SplObjectStorage
-     * @internal
-     */
-    public function getValidators(): \SplObjectStorage
-    {
-        $formDefinition = $this->getRootForm();
-        return $formDefinition->getProcessingRule($this->getIdentifier())->getValidators();
-    }
-
-    /**
-     * Add a validator to the element
-     *
-     * @param ValidatorInterface $validator
-     * @api
-     */
-    public function addValidator(ValidatorInterface $validator)
-    {
-        $formDefinition = $this->getRootForm();
-        $formDefinition->getProcessingRule($this->getIdentifier())->addValidator($validator);
-    }
-
-    /**
      * Whether or not this element is required
      *
      * @return bool
index 299a8c1..b9e5c2b 100644 (file)
@@ -248,21 +248,6 @@ class BlowfishSalt extends Md5Salt
     }
 
     /**
-     * Method determines if a given string is a valid salted hashed password.
-     *
-     * @param string $saltedPW String to check
-     * @return bool TRUE if it's valid salted hashed password, otherwise FALSE
-     */
-    public function isValidSaltedPW(string $saltedPW): bool
-    {
-        $isValid = !strncmp($this->getSetting(), $saltedPW, strlen($this->getSetting()));
-        if ($isValid) {
-            $isValid = $this->isValidSalt($saltedPW);
-        }
-        return $isValid;
-    }
-
-    /**
      * Method sets log2 number of iterations for password stretching.
      *
      * @param int $hashCount log2 number of iterations for password stretching to set