[TASK] Remove non-CGL-compliant switch clause in EXT:setup 31/40731/3
authorBenjamin Mack <benni@typo3.org>
Mon, 29 Jun 2015 20:06:43 +0000 (22:06 +0200)
committerAnja Leichsenring <aleichsenring@ab-softlab.de>
Mon, 29 Jun 2015 20:13:49 +0000 (22:13 +0200)
Resolves: #67821
Releases: master
Change-Id: I70b1434d1350883ab55d39703af3b3ec4d32d7de
Reviewed-on: http://review.typo3.org/40731
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
typo3/sysext/setup/Classes/Controller/SetupModuleController.php

index 32522bc..356f2a7 100644 (file)
@@ -533,7 +533,7 @@ class SetupModuleController {
                        switch ($type) {
                                case 'text':
                                case 'email':
-                               case 'password': {
+                               case 'password':
                                        $noAutocomplete = '';
                                        if ($type === 'password') {
                                                $value = '';
@@ -547,8 +547,7 @@ class SetupModuleController {
                                                $more .
                                                ' />';
                                        break;
-                               }
-                               case 'check': {
+                               case 'check':
                                        $html = $label . '<div class="checkbox"><label><input id="field_' . $fieldName . '"
                                                type="checkbox"
                                                name="data' . $dataAdd . '[' . $fieldName . ']"' .
@@ -557,8 +556,7 @@ class SetupModuleController {
                                                ' /></label></div>';
                                        $label = '';
                                        break;
-                               }
-                               case 'select': {
+                               case 'select':
                                        if ($config['itemsProcFunc']) {
                                                $html = GeneralUtility::callUserFunction($config['itemsProcFunc'], $config, $this, '');
                                        } else {
@@ -571,12 +569,10 @@ class SetupModuleController {
                                                $html .= '</select>';
                                        }
                                        break;
-                               }
-                               case 'user': {
+                               case 'user':
                                        $html = GeneralUtility::callUserFunction($config['userFunc'], $config, $this, '');
                                        break;
-                               }
-                               case 'button': {
+                               case 'button':
                                        if ($config['onClick']) {
                                                $onClick = $config['onClick'];
                                                if ($config['onClickLabels']) {
@@ -590,7 +586,6 @@ class SetupModuleController {
                                                        onclick="' . $onClick . '" />';
                                        }
                                        break;
-                               }
                                default:
                                        $html = '';
                        }