[TASK] Fix CGL errors 40/44740/3
authorClaus Due <claus@namelesscoder.net>
Mon, 16 Nov 2015 20:55:51 +0000 (21:55 +0100)
committerWouter Wolters <typo3@wouterwolters.nl>
Mon, 16 Nov 2015 21:38:37 +0000 (22:38 +0100)
Change-Id: Ibd5f4905f273921a1377a6c2113f69ba4063c4b2
Resolves: #71612
Releases: master
Reviewed-on: https://review.typo3.org/44740
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
65 files changed:
typo3/sysext/backend/Classes/Backend/ToolbarItems/ShortcutToolbarItem.php
typo3/sysext/backend/Classes/Controller/BackendLayoutWizardController.php
typo3/sysext/backend/Classes/Controller/ContentElement/ElementHistoryController.php
typo3/sysext/backend/Classes/Controller/EditDocumentController.php
typo3/sysext/backend/Classes/Controller/File/EditFileController.php
typo3/sysext/backend/Classes/Controller/File/RenameFileController.php
typo3/sysext/backend/Classes/Controller/File/ReplaceFileController.php
typo3/sysext/backend/Classes/Controller/FileSystemNavigationFrameController.php
typo3/sysext/backend/Classes/Controller/FormInlineAjaxController.php
typo3/sysext/backend/Classes/Controller/LinkBrowserController.php
typo3/sysext/backend/Classes/Controller/Page/LocalizationController.php
typo3/sysext/backend/Classes/Controller/PageLayoutController.php
typo3/sysext/backend/Classes/Controller/Wizard/TableController.php
typo3/sysext/backend/Classes/Form/Container/TabsContainer.php
typo3/sysext/backend/Classes/Form/Element/SelectTreeElement.php
typo3/sysext/backend/Classes/Form/FormDataProvider/InlineOverrideChildTca.php
typo3/sysext/backend/Classes/Form/FormDataProvider/TcaColumnsProcessCommon.php
typo3/sysext/backend/Classes/Form/FormDataProvider/TcaFlexProcess.php
typo3/sysext/backend/Classes/Template/Components/MetaInformation.php
typo3/sysext/backend/Classes/View/PageLayoutView.php
typo3/sysext/backend/Classes/View/PageTreeView.php
typo3/sysext/backend/Tests/Unit/Controller/PageLayoutControllerTest.php
typo3/sysext/backend/Tests/Unit/Form/FormDataCompilerTest.php
typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/InlineOverrrideChildTcaTest.php
typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaCheckboxItemsTest.php
typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaColumnsProcessShowitemTest.php
typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaFlexProcessTest.php
typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaInlineIsOnSymmetricSideTest.php
typo3/sysext/beuser/Classes/Controller/BackendUserActionController.php
typo3/sysext/core/Classes/FormProtection/FrontendFormProtection.php
typo3/sysext/core/Classes/Log/Writer/FileWriter.php
typo3/sysext/core/Classes/Migrations/TcaMigration.php
typo3/sysext/core/Classes/Resource/ResourceStorage.php
typo3/sysext/core/Classes/Utility/File/ExtendedFileUtility.php
typo3/sysext/core/Tests/Functional/DataHandling/FAL/Modify/ActionTest.php
typo3/sysext/core/Tests/Unit/FormProtection/BackendFormProtectionTest.php
typo3/sysext/core/Tests/Unit/FormProtection/FormProtectionFactoryTest.php
typo3/sysext/core/Tests/Unit/Log/Writer/FileWriterTest.php
typo3/sysext/core/Tests/Unit/Migrations/TcaMigrationTest.php
typo3/sysext/core/Tests/Unit/Resource/Index/IndexerTest.php
typo3/sysext/core/Tests/Unit/ViewHelpers/IconViewHelperTest.php
typo3/sysext/dbal/Classes/Database/DatabaseConnection.php
typo3/sysext/documentation/Classes/ViewHelpers/FormatsViewHelper.php
typo3/sysext/extensionmanager/Classes/Controller/AbstractModuleController.php
typo3/sysext/extensionmanager/Classes/Utility/InstallUtility.php
typo3/sysext/extensionmanager/Classes/Utility/ListUtility.php
typo3/sysext/filelist/Classes/Controller/FileListController.php
typo3/sysext/frontend/Classes/View/AdminPanelView.php
typo3/sysext/info_pagetsconfig/Classes/Controller/InfoPageTyposcriptConfigController.php
typo3/sysext/install/Classes/Updates/AbstractDownloadExtensionUpdate.php
typo3/sysext/install/Classes/Updates/AccessRightParametersUpdate.php
typo3/sysext/lang/Classes/Controller/LanguageController.php
typo3/sysext/lowlevel/Classes/View/DatabaseIntegrityView.php
typo3/sysext/recordlist/Classes/Controller/AbstractLinkBrowserController.php
typo3/sysext/recordlist/Classes/LinkHandler/AbstractLinkHandler.php
typo3/sysext/recordlist/Classes/LinkHandler/PageLinkHandler.php
typo3/sysext/recordlist/Classes/RecordList/AbstractDatabaseRecordList.php
typo3/sysext/reports/Classes/Controller/ReportController.php
typo3/sysext/rtehtmlarea/Classes/Controller/BrowseLinksController.php
typo3/sysext/scheduler/Classes/Controller/SchedulerModuleController.php
typo3/sysext/taskcenter/Classes/Controller/TaskModuleController.php
typo3/sysext/tstemplate/Classes/Controller/TypoScriptTemplateObjectBrowserModuleFunctionController.php
typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/AbstractActionTestCase.php
typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Modify/ActionTest.php
typo3/sysext/workspaces/Tests/Unit/ExtDirect/ExtDirectServerTest.php

index 295b1ef..840b807 100644 (file)
@@ -578,11 +578,12 @@ class ShortcutToolbarItem implements ToolbarItemInterface
                     $resourceFactory = ResourceFactory::getInstance();
                     $resource = $resourceFactory->getObjectFromCombinedIdentifier($queryParameters['id']);
                     $shortcutName = trim($shortcutNamePrepend . ' ' . $resource->getName());
-                } catch (ResourceDoesNotExistException $e) {}
+                } catch (ResourceDoesNotExistException $e) {
+                }
             } else {
                 // Lookup the title of this page and use it as default description
                 $pageId = (int)($shortcut['pid'] ?: ($shortcut['recordid'] ?: $this->getLinkedPageId($url)));
-                $page = FALSE;
+                $page = false;
                 if ($pageId) {
                     $page = BackendUtility::getRecord('pages', $pageId);
                 }
index f7afb75..0b7a111 100644 (file)
@@ -94,8 +94,8 @@ class BackendLayoutWizardController extends AbstractModule
             'moduleUrl',
             BackendUtility::getModuleUrl(
                 'help_CshmanualCshmanual',
-                array (
-                    'tx_cshmanual_help_cshmanualcshmanual' => array (
+                array(
+                    'tx_cshmanual_help_cshmanualcshmanual' => array(
                         'controller' => 'Help',
                         'action' => 'detail'
                     )
index 1228166..07bce2e 100644 (file)
@@ -1244,7 +1244,7 @@ class EditDocumentController extends AbstractModule
                     );
                 }
                 if (!in_array((int)$this->pageinfo['doktype'], $excludeDokTypes, true)
-                    || isset($pagesTSconfig['TCEMAIN.']['preview.'][$this->firstEl['table'].'.']['previewPageId'])
+                    || isset($pagesTSconfig['TCEMAIN.']['preview.'][$this->firstEl['table'] . '.']['previewPageId'])
                 ) {
                     $saveAndOpenButton = $buttonBar->makeInputButton()
                         ->setTitle($lang->sL('LLL:EXT:lang/locallang_core.xlf:rm.saveDocShow', true))
@@ -1617,7 +1617,6 @@ class EditDocumentController extends AbstractModule
                                 $menuItem->setActive(true);
                             }
                             $languageMenu->addMenuItem($menuItem);
-
                         }
                     }
                     $this->moduleTemplate->getDocHeaderComponent()->getMenuRegistry()->addMenu($languageMenu);
index e2ceb30..67d91d0 100644 (file)
@@ -187,7 +187,6 @@ class EditFileController extends AbstractModule
                                        <input type="hidden" name="redirect" value="' . htmlspecialchars($hValue) . '" />
                                </div>
                                <br />';
-
         } catch (\Exception $e) {
             $code .= sprintf(
                 $this->getLanguageService()->sL('LLL:EXT:lang/locallang_core.xlf:file_edit.php.coundNot'),
@@ -289,7 +288,6 @@ class EditFileController extends AbstractModule
             ->setModuleName('file_edit')
             ->setGetVariables(['target']);
         $buttonBar->addButton($shortButton);
-
     }
 
     /**
index 2733f4b..bcb5d2d 100644 (file)
@@ -26,7 +26,6 @@ use Psr\Http\Message\ServerRequestInterface;
  */
 class RenameFileController extends AbstractModule
 {
-
     /**
      * Name of the filemount
      *
@@ -125,7 +124,6 @@ class RenameFileController extends AbstractModule
             'RenameFileInlineJavaScript',
             'function backToList() {top.goToModule("file_FilelistList");}'
         );
-
     }
 
     /**
index 3b40bed..25fb674 100644 (file)
@@ -31,7 +31,6 @@ use Psr\Http\Message\ServerRequestInterface;
  */
 class ReplaceFileController extends AbstractModule
 {
-
     /**
      * Document template object
      *
index fcee072..0682532 100644 (file)
@@ -31,7 +31,6 @@ use TYPO3\CMS\Recordlist\Tree\View\DummyLinkParameterProvider;
  */
 class FileSystemNavigationFrameController
 {
-
     /**
      * Content accumulates in this variable.
      *
index 9336141..61994d1 100644 (file)
@@ -405,7 +405,6 @@ class FormInlineAjaxController
                     }
                     $jsonArray['scriptCall'][] = 'inline.fadeAndRemove(' . GeneralUtility::quoteJSvalue($nameObjectForeignTable . '-' . $transOrigPointerField . '_div') . ');';
                 }
-
             }
             // Tell JS to add new HTML of one or multiple (localize all) records to DOM
             if (!empty($jsonArray['data'])) {
@@ -768,7 +767,7 @@ class FormInlineAjaxController
 
             if (!isset($parts[2]) || strpos($parts[2], ':') === false) {
                 throw new \UnexpectedValueException(
-                    'DOM Object ID' . $domObjectId. 'does not contain required information '
+                    'DOM Object ID' . $domObjectId . 'does not contain required information '
                     . 'to extract inline field configuration.',
                     1446996136
                 );
index 3ef5c46..f2de493 100644 (file)
@@ -25,8 +25,8 @@ use TYPO3\CMS\Recordlist\Controller\AbstractLinkBrowserController;
 /**
  * Extended controller for link browser
  */
-class LinkBrowserController extends AbstractLinkBrowserController {
-
+class LinkBrowserController extends AbstractLinkBrowserController
+{
     /**
      * Initialize $this->currentLinkParts
      *
@@ -161,5 +161,4 @@ class LinkBrowserController extends AbstractLinkBrowserController {
         }
         return (int)$pageId;
     }
-
 }
index 510517b..a7d2f40 100755 (executable)
@@ -49,7 +49,6 @@ use TYPO3\CMS\Recordlist\RecordList;
  */
 class PageLayoutController
 {
-
     /**
      * Page Id for which to make the listing
      *
@@ -670,7 +669,6 @@ class PageLayoutController
             $this->makeButtons($this->MOD_SETTINGS['function'] == 0 ? 'quickEdit' : '');
             // Create LanguageMenu
             $this->makeLanguageMenu();
-
         } else {
             $this->moduleTemplate->addJavaScriptCode(
                 'mainJsFunctions',
@@ -812,7 +810,7 @@ class PageLayoutController
                 }
                 $redirect = ($uidVal == 'new' ? BackendUtility::getModuleUrl(
                     $this->moduleName,
-                    ['id' => $this->id,'new_unique_uid' => $new_unique_uid,'returnUrl' => $this->returnUrl]
+                    ['id' => $this->id, 'new_unique_uid' => $new_unique_uid, 'returnUrl' => $this->returnUrl]
                 ) : $this->R_URI);
                 $panel .= '
                     <input type="hidden" name="_serialNumber" value="' . md5(microtime()) . '" />
@@ -1220,7 +1218,6 @@ class PageLayoutController
                         ->setIcon($this->iconFactory->getIcon('actions-document-history-open', Icon::SIZE_SMALL));
                     $this->buttonBar->addButton($historyButton, ButtonBar::BUTTON_POSITION_LEFT, 3);
                 }
-
             }
         }
     }
index e31d792..3198ebd 100644 (file)
@@ -165,7 +165,8 @@ class TableController extends AbstractWizardController
                 . '<div>' . $this->tableWizard() . '</div>';
         } else {
             $this->content .= '<h2>' . $this->getLanguageService()->getLL('table_title', true) . '</h2>'
-                . '<div><span class="text-danger">' . $this->getLanguageService()->getLL('table_noData', true) . '</span></div>';;
+                . '<div><span class="text-danger">' . $this->getLanguageService()->getLL('table_noData', true) . '</span></div>';
+            ;
         }
         $this->content .= '</form>';
         // Setting up the buttons and markers for docHeader
index e4061a5..3ac6551 100644 (file)
@@ -104,5 +104,4 @@ class TabsContainer extends AbstractContainer
     {
         return $GLOBALS['LANG'];
     }
-
 }
index ad38472..2f3ff39 100644 (file)
@@ -26,7 +26,6 @@ use TYPO3\CMS\Core\Utility\GeneralUtility;
  */
 class SelectTreeElement extends AbstractFormElement
 {
-
     /**
      * Default height of the tree in pixels.
      *
index 93639ca..4373ab4 100644 (file)
@@ -22,7 +22,6 @@ use TYPO3\CMS\Core\Utility\ArrayUtility;
  */
 class InlineOverrideChildTca implements FormDataProviderInterface
 {
-
     /**
      * Inline parent TCA may override some TCA of children.
      *
index 2572109..76ce411 100644 (file)
@@ -22,7 +22,6 @@ use TYPO3\CMS\Core\Utility\GeneralUtility;
  */
 class TcaColumnsProcessCommon implements FormDataProviderInterface
 {
-
     /**
      * Determine which common fields are in use and add those to the list of
      * columns that must be processed by the next data providers. Common fields
index 2981752..eff12da 100644 (file)
@@ -436,7 +436,6 @@ class TcaFlexProcess implements FormDataProviderInterface
                     } else {
                         $tcaNewColumns[$dataStructureSheetElementName] = $dataStructureSheetElementDefinition;
                     }
-
                 } // End of single element handling
             }
 
index c2c4b94..cfe3e55 100644 (file)
@@ -30,7 +30,6 @@ use TYPO3\CMS\Core\Imaging\IconFactory;
  */
 class MetaInformation
 {
-
     /**
      * The recordArray.
      * Typically this is a page record
index 4a5c8f6..e01c1ab 100644 (file)
@@ -35,7 +35,6 @@ use TYPO3\CMS\Fluid\View\StandaloneView;
  */
 class PageLayoutView extends \TYPO3\CMS\Recordlist\RecordList\AbstractDatabaseRecordList
 {
-
     /**
      * If TRUE, users/groups are shown in the page info box.
      *
@@ -221,14 +220,13 @@ class PageLayoutView extends \TYPO3\CMS\Recordlist\RecordList\AbstractDatabaseRe
         $pageRenderer->addInlineLanguageLabelFile('EXT:backend/Resources/Private/Language/locallang_layout.xlf');
         $pageRenderer->loadRequireJsModule('TYPO3/CMS/Backend/Tooltip');
         $pageRenderer->loadRequireJsModule('TYPO3/CMS/Backend/Localization');
-
     }
 
     /*****************************************
      *
      * Renderings
      *
-        *****************************************/
+     *****************************************/
     /**
      * Adds the code of a single table
      *
@@ -840,7 +838,7 @@ class PageLayoutView extends \TYPO3\CMS\Recordlist\RecordList\AbstractDatabaseRe
      *
      * Generic listing of items
      *
-        **********************************/
+     **********************************/
     /**
      * Creates a standard list of elements from a table.
      *
@@ -1043,7 +1041,7 @@ class PageLayoutView extends \TYPO3\CMS\Recordlist\RecordList\AbstractDatabaseRe
      *
      * Additional functions; Pages
      *
-        **********************************/
+     **********************************/
     /**
      * Adds pages-rows to an array, selecting recursively in the page tree.
      *
@@ -1162,7 +1160,7 @@ class PageLayoutView extends \TYPO3\CMS\Recordlist\RecordList\AbstractDatabaseRe
      *
      * Additional functions; Content Elements
      *
-        **********************************/
+     **********************************/
     /**
      * Draw header for a content element column:
      *
@@ -1375,7 +1373,7 @@ class PageLayoutView extends \TYPO3\CMS\Recordlist\RecordList\AbstractDatabaseRe
         // NOTE: end-tag for <div class="t3-page-ce-body"> is in getTable_tt_content()
         return '<div class="t3-page-ce-header ' . ($allowDragAndDrop ? 't3-page-ce-header-draggable t3js-page-ce-draghandle' : '') . '">
                                        <div class="t3-page-ce-header-icons-left">' . implode('', $additionalIcons) . '</div>
-                                       <div class="t3-page-ce-header-icons-right">' . ($out ? '<div class="btn-toolbar">' .$out . '</div>' : '') . '</div>
+                                       <div class="t3-page-ce-header-icons-right">' . ($out ? '<div class="btn-toolbar">' . $out . '</div>' : '') . '</div>
                                </div>
                                <div class="t3-page-ce-body">';
     }
@@ -1627,7 +1625,7 @@ class PageLayoutView extends \TYPO3\CMS\Recordlist\RecordList\AbstractDatabaseRe
         foreach ($uidList as $uid) {
             $uid = (int)$uid;
             $record = BackendUtility::getRecord($table, $uid, 'title');
-            $content .= '<br>' . $record['title'] . ' (' .$uid. ')';
+            $content .= '<br>' . $record['title'] . ' (' . $uid . ')';
         }
         return $content;
     }
@@ -1801,7 +1799,7 @@ class PageLayoutView extends \TYPO3\CMS\Recordlist\RecordList\AbstractDatabaseRe
             // If any languages are left, make selector:
             if (count($langSelItems) > 1) {
                 $url = BackendUtility::getModuleUrl('record_edit', array(
-                    'edit[pages_language_overlay]['. $id . ']' => 'new',
+                    'edit[pages_language_overlay][' . $id . ']' => 'new',
                     'overrideVals[pages_language_overlay][doktype]' => (int)$this->pageRecord['doktype'],
                     'returnUrl' => GeneralUtility::getIndpEnv('REQUEST_URI')
                 ));
@@ -1846,7 +1844,7 @@ class PageLayoutView extends \TYPO3\CMS\Recordlist\RecordList\AbstractDatabaseRe
      *
      * Various helper functions
      *
-        ********************************/
+     ********************************/
 
     /**
      * Initializes the clipboard for generating paste links
@@ -2050,7 +2048,7 @@ class PageLayoutView extends \TYPO3\CMS\Recordlist\RecordList\AbstractDatabaseRe
      *
      * External renderings
      *
-        *****************************************/
+     *****************************************/
 
     /**
      * Creates a menu of the tables that can be listed by this function
@@ -2092,7 +2090,7 @@ class PageLayoutView extends \TYPO3\CMS\Recordlist\RecordList\AbstractDatabaseRe
                     // ... and to the internal array, activeTables we also add table icon and title (for use elsewhere)
                     $title = $this->getLanguageService()->sL($GLOBALS['TCA'][$tName]['ctrl']['title'], true)
                         . ': ' . $c . ' ' . $this->getLanguageService()->getLL('records', true);
-                    $this->activeTables[$tName] = '<span title="' . $title. '">'
+                    $this->activeTables[$tName] = '<span title="' . $title . '">'
                         . $this->iconFactory->getIconForRecord($tName, array(), Icon::SIZE_SMALL)->render()
                         . '</span>'
                         . '&nbsp;' . $this->getLanguageService()->sL($GLOBALS['TCA'][$tName]['ctrl']['title'], true);
index 26e15b4..30670dd 100644 (file)
@@ -338,5 +338,4 @@ class PageTreeView extends BrowseTreeView
         }
         return $this->printTree($treeArr);
     }
-
 }
index 528c6bf..a01d8d3 100644 (file)
@@ -24,7 +24,6 @@ use TYPO3\CMS\Core\Type\Bitmask\Permission;
  */
 class PageLayoutControllerTest extends UnitTestCase
 {
-
     /**
      * @test
      * @dataProvider pageIsNotLockedForEditorsReturnsCorrectValueDataProvider
@@ -61,5 +60,4 @@ class PageLayoutControllerTest extends UnitTestCase
             'user does not have permission' => [ false, 0, false, false],
         ];
     }
-
 }
index 6bdd8a0..9c4589d 100644 (file)
@@ -23,7 +23,7 @@ use TYPO3\CMS\Backend\Form\FormDataGroupInterface;
 /**
  * Test case
  */
-class FormDataComplierTest extends UnitTestCase
+class FormDataCompilerTest extends UnitTestCase
 {
     /**
      * @var FormDataCompiler
index 30a293b..636625a 100644 (file)
@@ -22,7 +22,6 @@ use TYPO3\CMS\Core\Tests\UnitTestCase;
  */
 class InlineOverrrideChildTcaTest extends UnitTestCase
 {
-
     /**
      * @var InlineOverrideChildTca
      */
index 0ded17c..14fc0d0 100644 (file)
@@ -380,5 +380,4 @@ class TcaCheckboxItemsTest extends UnitTestCase
         $this->assertSame($expected, $this->subject->addData($input));
         $this->subject->addData($input);
     }
-
 }
index 79068d4..3c4fdba 100644 (file)
@@ -375,5 +375,4 @@ class TcaColumnsProcessShowitemTest extends UnitTestCase
         $expected['columnsToProcess'] = [ 'aField' ];
         $this->assertSame($expected, $this->subject->addData($input));
     }
-
 }
index 0aabb6a..219f509 100644 (file)
@@ -211,4 +211,4 @@ class BackendUserActionController extends ActionController
     {
         return $GLOBALS['LANG'];
     }
-}
\ No newline at end of file
+}
index 0d1e526..e2fa55e 100644 (file)
@@ -133,5 +133,4 @@ class FrontendFormProtection extends AbstractFormProtection
     {
         return !empty($this->frontendUser->user['uid']);
     }
-
 }
index 891bb2c..ca56e38 100644 (file)
@@ -82,11 +82,11 @@ class FileWriter extends AbstractWriter
      */
     public function setLogFile($relativeLogFile)
     {
-       $logFile = $relativeLogFile;
+        $logFile = $relativeLogFile;
         // Skip handling if logFile is a stream resource. This is used by unit tests with vfs:// directories
         if (false === strpos($logFile, '://') && !PathUtility::isAbsolutePath($logFile)) {
             $logFile = GeneralUtility::getFileAbsFileName($logFile);
-            if ($logFile === NULL) {
+            if ($logFile === null) {
                 throw new InvalidLogWriterConfigurationException('Log file path "' . $relativeLogFile . '" is not valid!', 1444374805);
             }
         }
index 3b9c9f2..86a0b04 100644 (file)
@@ -575,7 +575,8 @@ class TcaMigration
      * @param array $tca
      * @return array Migrated TCA
      */
-    public function migrateSelectFieldIconTable(array $tca) {
+    public function migrateSelectFieldIconTable(array $tca)
+    {
         foreach ($tca as $table => &$tableDefinition) {
             if (!isset($tableDefinition['columns']) || !is_array($tableDefinition['columns'])) {
                 continue;
index 8f9f0eb..0a92f89 100644 (file)
@@ -2848,7 +2848,7 @@ class ResourceStorage implements ResourceStorageInterface
             }
             try {
                 if (strpos($processingFolder, ':') !== false) {
-                    list ($storageUid, $processingFolderIdentifier) = explode(':', $processingFolder, 2);
+                    list($storageUid, $processingFolderIdentifier) = explode(':', $processingFolder, 2);
                     $storage = ResourceFactory::getInstance()->getStorageObject($storageUid);
                     if ($storage->hasFolder($processingFolderIdentifier)) {
                         $this->processingFolder = $storage->getFolder($processingFolderIdentifier);
index 8967a32..798c8c2 100644 (file)
@@ -15,8 +15,6 @@ namespace TYPO3\CMS\Core\Utility\File;
  */
 
 use TYPO3\CMS\Backend\Utility\BackendUtility;
-use TYPO3\CMS\Core\Imaging\Icon;
-use TYPO3\CMS\Core\Imaging\IconFactory;
 use TYPO3\CMS\Core\Messaging\FlashMessage;
 use TYPO3\CMS\Core\Messaging\FlashMessageService;
 use TYPO3\CMS\Core\Resource\DuplicationBehavior;
index 90f0176..e3d7c8c 100644 (file)
@@ -247,5 +247,4 @@ class ActionTest extends \TYPO3\CMS\Core\Tests\Functional\DataHandling\FAL\Abstr
             ->setRecordIdentifier(self::TABLE_Content . ':' . self::VALUE_ContentIdLast)->setRecordField(self::FIELD_ContentImage)
             ->setTable(self::TABLE_FileReference)->setField('title')->setValues('Taken at T3BOARD', 'This is Kasper'));
     }
-
 }
index f4a7cf3..84032d4 100644 (file)
@@ -122,5 +122,4 @@ class BackendFormProtectionTest extends \TYPO3\CMS\Core\Tests\UnitTestCase
     {
         $this->subject->validateToken('foo', 'bar');
     }
-
 }
index 0a2fe1c..a5102df 100644 (file)
@@ -165,5 +165,4 @@ class FormProtectionFactoryTest extends \TYPO3\CMS\Core\Tests\UnitTestCase
     {
         $this->assertFalse($flashMessage->isSessionMessage());
     }
-
 }
index f6bd074..6a0dfef 100644 (file)
@@ -15,7 +15,6 @@ namespace TYPO3\CMS\Core\Tests\Unit\Log\Writer;
  */
 
 use org\bovigo\vfs\vfsStream;
-use org\bovigo\vfs\vfsStreamDirectory;
 use org\bovigo\vfs\vfsStreamWrapper;
 
 /**
index 1274454..2bb55f4 100644 (file)
@@ -833,7 +833,8 @@ class TcaMigrationTest extends UnitTestCase
     /**
      * @return array
      */
-    public function migrateSetsShowIconTableIfMissingDataProvider() {
+    public function migrateSetsShowIconTableIfMissingDataProvider()
+    {
         return [
             'not-a-select-is-kept' => [
                 [
@@ -960,7 +961,8 @@ class TcaMigrationTest extends UnitTestCase
      * @param array $givenConfig
      * @param array $expectedConfig
      */
-    public function migrateSetsShowIconTableIfMissing(array $givenConfig, array $expectedConfig) {
+    public function migrateSetsShowIconTableIfMissing(array $givenConfig, array $expectedConfig)
+    {
         $input = [
             'aTable' => [
                 'columns' => [
index 46eb25d..164e67b 100644 (file)
@@ -24,13 +24,11 @@ use TYPO3\CMS\Core\Tests\UnitTestCase;
  */
 class IndexerTest extends UnitTestCase
 {
-
     /**
      * @test
      */
     public function isFileTypeSupportedByExtractorReturnsFalesForFileTypeTextAndExtractorLimitedToFileTypeImage()
     {
-
         $mockStorage = $this->getMock(\TYPO3\CMS\Core\Resource\ResourceStorage::class, [], [], '', false);
         $mockFile = $this->getMock(File::class, [], [], '', false);
         $mockFile->expects($this->any())->method('getType')->will($this->returnValue(
@@ -58,7 +56,6 @@ class IndexerTest extends UnitTestCase
      */
     public function isFileTypeSupportedByExtractorReturnsTrueForFileTypeImageAndExtractorLimitedToFileTypeImage()
     {
-
         $mockStorage = $this->getMock(\TYPO3\CMS\Core\Resource\ResourceStorage::class, [], [], '', false);
         $mockFile = $this->getMock(File::class, [], [], '', false);
         $mockFile->expects($this->any())->method('getType')->will($this->returnValue(
@@ -86,7 +83,6 @@ class IndexerTest extends UnitTestCase
      */
     public function isFileTypeSupportedByExtractorReturnsTrueForFileTypeTextAndExtractorHasNoFileTypeLimitation()
     {
-
         $mockStorage = $this->getMock(\TYPO3\CMS\Core\Resource\ResourceStorage::class, [], [], '', false);
         $mockFile = $this->getMock(File::class, [], [], '', false);
         $mockFile->expects($this->any())->method('getType')->will($this->returnValue(
index c04b8a2..c2a85c3 100644 (file)
@@ -50,7 +50,7 @@ class IconViewHelperTest extends ViewHelperBaseTestcase
         $iconProphecy = $this->prophesize(Icon::class);
 
         $iconFactoryProphecy->getIcon('myIdentifier', Icon::SIZE_SMALL, null, IconState::cast(IconState::STATE_DEFAULT))->shouldBeCalled()->willReturn($iconProphecy->reveal());
-        $iconProphecy->render(NULL)->shouldBeCalled()->willReturn('htmlFoo');
+        $iconProphecy->render(null)->shouldBeCalled()->willReturn('htmlFoo');
 
         $this->assertSame('htmlFoo', $this->viewHelper->render('myIdentifier'));
     }
@@ -65,7 +65,7 @@ class IconViewHelperTest extends ViewHelperBaseTestcase
         $iconProphecy = $this->prophesize(Icon::class);
 
         $iconFactoryProphecy->getIcon('myIdentifier', Icon::SIZE_LARGE, null, IconState::cast(IconState::STATE_DEFAULT))->shouldBeCalled()->willReturn($iconProphecy->reveal());
-        $iconProphecy->render(NULL)->shouldBeCalled()->willReturn('htmlFoo');
+        $iconProphecy->render(null)->shouldBeCalled()->willReturn('htmlFoo');
 
         $this->assertSame('htmlFoo', $this->viewHelper->render('myIdentifier', Icon::SIZE_LARGE));
     }
@@ -80,7 +80,7 @@ class IconViewHelperTest extends ViewHelperBaseTestcase
         $iconProphecy = $this->prophesize(Icon::class);
 
         $iconFactoryProphecy->getIcon('myIdentifier', Icon::SIZE_SMALL, null, IconState::cast(IconState::STATE_DISABLED))->shouldBeCalled()->willReturn($iconProphecy->reveal());
-        $iconProphecy->render(NULL)->shouldBeCalled()->willReturn('htmlFoo');
+        $iconProphecy->render(null)->shouldBeCalled()->willReturn('htmlFoo');
 
         $this->assertSame('htmlFoo', $this->viewHelper->render('myIdentifier', Icon::SIZE_SMALL, null, IconState::cast(IconState::STATE_DISABLED)));
     }
@@ -95,7 +95,7 @@ class IconViewHelperTest extends ViewHelperBaseTestcase
         $iconProphecy = $this->prophesize(Icon::class);
 
         $iconFactoryProphecy->getIcon('myIdentifier', Argument::any(), 'overlayString', IconState::cast(IconState::STATE_DEFAULT))->shouldBeCalled()->willReturn($iconProphecy->reveal());
-        $iconProphecy->render(NULL)->shouldBeCalled()->willReturn('htmlFoo');
+        $iconProphecy->render(null)->shouldBeCalled()->willReturn('htmlFoo');
 
         $this->assertSame('htmlFoo', $this->viewHelper->render('myIdentifier', Icon::SIZE_LARGE, 'overlayString'));
     }
index 2e6d0cd..31cd673 100644 (file)
@@ -1788,7 +1788,7 @@ class DatabaseConnection extends \TYPO3\CMS\Core\Database\DatabaseConnection
                         }
                         if ($where_clause[$k]['func']['field'] !== '') {
                             if ($this->dbmsSpecifics->getSpecific(Specifics\AbstractSpecifics::CAST_FIND_IN_SET)) {
-                                if($where_clause[$k]['func']['table'] !== '') {
+                                if ($where_clause[$k]['func']['table'] !== '') {
                                     $where_clause[$k]['func']['field'] = $this->quoteName($v['func']['field']) . ' AS CHAR)';
                                 } else {
                                     $where_clause[$k]['func']['field'] = 'CAST(' . $this->quoteName($v['func']['field']) . ' AS CHAR)';
index 42d3f27..87340d4 100644 (file)
@@ -129,5 +129,4 @@ class FormatsViewHelper extends AbstractViewHelper implements CompilableInterfac
         }
         return $iconHtml;
     }
-
 }
index b33f434..79c33b1 100644 (file)
@@ -20,8 +20,8 @@ use TYPO3\CMS\Extbase\Mvc\Web\Routing\UriBuilder;
 /**
  * Abstract action controller.
  */
-class AbstractModuleController extends AbstractController {
-
+class AbstractModuleController extends AbstractController
+{
     /**
      * BackendTemplateContainer
      *
@@ -126,4 +126,4 @@ class AbstractModuleController extends AbstractController {
         $uriBuilder->setRequest($this->request);
         return $uriBuilder->reset()->uriFor($action, $parameters, $controller);
     }
-}
\ No newline at end of file
+}
index 51a000b..cfe76ad 100644 (file)
@@ -242,7 +242,8 @@ class InstallUtility implements \TYPO3\CMS\Core\SingletonInterface
     /**
      * Reset and reload the available extensions
      */
-    public function reloadAvailableExtensions() {
+    public function reloadAvailableExtensions()
+    {
         $this->listUtility->reloadAvailableExtensions();
     }
 
index 89bfc9b..258f21e 100644 (file)
@@ -58,7 +58,7 @@ class ListUtility implements \TYPO3\CMS\Core\SingletonInterface
     /**
      * @var array
      */
-    protected $availableExtensions = NULL;
+    protected $availableExtensions = null;
 
     /**
      * @param \TYPO3\CMS\Extensionmanager\Utility\EmConfUtility $emConfUtility
@@ -127,7 +127,8 @@ class ListUtility implements \TYPO3\CMS\Core\SingletonInterface
     /**
      * Reset and reload the available extensions
      */
-    public function reloadAvailableExtensions() {
+    public function reloadAvailableExtensions()
+    {
         $this->availableExtensions = null;
         $this->packageManager->scanAvailablePackages();
         $this->getAvailableExtensions();
index 99c602f..d9464ea 100644 (file)
@@ -42,7 +42,6 @@ use TYPO3\CMS\Filelist\FileList;
  */
 class FileListController extends ActionController
 {
-
     /**
      * Module configuration
      *
index 5042135..d5eef74 100755 (executable)
@@ -55,7 +55,7 @@ class AdminPanelView
      *
      * @var bool
      */
-    protected $extFeEditLoaded = FALSE;
+    protected $extFeEditLoaded = false;
 
     /**
      * Constructor
index aac4a9f..4c78f31 100644 (file)
@@ -156,7 +156,6 @@ class InfoPageTyposcriptConfigController extends \TYPO3\CMS\Backend\Module\Abstr
                                                <!-- Edit fields: -->
                                                <table border="0" cellpadding="0" cellspacing="1">' . implode('', $lines) . '</table><br />' . $editIcon;
                 $theOutput .= '</div>';
-
             } else {
                 // Defined global here!
                 $tmpl = GeneralUtility::makeInstance(\TYPO3\CMS\Core\TypoScript\ExtendedTemplateService::class);
index dfd28e3..57c2bc5 100644 (file)
@@ -26,7 +26,6 @@ use TYPO3\CMS\Extensionmanager\Utility\ListUtility;
  */
 abstract class AbstractDownloadExtensionUpdate extends AbstractUpdate
 {
-
     /**
      * @var string
      */
index d6b4e0d..3f7d9ba 100644 (file)
@@ -88,5 +88,4 @@ class AccessRightParametersUpdate extends AbstractUpdate
         $this->markWizardAsDone();
         return true;
     }
-
 }
index de88559..d962bf6 100644 (file)
@@ -264,12 +264,12 @@ class LanguageController extends ActionController
         /** @var Menu $menu */
         $menu = GeneralUtility::makeInstance(Menu::class);
         $menu->setIdentifier('_languageMenu');
-        $menu->setLabel($this->getLanguageService()->sL('LLL:EXT:lang/locallang_general.xlf:LGL.language', TRUE));
+        $menu->setLabel($this->getLanguageService()->sL('LLL:EXT:lang/locallang_general.xlf:LGL.language', true));
 
         /** @var MenuItem $languageListMenuItem */
         $languageListMenuItem = GeneralUtility::makeInstance(MenuItem::class);
         $action = 'listLanguages';
-        $isActive = $this->request->getControllerActionName() === $action ? TRUE : FALSE;
+        $isActive = $this->request->getControllerActionName() === $action ? true : false;
         $languageListMenuItem->setTitle($this->getLanguageService()->sL('LLL:EXT:lang/Resources/Private/Language/locallang.xlf:header.languages'));
         $uri = $uriBuilder->reset()->uriFor('listLanguages', array(), 'Language');
         $languageListMenuItem->setHref($uri)->setActive($isActive);
@@ -277,7 +277,7 @@ class LanguageController extends ActionController
         /** @var MenuItem $translationMenuItem */
         $translationMenuItem = GeneralUtility::makeInstance(MenuItem::class);
         $action = 'listTranslations';
-        $isActive = $this->request->getControllerActionName() === $action ? TRUE : FALSE;
+        $isActive = $this->request->getControllerActionName() === $action ? true : false;
         $translationMenuItem->setTitle($this->getLanguageService()->sL('LLL:EXT:lang/Resources/Private/Language/locallang.xlf:header.translations'));
         $uri = $uriBuilder->reset()->uriFor('listTranslations', array(), 'Language');
         $translationMenuItem->setHref($uri)->setActive($isActive);
index fc821d7..05bad02 100644 (file)
@@ -228,7 +228,7 @@ class DatabaseIntegrityView extends BaseScriptClass
         $shortCutButton = $buttonBar->makeShortcutButton()
             ->setModuleName($this->moduleName)
             ->setDisplayName($this->MOD_MENU['function'][$this->MOD_SETTINGS['function']])
-            ->setSetVariables(['function','search','search_query_makeQuery']);
+            ->setSetVariables(['function', 'search', 'search_query_makeQuery']);
         $buttonBar->addButton($shortCutButton, ButtonBar::BUTTON_POSITION_RIGHT, 2);
 
         $this->getModuleMenu();
@@ -501,6 +501,4 @@ class DatabaseIntegrityView extends BaseScriptClass
     {
         return $this->moduleTemplate;
     }
-
-
 }
index 270a522..d81c635 100644 (file)
@@ -625,7 +625,8 @@ abstract class AbstractLinkBrowserController
      *
      * @return array
      */
-    public function getConfiguration() {
+    public function getConfiguration()
+    {
         return [];
     }
 
index fc477af..3b80c6c 100644 (file)
@@ -85,7 +85,8 @@ abstract class AbstractLinkHandler
      * @param string[] $fieldDefinitions Array of link attribute field definitions
      * @return string[]
      */
-    public function modifyLinkAttributes(array $fieldDefinitions) {
+    public function modifyLinkAttributes(array $fieldDefinitions)
+    {
         return $fieldDefinitions;
     }
 
index ff865ca..1f0ee5d 100644 (file)
@@ -312,7 +312,8 @@ class PageLinkHandler extends AbstractLinkHandler implements LinkHandlerInterfac
      * @param string[] $fieldDefinitions Array of link attribute field definitions
      * @return string[]
      */
-    public function modifyLinkAttributes(array $fieldDefinitions) {
+    public function modifyLinkAttributes(array $fieldDefinitions)
+    {
         $configuration = $this->linkBrowser->getConfiguration();
         if (!empty($configuration['pageIdSelector.']['enabled'])) {
             $fieldDefinitions['pageIdSelector'] = '
index 97548e8..c4caa0f 100644 (file)
@@ -37,7 +37,6 @@ use TYPO3\CMS\Core\Utility\MathUtility;
  */
 class AbstractDatabaseRecordList extends AbstractRecordList
 {
-
     /**
      * Specify a list of tables which are the only ones allowed to be displayed.
      *
@@ -590,7 +589,7 @@ class AbstractDatabaseRecordList extends AbstractRecordList
      *
      * Various helper functions
      *
-        ******************************/
+     ******************************/
     /**
      * Setting the field names to display in extended list.
      * Sets the internal variable $this->setFields
@@ -734,8 +733,8 @@ class AbstractDatabaseRecordList extends AbstractRecordList
                             } elseif ($fieldConfig['type'] == 'text' ||
                                 $fieldConfig['type'] == 'flex' ||
                                 ($fieldConfig['type'] == 'input' && (!$fieldConfig['eval'] || !preg_match('/date|time|int/', $fieldConfig['eval'])))) {
-                                    $condition = $fieldName . ' LIKE \'%' . $this->searchString . '%\'';
-                                    $whereParts[] = $condition;
+                                $condition = $fieldName . ' LIKE \'%' . $this->searchString . '%\'';
+                                $whereParts[] = $condition;
                             }
                         }
                     }
index 1d677ad..0033a3e 100644 (file)
@@ -26,7 +26,6 @@ use TYPO3\CMS\Reports\ReportInterface;
  */
 class ReportController extends ActionController
 {
-
     /**
      * @var BackendTemplateView
      */
index 4802e5f..0b50cb9 100644 (file)
@@ -570,7 +570,8 @@ class BrowseLinksController extends AbstractLinkBrowserController
      *
      * @return array
      */
-    public function getConfiguration() {
+    public function getConfiguration()
+    {
         return $this->buttonConfig;
     }
 
index f4eee94..e86f0e1 100644 (file)
@@ -986,13 +986,13 @@ class SchedulerModuleController extends \TYPO3\CMS\Backend\Module\BaseScriptClas
             $table[] =
                 '<thead><tr>'
                     . '<th><a href="#" id="checkall" title="' . $this->getLanguageService()->getLL('label.checkAll', true) . '" class="icon">' . $this->moduleTemplate->getIconFactory()->getIcon('actions-document-select', Icon::SIZE_SMALL)->render() . '</a></th>'
-                    . '<th>' . $this->getLanguageService()->getLL('label.id', true). '</th>'
-                    . '<th>' . $this->getLanguageService()->getLL('task', true). '</th>'
-                    . '<th>' . $this->getLanguageService()->getLL('label.type', true). '</th>'
-                    . '<th>' . $this->getLanguageService()->getLL('label.frequency', true). '</th>'
-                    . '<th>' . $this->getLanguageService()->getLL('label.parallel', true). '</th>'
-                    . '<th>' . $this->getLanguageService()->getLL('label.lastExecution', true). '</th>'
-                    . '<th>' . $this->getLanguageService()->getLL('label.nextExecution', true). '</th>'
+                    . '<th>' . $this->getLanguageService()->getLL('label.id', true) . '</th>'
+                    . '<th>' . $this->getLanguageService()->getLL('task', true) . '</th>'
+                    . '<th>' . $this->getLanguageService()->getLL('label.type', true) . '</th>'
+                    . '<th>' . $this->getLanguageService()->getLL('label.frequency', true) . '</th>'
+                    . '<th>' . $this->getLanguageService()->getLL('label.parallel', true) . '</th>'
+                    . '<th>' . $this->getLanguageService()->getLL('label.lastExecution', true) . '</th>'
+                    . '<th>' . $this->getLanguageService()->getLL('label.nextExecution', true) . '</th>'
                     . '<th></th>'
                 . '</tr></thead>';
 
@@ -1018,7 +1018,8 @@ class SchedulerModuleController extends \TYPO3\CMS\Backend\Module\BaseScriptClas
                     $table[] = '<tr><td colspan="9">' . $groupText . '</td></tr>';
                 }
 
-                foreach ($taskGroup['tasks'] as $schedulerRecord) {// Define action icons
+                foreach ($taskGroup['tasks'] as $schedulerRecord) {
+                    // Define action icons
                     $link = htmlspecialchars($this->moduleUri . '&CMD=edit&tx_scheduler[uid]=' . $schedulerRecord['uid']);
                     $editAction = '<a class="btn btn-default" href="' . $link . '" title="' . $this->getLanguageService()->sL('LLL:EXT:lang/locallang_common.xlf:edit', true) . '" class="icon">' .
                         $this->moduleTemplate->getIconFactory()->getIcon('actions-document-open', Icon::SIZE_SMALL)->render() . '</a>';
@@ -1659,5 +1660,4 @@ class SchedulerModuleController extends \TYPO3\CMS\Backend\Module\BaseScriptClas
     {
         return $GLOBALS['TYPO3_DB'];
     }
-
 }
index 960eb0e..6c172c9 100644 (file)
@@ -359,7 +359,7 @@ class TypoScriptTemplateObjectBrowserModuleFunctionController extends AbstractFu
                 $out .= '      <input class="btn btn-default" type="submit" name="add_property" value="' . $lang->getLL('addButton') . '" />';
                 $out .= '</div>';
                 $theOutput .= '<div style="padding-top: 20px;"></div>';
-                $theOutput .= '<h3>'. $lang->getLL('addProperty', true) . '</h3>';
+                $theOutput .= '<h3>' . $lang->getLL('addProperty', true) . '</h3>';
                 $theOutput .= $out;
                 // clear
                 $out = '<div class="form-group">';
index e9fe030..b37a294 100644 (file)
@@ -376,5 +376,4 @@ abstract class AbstractActionTestCase extends \TYPO3\CMS\Core\Tests\Functional\D
         // Switch back to draft workspace
         $this->backendUser->workspace = static::VALUE_WorkspaceId;
     }
-
 }
index d556dd9..163ca1e 100644 (file)
@@ -462,5 +462,4 @@ class ActionTest extends \TYPO3\CMS\Workspaces\Tests\Functional\DataHandling\Reg
 //        $this->assertThat($responseSectionsDraft, $this->getRequestSectionDoesNotHaveRecordConstraint()
 //            ->setTable(static::TABLE_Page)->setField('title')->setValues('Testing #1'));
     }
-
 }
index 1a3fb9f..6603539 100644 (file)
@@ -26,7 +26,6 @@ use TYPO3\CMS\Core\Utility\GeneralUtility;
  */
 class ExtDirectServerTest extends \TYPO3\CMS\Core\Tests\UnitTestCase
 {
-
     /**
      * @var \TYPO3\CMS\Workspaces\ExtDirect\ExtDirectServer
      */
@@ -49,7 +48,8 @@ class ExtDirectServerTest extends \TYPO3\CMS\Core\Tests\UnitTestCase
     /**
      * Tear down.
      */
-    protected function tearDown() {
+    protected function tearDown()
+    {
         parent::tearDown();
         unset($this->subject);
         unset($this->fileReferenceProphecies);
@@ -58,7 +58,8 @@ class ExtDirectServerTest extends \TYPO3\CMS\Core\Tests\UnitTestCase
     /**
      * @return array
      */
-    public function prepareFileReferenceDifferencesAreCorrectDataProvider() {
+    public function prepareFileReferenceDifferencesAreCorrectDataProvider()
+    {
         return array(
             // without thumbnails
             'unchanged wo/thumbnails' => array('1,2,3,4', '1,2,3,4', false, null),
@@ -123,7 +124,8 @@ class ExtDirectServerTest extends \TYPO3\CMS\Core\Tests\UnitTestCase
      * @dataProvider prepareFileReferenceDifferencesAreCorrectDataProvider
      * @test
      */
-    public function prepareFileReferenceDifferencesAreCorrect($fileFileReferenceList, $versionFileReferenceList, $useThumbnails, array $expected = null) {
+    public function prepareFileReferenceDifferencesAreCorrect($fileFileReferenceList, $versionFileReferenceList, $useThumbnails, array $expected = null)
+    {
         $liveFileReferences = $this->getFileReferenceProphecies($fileFileReferenceList);
         $versionFileReferences = $this->getFileReferenceProphecies($versionFileReferenceList);
 
@@ -141,7 +143,8 @@ class ExtDirectServerTest extends \TYPO3\CMS\Core\Tests\UnitTestCase
      * @param string $idList List of ids
      * @return FileReference[]|ObjectProphecy[]
      */
-    protected function getFileReferenceProphecies($idList) {
+    protected function getFileReferenceProphecies($idList)
+    {
         $fileReferenceProphecies = array();
         $ids = GeneralUtility::trimExplode(',', $idList, true);
 
@@ -156,7 +159,8 @@ class ExtDirectServerTest extends \TYPO3\CMS\Core\Tests\UnitTestCase
      * @param int $id
      * @return ObjectProphecy|FileReference
      */
-    protected function getFileReferenceProphecy($id) {
+    protected function getFileReferenceProphecy($id)
+    {
         if (isset($this->fileReferenceProphecies[$id])) {
             return $this->fileReferenceProphecies[$id];
         }
@@ -175,5 +179,4 @@ class ExtDirectServerTest extends \TYPO3\CMS\Core\Tests\UnitTestCase
         $this->fileReferenceProphecies[$id] = $fileReferenceProphecy->reveal();
         return $this->fileReferenceProphecies[$id];
     }
-
 }