[TASK] EXT:form - minor UX/ UI optimizations 28/52328/4
authorRalf Zimmermann <ralf.zimmermann@tritum.de>
Mon, 3 Apr 2017 09:40:22 +0000 (11:40 +0200)
committerBenni Mack <benni@typo3.org>
Thu, 13 Apr 2017 08:11:29 +0000 (10:11 +0200)
* Add module description text
* Change order of form elements within the "create new element" modal
* Allow changing labels of submit, previous, and next button within the
  form editor

Resolves: #80650
Releases: master
Change-Id: Ibeced5cdfcbc5c0124b74dea599d21c446c76eb4
Reviewed-on: https://review.typo3.org/52328
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Steiger <typo3@andreassteiger.de>
Tested-by: Andreas Steiger <typo3@andreassteiger.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Henrik Elsner <helsner@dfau.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
typo3/sysext/form/Configuration/Yaml/BaseSetup.yaml
typo3/sysext/form/Configuration/Yaml/FormEditorSetup.yaml
typo3/sysext/form/Resources/Private/Language/Database.xlf
typo3/sysext/form/Resources/Private/Language/locallang.xlf
typo3/sysext/form/Resources/Private/Language/locallang_module.xlf

index f1e8127..5a9bf55 100644 (file)
@@ -42,6 +42,8 @@ TYPO3:
                   enable: true
                   formElementToUse: 'Honeypot'
 
+                submitButtonLabel: 'Submit'
+
                 # set this to TRUE if you want to avoid exceptions for FormElements without definitions
                 skipUnknownElements: true
 
@@ -53,6 +55,8 @@ TYPO3:
               renderingOptions:
                 _isTopLevelFormElement: true
                 _isCompositeFormElement: true
+                nextButtonLabel: 'next Page'
+                previousButtonLabel: 'previous Page'
 
             SummaryPage:
               __inheritances:
@@ -60,6 +64,8 @@ TYPO3:
               renderingOptions:
                 _isTopLevelFormElement: true
                 _isCompositeFormElement: false
+                nextButtonLabel: 'next Page'
+                previousButtonLabel: 'previous Page'
 
             Fieldset:
               __inheritances:
index b5de05a..ad469df 100644 (file)
@@ -155,8 +155,15 @@ TYPO3:
                 paginationTitle: 'formEditor.pagination.title'
 
                 iconIdentifier: 'content-elements-mailform'
-                predefinedDefaults: []
+                predefinedDefaults:
+                  renderingOptions:
+                    submitButtonLabel: 'formEditor.elements.Form.editor.submitButtonLabel.value'
                 editors:
+                  300:
+                    identifier: 'submitButtonLabel'
+                    templateName: 'Inspector-TextEditor'
+                    label: 'formEditor.elements.Form.editor.submitButtonLabel.label'
+                    propertyPath: 'renderingOptions.submitButtonLabel'
                   900:
                     identifier: 'finishers'
                     templateName: 'Inspector-FinishersEditor'
@@ -329,7 +336,10 @@ TYPO3:
               formEditor:
                 __inheritances:
                   10: 'TYPO3.CMS.Form.mixins.formElementMixins.RemovableFormElementMixin'
-                predefinedDefaults: []
+                predefinedDefaults:
+                  renderingOptions:
+                    previousButtonLabel: 'formEditor.elements.Page.editor.previousButtonLabel.value'
+                    nextButtonLabel: 'formEditor.elements.Page.editor.nextButtonLabel.value'
                 label: 'formEditor.elements.Page.label'
                 group: page
                 groupSorting: 100
@@ -339,10 +349,23 @@ TYPO3:
                 editors:
                   200:
                     label: 'formEditor.elements.Page.editor.label.label'
+                  300:
+                    identifier: 'previousButtonLabel'
+                    templateName: 'Inspector-TextEditor'
+                    label: 'formEditor.elements.Page.editor.previousButtonLabel.label'
+                    propertyPath: 'renderingOptions.previousButtonLabel'
+                  400:
+                    identifier: 'nextButtonLabel'
+                    templateName: 'Inspector-TextEditor'
+                    label: 'formEditor.elements.Page.editor.nextButtonLabel.label'
+                    propertyPath: 'renderingOptions.nextButtonLabel'
 
             SummaryPage:
               formEditor:
-                predefinedDefaults: []
+                predefinedDefaults:
+                  renderingOptions:
+                    previousButtonLabel: 'formEditor.elements.SummaryPage.editor.previousButtonLabel.value'
+                    nextButtonLabel: 'formEditor.elements.SummaryPage.editor.nextButtonLabel.value'
                 label: 'formEditor.elements.SummaryPage.label'
                 group: page
                 groupSorting: 200
@@ -352,6 +375,16 @@ TYPO3:
                 editors:
                   200:
                     label: 'formEditor.elements.SummaryPage.editor.label.label'
+                  300:
+                    identifier: 'previousButtonLabel'
+                    templateName: 'Inspector-TextEditor'
+                    label: 'formEditor.elements.SummaryPage.editor.previousButtonLabel.label'
+                    propertyPath: 'renderingOptions.previousButtonLabel'
+                  400:
+                    identifier: 'nextButtonLabel'
+                    templateName: 'Inspector-TextEditor'
+                    label: 'formEditor.elements.SummaryPage.editor.nextButtonLabel.label'
+                    propertyPath: 'renderingOptions.nextButtonLabel'
 
             ### FORM ELEMENTS: INPUT ###
 
@@ -372,8 +405,8 @@ TYPO3:
             AdvancedPassword:
               formEditor:
                 label: 'formEditor.elements.AdvancedPassword.label'
-                group: input
-                groupSorting: 400
+                group: custom
+                groupSorting: 500
                 predefinedDefaults:
                   properties:
                     confirmationLabel: 'formEditor.element.AdvancedPassword.editor.confirmationLabel.predefinedDefaults'
@@ -390,8 +423,8 @@ TYPO3:
             Hidden:
               formEditor:
                 label: 'formEditor.elements.Hidden.label'
-                group: input
-                groupSorting: 500
+                group: custom
+                groupSorting: 300
                 iconIdentifier: 't3-form-icon-hidden'
                 predefinedDefaults:
                   defaultValue: ''
@@ -428,7 +461,7 @@ TYPO3:
               formEditor:
                 label: 'formEditor.elements.MultiCheckbox.label'
                 group: select
-                groupSorting: 500
+                groupSorting: 400
                 iconIdentifier: 't3-form-icon-multi-checkbox'
                 editors:
                   800:
@@ -439,7 +472,7 @@ TYPO3:
               formEditor:
                 label: 'formEditor.elements.MultiSelect.label'
                 group: select
-                groupSorting: 400
+                groupSorting: 500
                 iconIdentifier: 't3-form-icon-multi-select'
                 editors:
                   250:
@@ -477,7 +510,7 @@ TYPO3:
               formEditor:
                 label: 'formEditor.elements.DatePicker.label'
                 group: custom
-                groupSorting: 100
+                groupSorting: 200
                 predefinedDefaults:
                   properties:
                     dateFormat: 'Y-m-d'
@@ -526,7 +559,7 @@ TYPO3:
               formEditor:
                 label: 'formEditor.elements.StaticText.label'
                 group: custom
-                groupSorting: 400
+                groupSorting: 600
                 predefinedDefaults:
                   properties:
                     text: ''
@@ -542,7 +575,7 @@ TYPO3:
               formEditor:
                 label: 'formEditor.elements.ContentElement.label'
                 group: custom
-                groupSorting: 500
+                groupSorting: 700
                 predefinedDefaults:
                   properties:
                     contentElementUid: ''
@@ -566,7 +599,7 @@ TYPO3:
               formEditor:
                 label: 'formEditor.elements.FileUpload.label'
                 group: custom
-                groupSorting: 200
+                groupSorting: 100
                 predefinedDefaults:
                   properties:
                     allowedMimeTypes: ['application/pdf']
@@ -604,7 +637,7 @@ TYPO3:
               formEditor:
                 label: 'formEditor.elements.ImageUpload.label'
                 group: custom
-                groupSorting: 300
+                groupSorting: 400
                 predefinedDefaults:
                   properties:
                     allowedMimeTypes: ['image/jpeg']
index 6b5cbb7..2b10ad9 100644 (file)
             <trans-unit id="formEditor.elements.Form.editor.submitButtonLabel.label" xml:space="preserve">
                 <source>Submit label</source>
             </trans-unit>
+            <trans-unit id="formEditor.elements.Form.editor.submitButtonLabel.value" xml:space="preserve">
+                <source>Submit</source>
+            </trans-unit>
+
             <trans-unit id="formEditor.elements.Form.editor.finishers.label" xml:space="preserve">
                 <source>Finishers</source>
             </trans-unit>
             </trans-unit>
 
             <trans-unit id="formEditor.elements.ReadOnlyFormElement.editor.label.label" xml:space="preserve">
-                <source>Element name</source>
+                <source>Label</source>
             </trans-unit>
 
             <trans-unit id="formEditor.elements.FormElement.editor.label.label" xml:space="preserve">
-                <source>Element name</source>
+                <source>Label</source>
             </trans-unit>
             <trans-unit id="formEditor.elements.FormElement.editor.requiredValidator.label" xml:space="preserve">
                 <source>Required field</source>
                 <source>Page name</source>
             </trans-unit>
             <trans-unit id="formEditor.elements.Page.editor.previousButtonLabel.label" xml:space="preserve">
-                <source>Previous label</source>
+                <source>Previous button label</source>
+            </trans-unit>
+            <trans-unit id="formEditor.elements.Page.editor.previousButtonLabel.value" xml:space="preserve">
+                <source>previous Page</source>
             </trans-unit>
             <trans-unit id="formEditor.elements.Page.editor.nextButtonLabel.label" xml:space="preserve">
-                <source>Next label</source>
+                <source>Next button label</source>
+            </trans-unit>
+            <trans-unit id="formEditor.elements.Page.editor.nextButtonLabel.value" xml:space="preserve">
+                <source>next Page</source>
             </trans-unit>
 
             <trans-unit id="formEditor.elements.SummaryPage.label" xml:space="preserve">
             <trans-unit id="formEditor.elements.SummaryPage.editor.label.label" xml:space="preserve">
                 <source>Page name</source>
             </trans-unit>
+            <trans-unit id="formEditor.elements.SummaryPage.editor.previousButtonLabel.label" xml:space="preserve">
+                <source>Previous button label</source>
+            </trans-unit>
+            <trans-unit id="formEditor.elements.SummaryPage.editor.previousButtonLabel.value" xml:space="preserve">
+                <source>previous Page</source>
+            </trans-unit>
+            <trans-unit id="formEditor.elements.SummaryPage.editor.nextButtonLabel.label" xml:space="preserve">
+                <source>Next button label</source>
+            </trans-unit>
+            <trans-unit id="formEditor.elements.SummaryPage.editor.nextButtonLabel.value" xml:space="preserve">
+                <source>next Page</source>
+            </trans-unit>
 
             <trans-unit id="formEditor.elements.Fieldset.label" xml:space="preserve">
                 <source>Fieldset</source>
index b524e1c..34c005b 100644 (file)
@@ -3,21 +3,6 @@
     <file t3:id="1475977066" source-language="en" datatype="plaintext" original="messages" date="2016-10-09T03:38:32Z" product-name="form">
         <header/>
         <body>
-            <trans-unit id="element.Form.renderingOptions.submitButtonLabel" xml:space="preserve">
-                <source>Submit</source>
-            </trans-unit>
-            <trans-unit id="element.Page.renderingOptions.previousButtonLabel" xml:space="preserve">
-                <source>previous Page</source>
-            </trans-unit>
-            <trans-unit id="element.Page.renderingOptions.nextButtonLabel" xml:space="preserve">
-                <source>next Page</source>
-            </trans-unit>
-            <trans-unit id="element.SummaryPage.renderingOptions.previousButtonLabel" xml:space="preserve">
-                <source>previous Page</source>
-            </trans-unit>
-            <trans-unit id="element.SummaryPage.renderingOptions.nextButtonLabel" xml:space="preserve">
-                <source>next Page</source>
-            </trans-unit>
             <trans-unit id="element.ImageUpload.properties.SummaryPage.altText" xml:space="preserve">
                 <source>uploaded image</source>
             </trans-unit>
index fd1de2e..509ced8 100644 (file)
@@ -7,7 +7,7 @@
                 <source>Build custom forms</source>
             </trans-unit>
             <trans-unit id="mlang_labels_tabdescr">
-                <source>Build custom forms. TODO: Add more description.</source>
+                <source>This module ships a flexible and user-friendly form editor. It allows you to build and create versatile forms for your frontend. Your forms can easily be added to any page by using the content element "Mail Form". Within this element, finishers can be overridden.</source>
             </trans-unit>
             <trans-unit id="mlang_tabs_tab">
                 <source>Forms</source>