[TASK] Install tool should inform about suhosin.get.max_value_length
authorRoland Waldner <most.wanted@gmx.at>
Fri, 19 Oct 2012 11:29:03 +0000 (13:29 +0200)
committerGeorg Ringer <georg.ringer@gmail.com>
Sat, 20 Oct 2012 12:39:37 +0000 (14:39 +0200)
Change-Id: Ifbf4d901a496ce065c453073bc15cb7f3590fa61
Resolves: #42170
Releases: 6.0
Reviewed-on: http://review.typo3.org/15813
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Steffen Müller
Tested-by: Steffen Müller
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
typo3/sysext/install/Classes/Installer.php

index d385913..cc8def7 100644 (file)
@@ -2232,14 +2232,22 @@ REMOTE_ADDR was \'' . \TYPO3\CMS\Core\Utility\GeneralUtility::getIndpEnv('REMOTE
                                        At least a value of 400 is suggested.
                                </p>
                        ';
                                        At least a value of 400 is suggested.
                                </p>
                        ';
+                       $suhosinSuggestionGetMaxValueLength = '
+                               <p>
+                                       At least a value of 2000 is suggested.
+                               </p>
+                       ';
                        $suhosinRequestMaxVars = ini_get('suhosin.request.max_vars');
                        $suhosinPostMaxVars = ini_get('suhosin.post.max_vars');
                        $suhosinRequestMaxVars = ini_get('suhosin.request.max_vars');
                        $suhosinPostMaxVars = ini_get('suhosin.post.max_vars');
+                       $suhosinGetMaxValueLength = ini_get('suhosin.get.max_value_length');
                        $suhosinRequestMaxVarsType = $suhosinRequestMaxVars < 400 ? 2 : -1;
                        $suhosinPostMaxVarsType = $suhosinPostMaxVars < 400 ? 2 : -1;
                        $suhosinRequestMaxVarsType = $suhosinRequestMaxVars < 400 ? 2 : -1;
                        $suhosinPostMaxVarsType = $suhosinPostMaxVars < 400 ? 2 : -1;
-                       $suhosinType = $suhosinRequestMaxVars < 400 || $suhosinPostMaxVars < 400 ? 2 : -1;
+                       $suhosinGetMaxValueLengthType = $suhosinGetMaxValueLength < 2000 ? 2 : -1;
+                       $suhosinType = $suhosinRequestMaxVars < 400 || $suhosinPostMaxVars < 400 || $suhosinGetMaxValueLength < 2000 ? 2 : -1;
                        $this->message($ext, 'Suhosin/Hardened PHP is loaded', $suhosinDescription, $suhosinType);
                        $this->message($ext, 'suhosin.request.max_vars: ' . $suhosinRequestMaxVars, $suhosinSuggestion, $suhosinRequestMaxVarsType);
                        $this->message($ext, 'suhosin.post.max_vars: ' . $suhosinPostMaxVars, $suhosinSuggestion, $suhosinPostMaxVarsType);
                        $this->message($ext, 'Suhosin/Hardened PHP is loaded', $suhosinDescription, $suhosinType);
                        $this->message($ext, 'suhosin.request.max_vars: ' . $suhosinRequestMaxVars, $suhosinSuggestion, $suhosinRequestMaxVarsType);
                        $this->message($ext, 'suhosin.post.max_vars: ' . $suhosinPostMaxVars, $suhosinSuggestion, $suhosinPostMaxVarsType);
+                       $this->message($ext, 'suhosin.get.max_value_length: ' . $suhosinGetMaxValueLength, $suhosinSuggestionGetMaxValueLength, $suhosinGetMaxValueLengthType);
                } else {
                        $this->message($ext, 'Suhosin/Hardened PHP is not loaded', $suhosinDescription, 0);
                }
                } else {
                        $this->message($ext, 'Suhosin/Hardened PHP is not loaded', $suhosinDescription, 0);
                }