[BUGFIX] PHP 7.1 unit tests 41/48841/5
authorChristian Kuhn <lolli@schwarzbu.ch>
Thu, 7 Jul 2016 11:20:20 +0000 (13:20 +0200)
committerBenni Mack <benni@typo3.org>
Thu, 7 Jul 2016 12:10:38 +0000 (14:10 +0200)
commitf4fcbb8da2aee06a4573867b55fdd13e7515170f
treed1b608c1f6836b5b8081b6a382d4f91aca046d06
parentb2b622efd5ed832908c4f7e146b1c6895b37a59a
[BUGFIX] PHP 7.1 unit tests

Fix a couple of unit tests that fail with PHP 7.1:

* The phpunit mock builder seems to have minor issues mocking
mysqli correctly. This leads so slightly different method
signatures and PHP 7.1 is a bit more picky about those details.
Switching to prophecy on affected tests solves the issue.

* $tsfe->config is initialized as string, calling
$tsfe->config['foo']['bar'] = 'baz'; raises an error
"Error: Cannot use assign-op operators with string offsets".
Cleaning the assignment solves the issue.

Change-Id: I81f3a75e5b682064c6a43f989f0cf862e2d1bc6e
Resolves: #76980
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/48841
Reviewed-by: Sebastian Bumann <bumann.sebastian@gmail.com>
Tested-by: Bamboo TYPO3com <info@typo3.com>
Tested-by: Sebastian Bumann <bumann.sebastian@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
typo3/sysext/core/Tests/Unit/Database/DatabaseConnectionTest.php
typo3/sysext/frontend/Tests/Unit/Controller/TypoScriptFrontendControllerTest.php
typo3/sysext/indexed_search/Tests/Unit/IndexerTest.php