[!!!][TASK] Always use logging in authentication processes 53/54253/7
authorBenni Mack <benni@typo3.org>
Mon, 2 Oct 2017 05:28:51 +0000 (07:28 +0200)
committerChristian Kuhn <lolli@schwarzbu.ch>
Wed, 4 Oct 2017 08:34:43 +0000 (10:34 +0200)
commitede654a1a0b11f76409bb9ed94fd64ea7d345763
tree209029d6a93206b4e8171d726258c09fd2baa943
parent2012877852663a61cfc0237656e6ad06dbbb5ccd
[!!!][TASK] Always use logging in authentication processes

There are several checks within AuthenticationService, AbstractUserAuthentication
and AbstractService which can be dropped now that the Logging API is fully
configurable.

The following options have no effect anymore:
$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['t3lib/class.t3lib_userauth.php']['writeDevLog']
$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['t3lib/class.t3lib_userauth.php']['writeDevLogBE']
$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['t3lib/class.t3lib_userauth.php']['writeDevLogFE']
$GLOBALS['TYPO3_CONF_VARS']['SYS']['enable_DLOG']

The following public properties have no effect anymore and are removed:
* AbstractUserAuthentication->writeDevLog
* AbstractService->writeDevLog

Resolves: #82639
Relates: #52694
Releases: master
Change-Id: I01a1319bb4f34da03980ce04d8d30b6fe510eae2
Reviewed-on: https://review.typo3.org/54253
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
18 files changed:
typo3/sysext/core/Classes/Authentication/AbstractAuthenticationService.php
typo3/sysext/core/Classes/Authentication/AbstractUserAuthentication.php
typo3/sysext/core/Classes/Authentication/AuthenticationService.php
typo3/sysext/core/Classes/Service/AbstractService.php
typo3/sysext/core/Classes/Utility/GeneralUtility.php
typo3/sysext/core/Configuration/DefaultConfiguration.php
typo3/sysext/core/Configuration/DefaultConfigurationDescription.yaml
typo3/sysext/core/Documentation/Changelog/master/Breaking-82639-LoggingActivatedForAuthenticationAndServiceClasses.rst [new file with mode: 0644]
typo3/sysext/core/Documentation/Changelog/master/Deprecation-52694-DeprecatedGeneralUtilitydevLog.rst
typo3/sysext/core/Tests/Functional/Authentication/AuthenticationServiceTest.php
typo3/sysext/core/Tests/Unit/Authentication/BackendUserAuthenticationTest.php
typo3/sysext/frontend/Classes/Authentication/FrontendUserAuthentication.php
typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php
typo3/sysext/frontend/Tests/Unit/Authentication/FrontendUserAuthenticationTest.php
typo3/sysext/install/Classes/Service/SilentConfigurationUpgradeService.php
typo3/sysext/install/Configuration/ExtensionScanner/Php/ArrayDimensionMatcher.php
typo3/sysext/install/Configuration/ExtensionScanner/Php/PropertyPublicMatcher.php
typo3/sysext/rsaauth/Classes/RsaAuthService.php