[TASK] Make stateless Bootstrap methods static 75/55775/11
authorBenjamin Franzke <bfr@qbus.de>
Sat, 17 Feb 2018 15:00:58 +0000 (16:00 +0100)
committerFrank Naegler <frank.naegler@typo3.org>
Thu, 1 Mar 2018 13:32:30 +0000 (14:32 +0100)
commiteabae6ab0e0270301b9b83d211a25fe3b7f7c067
treeacd6be9d8b1420e99820b52259998ddbf372d5e1
parent48eec022c4837f38d48923b913dc5f4983a6f131
[TASK] Make stateless Bootstrap methods static

Methods that do not use $this but mainly act as utility
may be used statically.
The previous non-static chainable behaviour is preserved
by returning static::$instance. (Invoking a static method
non statically does not trigger E_NOTICE or alike.)

The motivation for this change is to deprecate the
Bootstrap instanciated usage at some (later) point
in order to reduce global state.

The following methods are affected:
 * initializeLanguageObject
 * initializeBackendAuthentication
 * initializeBackendUser
 * initializeBackendRouter
 * loadExtTables
 * loadBaseTca
 * loadTypo3LoadedExtAndExtLocalconf
 * unsetReservedGlobalVariables
 * startOutputBuffering
 * disableCoreCache

Releases: master
Resolves: #83952
Change-Id: I59d3027c5d10326d7bab2ae02e6ff0eb836f23e4
Reviewed-on: https://review.typo3.org/55775
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
31 files changed:
typo3/sysext/backend/Classes/Command/ReferenceIndexUpdateCommand.php
typo3/sysext/backend/Classes/Middleware/BackendRouteInitialization.php
typo3/sysext/backend/Classes/Middleware/BackendUserAuthenticator.php
typo3/sysext/backend/Tests/Functional/Controller/FormInlineAjaxControllerTest.php
typo3/sysext/backend/Tests/Functional/Controller/Page/LocalizationControllerTest.php
typo3/sysext/backend/Tests/Functional/Domain/Repository/Localization/LocalizationRepositoryTest.php
typo3/sysext/core/Classes/Console/CommandApplication.php
typo3/sysext/core/Classes/Console/CommandRequestHandler.php
typo3/sysext/core/Classes/Core/Bootstrap.php
typo3/sysext/core/Tests/Functional/DataHandling/AbstractDataHandlerActionTestCase.php
typo3/sysext/extensionmanager/Classes/Utility/InstallUtility.php
typo3/sysext/frontend/Classes/Middleware/BackendUserAuthenticator.php
typo3/sysext/impexp/Classes/Command/ImportCommand.php
typo3/sysext/impexp/Tests/Functional/AbstractImportExportTestCase.php
typo3/sysext/install/Classes/Controller/AbstractController.php
typo3/sysext/install/Classes/Controller/InstallerController.php
typo3/sysext/install/Classes/Controller/SettingsController.php
typo3/sysext/install/Classes/Service/ClearCacheService.php
typo3/sysext/lowlevel/Classes/Command/CleanFlexFormsCommand.php
typo3/sysext/lowlevel/Classes/Command/DeletedRecordsCommand.php
typo3/sysext/lowlevel/Classes/Command/FilesWithMultipleReferencesCommand.php
typo3/sysext/lowlevel/Classes/Command/LostFilesCommand.php
typo3/sysext/lowlevel/Classes/Command/MissingFilesCommand.php
typo3/sysext/lowlevel/Classes/Command/MissingRelationsCommand.php
typo3/sysext/lowlevel/Classes/Command/OrphanRecordsCommand.php
typo3/sysext/lowlevel/Classes/Command/RteImagesCommand.php
typo3/sysext/recycler/Tests/Functional/Recycle/AbstractRecycleTestCase.php
typo3/sysext/scheduler/Classes/Command/SchedulerCommand.php
typo3/sysext/workspaces/Classes/Command/WorkspaceVersionRecordsCommand.php
typo3/sysext/workspaces/Tests/Functional/ActionHandler/ActionHandlerTest.php
typo3/sysext/workspaces/Tests/Functional/Service/WorkspaceServiceTest.php