[TASK] FormEngine: Simplify element name resolving 62/39462/2
authorChristian Kuhn <lolli@schwarzbu.ch>
Mon, 11 May 2015 16:41:24 +0000 (18:41 +0200)
committerChristian Kuhn <lolli@schwarzbu.ch>
Mon, 11 May 2015 20:30:21 +0000 (22:30 +0200)
commite445a10355027300b353fc2b278820f9e1a3257a
tree57780ddaedb3f7f2a519e09459606c4d394deea3
parent3480cf1a568b98008cc4378dec00630c9ca6f10b
[TASK] FormEngine: Simplify element name resolving

Data submitted by FormEngine to DataHandler is prefixed in four
different ways:
* data - Transferred data
* cmd - A dataHandler command to execute
* data_files - Contains uploaded files
* action[control] - Overwrite fields data for NULL handling

These four prefixes are given along from FormEngine to the
whole container and element structure and never change.

To simplify this stuff, the patch removes the prefixes and
hardcodes them, and introduces a new globalOptions
$elementBaseName that contains the stuff behind the prefixes.
Quite some methods can be simplified this way and become
more obvious. Usage of $elementBaseName will be extended
with the next patch.

Change-Id: I8103b1d2068382e0b01bbe5d9bd79aeba2d00b08
Resolves: #66894
Releases: master
Reviewed-on: http://review.typo3.org/39462
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
15 files changed:
typo3/sysext/backend/Classes/Form/AbstractNode.php
typo3/sysext/backend/Classes/Form/Container/FlexFormElementContainer.php
typo3/sysext/backend/Classes/Form/Container/InlineControlContainer.php
typo3/sysext/backend/Classes/Form/Container/InlineRecordContainer.php
typo3/sysext/backend/Classes/Form/Container/SingleFieldContainer.php
typo3/sysext/backend/Classes/Form/Element/GroupElement.php
typo3/sysext/backend/Classes/Form/Element/SelectElement.php
typo3/sysext/backend/Classes/Form/FormDataTraverser.php
typo3/sysext/backend/Classes/Form/FormEngine.php
typo3/sysext/backend/Classes/Form/InlineRelatedRecordResolver.php
typo3/sysext/backend/Classes/Form/InlineStackProcessor.php
typo3/sysext/backend/Classes/Form/Utility/FormEngineUtility.php
typo3/sysext/backend/Resources/Public/JavaScript/jsfunc.inline.js
typo3/sysext/backend/Resources/Public/JavaScript/jsfunc.tbe_editor.js
typo3/sysext/backend/Tests/Unit/Form/InlineStackProcessorTest.php