[TASK] Speed up salted password unit test
authorChristian Kuhn <lolli@schwarzbu.ch>
Fri, 2 Nov 2012 15:05:47 +0000 (16:05 +0100)
committerChristian Kuhn <lolli@schwarzbu.ch>
Fri, 2 Nov 2012 15:21:04 +0000 (16:21 +0100)
commitd9f01d646ec570c4bc14d330abcdf6c7787e57c5
tree1aa2b9b64e4d5f1311ee3056f22d4ce7633d7ee5
parent11a52d7cf6aa7b8272129b86e797833cf7cb0e14
[TASK] Speed up salted password unit test

The patch removes tests in blowfish and phpass salting classes that
test maximum iteration count returns a valid salt. The underlying
salt code is slow by design, so the tests also take ages. The
functionality itself is already covered by the minimum salt count
test as well, thus - after speaking with Marcus Krause - we decided
to remove them without substitution to reduce the unit test suite
runtime.

Resolves: #42639
Releases: 6.0

Change-Id: I4bf94dc8ae4726fa131f6113546442fb00718753
Reviewed-on: http://review.typo3.org/16141
Reviewed-by: Wouter Wolters
Tested-by: Marcus Krause
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
typo3/sysext/saltedpasswords/Tests/Unit/Salt/BlowfishSaltTest.php
typo3/sysext/saltedpasswords/Tests/Unit/Salt/PhpassSaltTest.php