[TASK] Install Tool: Split up Checks into RequestHandlers 00/53800/21
authorBenni Mack <benni@typo3.org>
Thu, 24 Aug 2017 19:20:09 +0000 (21:20 +0200)
committerChristian Kuhn <lolli@schwarzbu.ch>
Wed, 30 Aug 2017 10:05:00 +0000 (12:05 +0200)
commitd7731f8d831be603d47f6a012dff57825cca3d3c
tree73b5750db383b5966c3f78cf2f2ee43c5cb60a6f
parent44e062a7e7075adc28a72fb13c9bb11848cd96b8
[TASK] Install Tool: Split up Checks into RequestHandlers

In order to get the controllers free of security checks, the logic of
authentication/session handling is moved from various controllers into
the RequestHandler and the Application.

Additionally, a second RequestHandler (RecoveryRequestHandler) is introduced
which acts as a fallback if TYPO3 is not installed yet, or the installation is
broken (e.g. missing PackageStates.php).

This brings a cleaner dispatching mechanism, having the RecoveryRequestHandler
(which can handle any request) dealing with the StepController, and the
regular RequestHandler (with higher priority) for handling the maintenance
functionality for running installations.

Resolves: #82238
Releases: master
Change-Id: I906ab3f15479bbe70202608f6bd7838cc22d9e3a
Reviewed-on: https://review.typo3.org/53800
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
typo3/sysext/install/Classes/Controller/AbstractController.php
typo3/sysext/install/Classes/Controller/AjaxController.php
typo3/sysext/install/Classes/Controller/StepController.php
typo3/sysext/install/Classes/Controller/ToolController.php
typo3/sysext/install/Classes/Exception/AuthenticationRequiredException.php [new file with mode: 0644]
typo3/sysext/install/Classes/Http/Application.php
typo3/sysext/install/Classes/Http/RecoveryRequestHandler.php [new file with mode: 0644]
typo3/sysext/install/Classes/Http/RequestHandler.php