[TASK] Replace IconUtility::skinImg with IconUtility::getSpriteImage Part 1 32/38132/18
authorJan Helke <typo3@helke.de>
Tue, 24 Mar 2015 20:19:14 +0000 (21:19 +0100)
committerBenjamin Mack <benni@typo3.org>
Mon, 13 Apr 2015 05:21:33 +0000 (07:21 +0200)
commitd265026fb1e5c06a8b17fc1902f38481d9fde86c
tree503862109a56072fd932eda1bd6e1d6648503171
parent1765249ffe7df0a5e43411ce694a97bf63dff8f7
[TASK] Replace IconUtility::skinImg with IconUtility::getSpriteImage Part 1

This patch replaces a lot occurrences of IconUtility::skinImg with
IconUtility::getSpriteImage or similar.

Thinks that will be ignored in this iteration:

\TYPO3\CMS\Backend\Clipboard\Clipboard::printClipboard
- Here skinImg returns just the path to use in an select option. This
  is not possible with getSpriteIcon.
\TYPO3\CMS\Backend\Controller\EditDocumentController::getButtons
- Here skinImg returns just the path to use for input button. This is
  not possible with getSpriteIcon.
\TYPO3\CMS\Backend\Controller\LoginController
- There is no sprite icon replacement for the TYPO3 Logo.
\TYPO3\CMS\Backend\Controller\ContentElement\
NewContentElementController::main
- No replacement for icon of content wizard availiable.
\TYPO3\CMS\Backend\Controller\Wizard\TableController
- Here skinImg returns just the path to use for input button.
\TYPO3\CMS\Backend\Form
- I cowardly refuse to touch FormEngine until Lolli is done :-)
\TYPO3\CMS\Backend\History\RecordHistory::linkPage
- No icons for revert actions.
\TYPO3\CMS\Backend\Template\DocumentTemplate::getBackendFavicon
- Here just an URL is returned.
\TYPO3\CMS\Backend\Tree\View\AbstractTreeView::getIcon
- Could not find out how to trigger that.
\TYPO3\CMS\Backend\Tree\View\ElementBrowserPageTreeView::printTree
- Could not find out how to trigger that.
\TYPO3\CMS\Backend\Tree\View\FolderTreeView::PMicon
- Could not find out how to trigger that.
\TYPO3\CMS\Backend\Tree\View\FolderTreeView::
getBrowseableTreeForStorage
- Could not find out how to trigger that.
\TYPO3\CMS\Backend\Tree\View\PagePositionMap::JSimgFunc
- Can be ignored, because this function is not used anywhere else in the
  core and will be marked as deprecated within this patch.
\TYPO3\CMS\Backend\Tree\View\PagePositionMap::insertQuadLines
- There is no reasonable replacement for the halfline in the
  sprite icons.
\TYPO3\CMS\Backend\View\PageLayoutView::getTable_tt_content
- No representation in sprite icons found.
\TYPO3\CMS\Backend\View\PageLayoutView::pages_getTree
- No representation in sprite icons found.
\TYPO3\CMS\Backend\View\PageTreeView
- Could not find out how to trigger that.
\ext_posMap::wrapRecordHeader (that is in
backend/Modules/Layout/index.php)
- No representation in sprite icons found.
\ext_posMap::wrapRecordHeader (that is in cms/layout/db_layout.php)
- No representation in sprite icons found.
\TYPO3\CMS\Compatibility6\Controller\Wizard\FormsController::getButtons
- Here skinImg returns just the path to use for input button.
\TYPO3\CMS\Core\Database\QueryGenerator::getFormElements
- Here skinImg returns just the path to use for input button.
\TYPO3\CMS\Core\Integrity\DatabaseIntegrityCheck::genTree
\TYPO3\CMS\Core\Integrity\DatabaseIntegrityCheck::genTree_records
- Could not find out how to trigger that.
\TYPO3\CMS\Fluid\ViewHelpers\Be\PageInfoViewHelper::render
- Could not find out how to trigger that.
\TYPO3\CMS\Impexp\ImportExport::addRelations
- This file does not exists.
\TYPO3\CMS\Impexp\LocalPageTree::ext_tree
- Could not find out how to trigger that.
typo3/sysext/recordlist/Classes/Browser/ElementBrowser.php
- There are some dotted tree lines and blinking arrows without replacement.
\TYPO3\CMS\Reports\ViewHelpers\IconViewHelper::render
- Very generic View Helper
\TYPO3\CMS\Rtehtmlarea\BrowseLinks::getUserLinkSelectorHtml
- No representation in sprite icons found.
\TYPO3\CMS\Rtehtmlarea\PageTree::printTree
- No representation in sprite icons found.
\TYPO3\CMS\Rtehtmlarea\Controller\UserElementsController::main_user
- Could not find out how to trigger that.
\TYPO3\CMS\Taskcenter\Controller\TaskModuleController::renderListMenu
- Found no task with an individual icon file for the menu on the left
  side. So could not test.
\TYPO3\CMS\Version\View\VersionView::getVersionSelector
- No representation in sprite icons found.
\TYPO3\CMS\WizardCrpages\Controller\
CreatePagesWizardModuleFunctionController::getTypeSelectHtml
- Ignored because we are not able to determain the correct sprite icon
  from the TCA at this point of time.

Resolves: #65992
Releases: master
Change-Id: I1071703e8219699353a1d875a6b66a7ed51207b8
Reviewed-on: http://review.typo3.org/38132
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
19 files changed:
typo3/gfx/clip_select.gif [deleted file]
typo3/gfx/edit_fe.gif [deleted file]
typo3/gfx/i/_icon_webfolders.gif [deleted file]
typo3/gfx/import.gif [deleted file]
typo3/gfx/newrecord2_marker.gif [deleted file]
typo3/gfx/newrecord2_marker_d.gif [deleted file]
typo3/gfx/newrecord_marker.gif [deleted file]
typo3/gfx/newrecord_marker_d.gif [deleted file]
typo3/gfx/plusbullet2.gif [deleted file]
typo3/gfx/zoom2.gif [deleted file]
typo3/sysext/backend/Classes/RecordList/ElementBrowserRecordList.php
typo3/sysext/backend/Classes/Tree/View/PagePositionMap.php
typo3/sysext/core/Documentation/Changelog/master/Deprecation-64598-DeprecatePagepositionmapjsimgfunc.rst [new file with mode: 0644]
typo3/sysext/feedit/Classes/FrontendEditPanel.php
typo3/sysext/frontend/Classes/View/AdminPanelView.php
typo3/sysext/recordlist/Classes/Browser/ElementBrowser.php
typo3/sysext/sys_action/Classes/ActionTask.php
typo3/sysext/tstemplate/Classes/Controller/TypoScriptTemplateObjectBrowserModuleFunctionController.php
typo3/sysext/wizard_crpages/Classes/Controller/CreatePagesWizardModuleFunctionController.php