[TASK] Refactor ext:beuser access module 46/36246/9
authorChristian Kuhn <lolli@schwarzbu.ch>
Thu, 22 Jan 2015 20:55:33 +0000 (21:55 +0100)
committerChristian Kuhn <lolli@schwarzbu.ch>
Sun, 25 Jan 2015 20:49:04 +0000 (21:49 +0100)
commitccf93de5080f4a847a73621750b8ac96d80421da
treef15951db3d8d0665313f1590a668132542f17840
parent3b55a5726214e9b837c82c85c77a94231637eb3c
[TASK] Refactor ext:beuser access module

* Move most rendering from PermissionController and
  PermissionAjaxController to fluid
* PermissionController no longer calls methods from
  PermissionAjaxController
* PermissionController no longer loops over the result
  set of getTree() in indexAction to prepare view data
* Fix a couple of minor edge cases and bugs, especially
  some missing labels
* Deprecate some now unused public methods in
  PermissionAjaxController

Even with additional fluid rendering, the module is about
20% quicker with applied patch rendering longish tree lists,
mostly by suppressing tons of calls to the sprite icon API.

Change-Id: Ib3104d147270bc0ccf65f73773baed2a31418953
Resolves: #64489
Releases: master
Reviewed-on: http://review.typo3.org/36246
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
12 files changed:
typo3/sysext/beuser/Classes/Controller/PermissionAjaxController.php
typo3/sysext/beuser/Classes/Controller/PermissionController.php
typo3/sysext/beuser/Classes/Exception.php [new file with mode: 0644]
typo3/sysext/beuser/Classes/ViewHelpers/ArrayElementViewHelper.php [new file with mode: 0644]
typo3/sysext/beuser/Classes/ViewHelpers/PermissionsViewHelper.php [new file with mode: 0644]
typo3/sysext/beuser/Resources/Private/Language/locallang_mod_permission.xlf
typo3/sysext/beuser/Resources/Private/Partials/Permission/Groupname.html [new file with mode: 0644]
typo3/sysext/beuser/Resources/Private/Partials/Permission/Ownername.html [new file with mode: 0644]
typo3/sysext/beuser/Resources/Private/Templates/Permission/Index.html
typo3/sysext/beuser/Resources/Private/Templates/PermissionAjax/ChangeGroup.html [new file with mode: 0644]
typo3/sysext/beuser/Resources/Private/Templates/PermissionAjax/ChangeOwner.html [new file with mode: 0644]
typo3/sysext/beuser/Resources/Private/Templates/PermissionAjax/ChangePermission.html [new file with mode: 0644]