Revert "[TASK] No reference index for workspace delete placeholders" 13/67413/5
authorChristian Kuhn <lolli@schwarzbu.ch>
Wed, 13 Jan 2021 17:56:47 +0000 (18:56 +0100)
committerBenni Mack <benni@typo3.org>
Fri, 22 Jan 2021 22:45:36 +0000 (23:45 +0100)
commitb653ba99da1b3543440a9f0896c635c6c68af136
treef280cc9ba4b30a29e16fb0f2c91d42643cd6edb3
parent158d325210fc043c3e05a4d4789128bf65fc72d6
Revert "[TASK] No reference index for workspace delete placeholders"

This reverts commit 84948b2c4d8740f1dcec352eb357337c23cc28f4.

The strategy to not have reference index entries for
workspace delete placeholders does not work out (for now):

* Workspace ElementEntity class relies on it and is
  used by DataHandler during workspace operations.

* Patch was incomplete: While rows 'from' affected
  records were dropped in refindex, rows 'to' affected
  records were left.

We may later pick this up again, but need more refactoring.

Change-Id: I19b36d011b3cae2c3c17763ace8e5ff22f8dfe9b
Resolves: #93285
Reverts: #93274
Releases: master
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67413
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
19 files changed:
typo3/sysext/core/Classes/Database/ReferenceIndex.php
typo3/sysext/workspaces/Tests/Functional/DataHandling/FAL/Modify/DataSet/deleteContent.csv
typo3/sysext/workspaces/Tests/Functional/DataHandling/FAL/Modify/DataSet/modifyContentNDeleteAllFileReference.csv
typo3/sysext/workspaces/Tests/Functional/DataHandling/FAL/Modify/DataSet/modifyContentNDeleteFileReference.csv
typo3/sysext/workspaces/Tests/Functional/DataHandling/Group/Modify/DataSet/deleteContentOfRelation.csv
typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/CSV/Discard/DataSet/modifyParentNDeleteHotelChild.csv
typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/CSV/Modify/DataSet/deleteParentContent.csv
typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/CSV/Modify/DataSet/modifyParentNDeleteHotelChild.csv
typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/CSV/Publish/DataSet/modifyParentNDeleteHotelChild.csv
typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/ForeignField/Modify/DataSet/deletePage.csv
typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/ForeignField/Modify/DataSet/deleteParentContent.csv
typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/ForeignField/Modify/DataSet/modifyParentNDeleteHotelChild.csv
typo3/sysext/workspaces/Tests/Functional/DataHandling/ManyToMany/Modify/DataSet/deleteCategoryOfRelation.csv
typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Discard/DataSet/deleteLocalizedContentNDeleteContent.csv
typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Discard/DataSet/movePageLocalizedInLiveWorkspaceDeletedToDifferentPageTwice.csv
typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Modify/DataSet/deleteLocalizedContentNDeleteContent.csv
typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Modify/DataSet/movePageLocalizedInLiveWorkspaceDeletedToDifferentPageTwice.csv
typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Publish/DataSet/movePageLocalizedInLiveWorkspaceDeletedToDifferentPageTwice.csv
typo3/sysext/workspaces/Tests/Functional/DataHandling/Select/Modify/DataSet/deleteContentOfRelation.csv