[TASK] Avoid ObjectManager in ext:form FormRuntime
authorChristian Kuhn <lolli@schwarzbu.ch>
Thu, 17 Jun 2021 21:13:02 +0000 (23:13 +0200)
committerChristian Kuhn <lolli@schwarzbu.ch>
Fri, 18 Jun 2021 17:14:47 +0000 (19:14 +0200)
commita3c3e95ea343a841cf2596379a77b76002b2ad81
treec207467798191bbc610d26889f7476877a691305
parent217cdbaf4a85fd25a827e936bc90b98ec1051fc2
[TASK] Avoid ObjectManager in ext:form FormRuntime

Most ObjectManager->get() calls in FormRuntime can
be moved to makeInstance() directly without further
impact. For FormFactoryInterface, a b/w compat layer
is established, but shouldn't be problematic since
this will be ArrayFormFactory in almost all cases.

Change-Id: I354d582260307986cb386506fa5e006646ca816a
Resolves: #94370
Related: #90803
Releases: master
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69515
Tested-by: core-ci <typo3@b13.com>
Tested-by: Jochen <rothjochen@gmail.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Jochen <rothjochen@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
typo3/sysext/form/Classes/Controller/FormEditorController.php
typo3/sysext/form/Classes/Domain/Finishers/FinisherContext.php
typo3/sysext/form/Classes/Domain/Model/FormDefinition.php
typo3/sysext/form/Classes/Domain/Renderer/FluidFormRenderer.php
typo3/sysext/form/Classes/Domain/Runtime/FormRuntime.php
typo3/sysext/form/Classes/ViewHelpers/RenderViewHelper.php
typo3/sysext/form/Configuration/Services.yaml
typo3/sysext/form/Documentation/I/ApiReference/Index.rst
typo3/sysext/form/Documentation/I/Concepts/FrontendRendering/Index.rst
typo3/sysext/form/Tests/Unit/Domain/Runtime/FormRuntimeTest.php