[TASK] Deprecate PageRepository->versioningPreview 47/57047/9
authorBenni Mack <benni@typo3.org>
Fri, 25 May 2018 08:40:05 +0000 (10:40 +0200)
committerChristian Kuhn <lolli@schwarzbu.ch>
Wed, 30 May 2018 20:39:03 +0000 (22:39 +0200)
commit99f26e6742a2f8176ed5999054a7ad30e5ed6b59
tree7fc7b078285e9f5df9bbf982f1f80f9a006390ec
parent26eb262e3aeb372ae472d8eca1aaa71c2952bf75
[TASK] Deprecate PageRepository->versioningPreview

PageRepository has two public properties regarding
fetching records for versioned records:
- versioningPreview (bool)
- versioningWorkspaceId (int)

In order to allow previews of versions, a workspace ID
has to be set - otherwise it fetches live records.

Basically things like: $versioningPreview=false,
$versioningWorkspaceId=3 will make things more confusing.

Instead, versioningPreview is not in use anymore,
and PageRepository solely relies on the parameter
of the workspaceId set.

Resolves: #85078
Releases: master
Change-Id: I70f028854ebc1a83d6d5af18de507284ae89b2ac
Reviewed-on: https://review.typo3.org/57047
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 files changed:
typo3/sysext/core/Classes/Database/Query/Restriction/FrontendWorkspaceRestriction.php
typo3/sysext/core/Classes/Utility/RootlineUtility.php
typo3/sysext/core/Documentation/Changelog/master/Deprecation-85078-PageRepositoryVersioningPreview.rst [new file with mode: 0644]
typo3/sysext/core/Tests/Unit/Database/Query/Restriction/FrontendRestrictionContainerTest.php
typo3/sysext/core/Tests/Unit/Database/Query/Restriction/FrontendWorkspaceRestrictionTest.php
typo3/sysext/core/Tests/Unit/Utility/RootlineUtilityTest.php
typo3/sysext/extbase/Tests/Functional/Persistence/RelationTest.php
typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Storage/Typo3DbBackendTest.php
typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php
typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php
typo3/sysext/frontend/Classes/Page/PageRepository.php
typo3/sysext/frontend/Tests/Functional/Page/PageRepositoryTest.php
typo3/sysext/install/Configuration/ExtensionScanner/Php/PropertyPublicMatcher.php