[TASK] Reduce logic in render methods of YouTube and Vimeo Renderer 15/57415/4
authorDaniel Goerz <ervaude@gmail.com>
Fri, 29 Jun 2018 08:36:12 +0000 (10:36 +0200)
committerFrans Saris <franssaris@gmail.com>
Sat, 30 Jun 2018 06:33:06 +0000 (08:33 +0200)
commit8d214f3b74820f82fa63da0e0537dfa18a230bee
tree201114f88b95ff2e2ccb180580bafa840ca5221b
parentc06a12c44b55955207327f8eae448f236caf690a
[TASK] Reduce logic in render methods of YouTube and Vimeo Renderer

This patch moves the logic from the render method of the
YouTube and Vimeo Renderer to dedicated methods to keep
the render methods themselves as short, clean and simple as
possible.

Also $options is initialized as an empty array as stated
in the interface.

Functionality, Output and Behavior stay unchanged.

Resolves: #85362
Releases: master, 8.7
Change-Id: I00bfc9d7e3bbf97d8a68fbf825a6cf3dd8b2d3aa
Reviewed-on: https://review.typo3.org/57415
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
typo3/sysext/core/Classes/Resource/Rendering/VimeoRenderer.php
typo3/sysext/core/Classes/Resource/Rendering/YouTubeRenderer.php
typo3/sysext/core/Tests/Unit/Resource/Rendering/YouTubeRendererTest.php