[!!!][TASK] Make all enumerations final 76/56976/8
authorMathias Brodala <mbrodala@pagemachine.de>
Wed, 16 May 2018 10:57:56 +0000 (12:57 +0200)
committerAndreas Fernandez <a.fernandez@scripting-base.de>
Fri, 1 Jun 2018 12:57:09 +0000 (14:57 +0200)
commit8cb9506b592141eedae8bd4b46411434bf90e0d0
treeaf385cdd18dc5e0df4acc98a051bef6a1efcdb89
parent4d559269bb3b22b7540a61ddb8eb394ff54c5395
[!!!][TASK] Make all enumerations final

Code which uses enumerations expects a known set of values, adding
more values by extending these classes leads to undefined behavior.

Since it is now impossible to create a mock of an enumeration also
drop a few Enumeration tests and stick to testing of the public API.

Resolves: #85025
Releases: master
Change-Id: I3d0238c85ae916052dc1aa503f7f8e39c1765ac6
Reviewed-on: https://review.typo3.org/56976
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
16 files changed:
typo3/sysext/backend/Classes/Toolbar/Enumeration/InformationStatus.php
typo3/sysext/core/Classes/DataHandling/TableColumnSubType.php
typo3/sysext/core/Classes/DataHandling/TableColumnType.php
typo3/sysext/core/Classes/Resource/DuplicationBehavior.php
typo3/sysext/core/Classes/Type/Bitmask/JsConfirmation.php
typo3/sysext/core/Classes/Type/Bitmask/Permission.php
typo3/sysext/core/Classes/Type/Icon/IconState.php
typo3/sysext/core/Classes/Versioning/VersionState.php
typo3/sysext/core/Documentation/Changelog/master/Breaking-85025-EnumerationsAreNowFinal.rst [new file with mode: 0644]
typo3/sysext/core/Tests/Unit/Type/EnumerationTest.php
typo3/sysext/core/Tests/Unit/Type/Fixture/Enumeration/CompleteEnumeration.php
typo3/sysext/core/Tests/Unit/Type/Fixture/Enumeration/DuplicateConstantValueEnumeration.php
typo3/sysext/core/Tests/Unit/Type/Fixture/Enumeration/InvalidConstantEnumeration.php
typo3/sysext/core/Tests/Unit/Type/Fixture/Enumeration/MissingConstantsEnumeration.php
typo3/sysext/core/Tests/Unit/Type/Fixture/Enumeration/MissingDefaultEnumeration.php
typo3/sysext/indexed_search/Classes/Utility/LikeWildcard.php