[BUGFIX] NewContentElementWizardController to NewContentElementController 79/55479/6
authorOliver Hader <oliver@typo3.org>
Sun, 28 Jan 2018 22:38:22 +0000 (23:38 +0100)
committerOliver Hader <oliver.hader@typo3.org>
Mon, 29 Jan 2018 20:50:26 +0000 (21:50 +0100)
commit8bff8c83c371c92ff0d506df5320ce3a0c0721f3
tree7506f244a069f51de5ade992218febd3082a0153
parentdc5008357c91b96ed8f192bee60cd98cd18985e1
[BUGFIX] NewContentElementWizardController to NewContentElementController

NewContentElementWizardController, which has been introduced for TYPO3 v9
to render the new content element process in a dedicated modal was just a
duplicate of the existing NewContentElementController class with some
minor adjustments and code flow enhancements (names, empty checks).

However, there have been several side effects like:
* hook implementing NewContentElementWizardHookInterface would have been
  called by both object instances, having different public properties -
  the most common access to $parentObject->id or ~->sys_language would
  have failed to to property visibility and change names
* the JavaScript closure callback to adjust the URL when interacting in
  the browser was hard-coded to modal rendering, with still having the
  possibility to render the old behavior e.g. in the web>list view

To overcome these flaws both mentioned classes have been merged since the
functionality was not that much different anyway. Besides that different
JavaScript client scopes ('window' or 'list_frame') are forwarded to the
according object instances.

Resolves: #83705
Releases: master
Change-Id: I472a7ec8a5d06c05e6c7053bf98b5cfacb69f9d9
Reviewed-on: https://review.typo3.org/55479
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
typo3/sysext/backend/Classes/Controller/ContentElement/NewContentElementController.php
typo3/sysext/backend/Classes/Controller/Wizard/NewContentElementWizardController.php [deleted file]
typo3/sysext/backend/Classes/Tree/View/ContentCreationPagePositionMap.php
typo3/sysext/backend/Classes/Tree/View/PagePositionMap.php
typo3/sysext/backend/Configuration/Backend/Routes.php