[TASK] Streamline initialization of PageRepository 31/57431/5
authorBenni Mack <benni@typo3.org>
Sun, 1 Jul 2018 15:24:21 +0000 (17:24 +0200)
committerAndreas Fernandez <a.fernandez@scripting-base.de>
Mon, 2 Jul 2018 12:10:30 +0000 (14:10 +0200)
commit8536595524e066ca2c8314127400bb0cc380d37f
treef422a2e340f6bf2f4162eb8315dca6f42fc7d7b7
parent18cc2e4fac92670c48adf04666f88f54eedd03dd
[TASK] Streamline initialization of PageRepository

PageRepository ($TSFE->sys_page) has an init() function, which sets
some public properties, but is also called from the constructor.

However, there is the ominous $TSFE->setSysPageWhereClause()
which can only be set once the frontend user groups have been resolved.

In order to achieve that, the usergroup initialization within TSFE has
been moved before the intantiation of $TSFE->sys_page, allowing the
pagerepository constructor to set the variables directly, moving all
of the initialization code into PageRepository itself.

Resolves: #85450
Releases: master
Change-Id: I53dbdc0531076a47bcdf04617bfb1eae70e74279
Reviewed-on: https://review.typo3.org/57431
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
typo3/sysext/backend/Classes/Utility/BackendUtility.php
typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php
typo3/sysext/frontend/Classes/Page/PageRepository.php
typo3/sysext/frontend/Tests/Functional/Page/PageRepositoryTest.php
typo3/sysext/viewpage/Classes/Controller/ViewModuleController.php