[TASK] Remove static method variables 67/57167/5
authorChristian Kuhn <lolli@schwarzbu.ch>
Sun, 10 Jun 2018 12:49:01 +0000 (14:49 +0200)
committerAndreas Fernandez <a.fernandez@scripting-base.de>
Sun, 10 Jun 2018 14:42:29 +0000 (16:42 +0200)
commit7e9f22b7077a91792969b504888af9261bf90356
tree586ce7eaa5349201ea4c9f941250533ce05cacbf
parent48e16416b86f0860d10dc98573515fae21f8051c
[TASK] Remove static method variables

Static method variables are even more pita than static class
variables, especially if their state is created from db rows
or path information: It is nearly impossible to get rid of
this state at a later point again, even reflection does not
help here.

The patch abandons all 'static $foo' method variables from
the system, using these strategies:

* Remove some entirely which were used as first level cache
  and only cache-away simple non db related code structures.
* Switch some to use cache framework cache_runtime instead
  which can be evicted easily.
* Use class properties in some cases instead.

Change-Id: Ic699846a2c6ec661ee1124ace50df1aa04a1954b
Resolves: #85206
Releases: master
Reviewed-on: https://review.typo3.org/57167
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
26 files changed:
typo3/sysext/backend/Classes/Form/Utility/FormEngineUtility.php
typo3/sysext/backend/Classes/Tree/View/AbstractTreeView.php
typo3/sysext/backend/Classes/Utility/BackendUtility.php
typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaSelectItemsTest.php
typo3/sysext/backend/Tests/Unit/Form/InlineStackProcessorTest.php
typo3/sysext/backend/Tests/Unit/Utility/Fixtures/ProcessedValueForGroupWithMultipleAllowedTablesFixture.php
typo3/sysext/backend/Tests/Unit/Utility/Fixtures/ProcessedValueForGroupWithOneAllowedTableFixture.php
typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php
typo3/sysext/core/Classes/Resource/OnlineMedia/Processing/PreviewProcessing.php
typo3/sysext/core/Classes/Resource/Processing/LocalImageProcessor.php
typo3/sysext/core/Classes/Resource/ResourceStorage.php
typo3/sysext/core/Classes/Utility/GeneralUtility.php
typo3/sysext/core/Classes/Utility/PathUtility.php
typo3/sysext/core/Tests/Unit/Configuration/FlexForm/FlexFormToolsTest.php
typo3/sysext/core/Tests/Unit/Resource/ResourceStorageTest.php
typo3/sysext/core/Tests/Unit/TypoScript/Parser/TypoScriptParserTest.php
typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.php
typo3/sysext/fluid_styled_content/Classes/ViewHelpers/Link/ClickEnlargeViewHelper.php
typo3/sysext/form/Classes/Domain/Model/Renderable/AbstractRenderable.php
typo3/sysext/form/Tests/Unit/Hooks/DataStructureIdentifierHookTest.php
typo3/sysext/frontend/Classes/Typolink/PageLinkBuilder.php
typo3/sysext/frontend/Classes/Utility/EidUtility.php
typo3/sysext/indexed_search/Classes/FileContentParser.php
typo3/sysext/indexed_search/Classes/Indexer.php
typo3/sysext/lowlevel/Classes/Command/DeletedRecordsCommand.php
typo3/sysext/workspaces/Classes/Command/WorkspaceVersionRecordsCommand.php